From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UrU8MZZn; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1AF535A0265 for ; Thu, 21 May 2026 20:06:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779386794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIfaC3XMOK2ZU+bXk+l+FELD3QJQdIWm/JZ1mRo+4J0=; b=UrU8MZZn0vcfU/qlJUWZprWWb44QsfhjeYCKwgRHWkwbDnnh+Yuj5/hDmyifitd1mPT+g7 gT9YkKAvT8E3ndoxo5LmvGzji7VpXkM0W4ZfXXU60M5Wrf8cEJfA5sZcKdEgI35vfRY6ND /6Dp/fzt3zk+W73cQ+BHI9wABvtWtmc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-8Bbl6ujRPKa1gZIRPKQj7A-1; Thu, 21 May 2026 14:05:21 -0400 X-MC-Unique: 8Bbl6ujRPKa1gZIRPKQj7A-1 X-Mimecast-MFC-AGG-ID: 8Bbl6ujRPKa1gZIRPKQj7A_1779386720 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48fdb2b0cb8so39799465e9.0 for ; Thu, 21 May 2026 11:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779386719; x=1779991519; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hIfaC3XMOK2ZU+bXk+l+FELD3QJQdIWm/JZ1mRo+4J0=; b=e2f9lTGCEFKgWJL8sbifEj292bCDrskkTssH/Ftu6GRDqavpO8B/178bI52q0Vfxyr TBfzT9zjIXSYmXGyG6OFfpixp3UaeG4jkbMF3rijcYALqCMMdoPqpj8Q2TS1FwUZ78EP Gqwg0/F6Fa0jxAcShpoesjZHSNCzeqEn7JL3i+dThVk+gIQ1owSZFarhpejnixTNoJzg udmIl5cVm+wj3Hi1xUIGh7zIb7/cLzix6+8fUvekf1zzpx1ioNzvj47pHJMngLIhX4iT Djh0ofvgZohIsIaI1psT7ZYAcaMK0cNOMP3BFJb3kiwRjIis2KdteziKByuB5kOG5H+j 8jsw== X-Gm-Message-State: AOJu0YzsC6RO4QIAPtymQgfbE/NCgFvXHEClRR9wAOfYS/W4b/h90SQQ qSj87CR5getAKG0foA2gL4l+JpdOLm6hTkgLsCKxVhFz4gEbbbrfCJow/fQpdaR7TTwW/5j0Y/+ C8/0SBfchgm+4ARITmO4qVcEVyPn2G1fQFkYzhwA0tymm5Lm+R7aMlw== X-Gm-Gg: Acq92OGUH8Dqq7Sd63xJKasRtaBA4UGKW21Sgh5bVvW8RMCw7gxjWHqJeD42P9IfFk3 9igJRCLQJ2wYEsboHy538SC3WG5PAZDgZp9MIc7Bv3Vebh+iWPZjdpVXVochF9+DOf5T9eUvS1Y 1RN7ji6ROctuoKKfxPZDiFXIKVb13VUwIIMZnyq7UqUyFJtM8vUzmBW+JFd6E//T1hfl8pSROCS Dn1HDJ49CvPcumQvvG+zlI3rBQcK0D42C8YiaDUrrST8lezyMEh4UgOFa/i6085/+mobD11wGif JhwvAXsMNB6eHLknLyetvhj1YoGF1LOUqfnSvhrj2BUxZCx5oDY+UZJLiccCblruED2vIZYW3aX jdvzHsJo3i56ZSfAH04LWMJ28xDSxcn76rBXjGBz1c12QzGsn6A== X-Received: by 2002:a05:600c:e40b:b0:48f:f199:4c02 with SMTP id 5b1f17b1804b1-4903605a63emr55696505e9.9.1779386719427; Thu, 21 May 2026 11:05:19 -0700 (PDT) X-Received: by 2002:a05:600c:e40b:b0:48f:f199:4c02 with SMTP id 5b1f17b1804b1-4903605a63emr55696045e9.9.1779386718941; Thu, 21 May 2026 11:05:18 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d52c8bsm86733665e9.8.2026.05.21.11.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 11:05:18 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/4] Fix race condition while closing spliced connections Message-ID: <20260521200511.4abc7b66@elisabeth> In-Reply-To: <20260521063745.1211215-1-david@gibson.dropbear.id.au> References: <20260521063745.1211215-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 21 May 2026 20:05:17 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ea8WlCj3CNnGGc2U-emtOm3I2zL532mnSWuzDbjE3-o_1779386720 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3SMOANXA7UO3JHOY5IPABKLXWN7FNLQ2 X-Message-ID-Hash: 3SMOANXA7UO3JHOY5IPABKLXWN7FNLQ2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 21 May 2026 16:37:41 +1000 David Gibson wrote: > Fix bug 202, where a race condition could cause connections to be > incorrectly reset in certain circumstances. > > Patch 2/4 is the bug fix proper. 1/4 improves error reporting and > debugging messages in the vicinity. Patches 3..4/4 are some small > cleanups I noticed in the area while working on the fix. > > Link: https://bugs.passt.top/show_bug.cgi?id=202 > > v2: > * Formatting and comment fixes, per Stefano's review > * Dropped patches 5 & 6 for now. I still think they're worthwhile, > but are closely related to other oddities that need some work. I > didn't want to delay the bugfix itself. I couldn't push this yet as we need to find a solution for the rampstream_in test breakage first, but it all looks good to me and I applied it to my own tree for the moment. -- Stefano