From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NIAoA50C; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 4D9465A0265 for ; Tue, 26 May 2026 18:36:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779813413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=khbdmnv7b36Kr4Lfw2hH6Cjtd45bHa/hLpd6i4NSZ7g=; b=NIAoA50CrpVd4MEWU0BXBRnObUEtY4giB8I4p0+C0ghtEKn2WBsiXdgTLlVAGm1JDNGM5M 8zM8jqIqMPLZ+art2V9Hc+oW+WnaaMQX/VL0GEIG0URLVIuxi3X/sY6ycoXRDy+k0Abhrk bvYD4oX199bK1zeBu/Gb/L6+TfdPuKI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-hjAVRaJQM52iuh8pV2oRgQ-1; Tue, 26 May 2026 12:36:51 -0400 X-MC-Unique: hjAVRaJQM52iuh8pV2oRgQ-1 X-Mimecast-MFC-AGG-ID: hjAVRaJQM52iuh8pV2oRgQ_1779813410 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48fd64c32e8so73243435e9.3 for ; Tue, 26 May 2026 09:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779813410; x=1780418210; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=khbdmnv7b36Kr4Lfw2hH6Cjtd45bHa/hLpd6i4NSZ7g=; b=TtaGV840qByghag4/E6GJ5AwmxnbZyiQqaagCiciLnrFPgQCzjBv62z9+eJqEfzGj1 2sPErPKv7HPAoHJ9WnZrDIbq8P0aVLM+XnYcHb28U5uawxvgqWPnDg6HlZsGyWJ58Q6v +LvwHqsag4GF4YXtgDeeS5YZallIgKmChMp2FZeCmK6jG1H6lm2VslY268ra0U995lIe D9XY+k1tczK7dn5y6gV7aXOKOotVGxPyA6iKWyygaTz1Kbw/dQnI5mc8eELY0jPTTNWD CWAyLimqr5ccUCJq/GYM9P5WQ33Q9ZaEOkRyDyAaoZHgaiIg8yf0Z5t7QAOt+lvX+tX2 Wj0g== X-Forwarded-Encrypted: i=1; AFNElJ/4/jh4ZkGGzni4pwJQ59Wc6gOIZ4WhN+eeYnnM+KNCfY6uErZl8I5sUIPSbxucvjDq7i13oRu1AOo=@passt.top X-Gm-Message-State: AOJu0YzUflal4BW4NRJ2HgzFCzF3Vgp/gxxyZ6UlaYx6eRVnsBzF5rer NcwshxlBB0dlh895JB0YEmA+74t6WuS0yW38T+LND4YKaZxUqfIXPD/5k0I923sxKzF1drs9K8i YzSc8VGL89Qp0mRj/1R4iI0M995LtIyucKluBjfUK4xDSzR5WEX+Z+g== X-Gm-Gg: Acq92OEfSfws3p3MhUP7mk9YpN22ULJPatLFw/q43N7/G4636Euam3RbvMAOgXQd717 DhLikNuctXL6091iKfzOqFwnxgPAN8SoXJlFZHsnNTVLZbbJds+2Zg9ZkOVaLN/z1Xq2zCjqD+I WZbwRciJ+V/zZroLlLhPF2CAn0EL2ihvYOXfA25uJA70RqtztyEBAAtpVu7kaZgPJMtuOi8VrKT +bgDZEBN5UZFr5jemkuFePAYbRgp0j9U+3NSrkuLgv6cCcSOvvscWmEKGHkruDQkGJ5FU79CPXn od3mtdjb0UUz8Nu7r7SvvFMg2THXaZQ7hOlcab1eKH8Zz2gJDWADF1bsLAZ9mMPSem2wrPoEFFP tbeXcCPVF1/GEEnNEXvbQyT7mHVKnOIGrmZIxZsTRlOLVKYAIjQ== X-Received: by 2002:a05:600c:4f0f:b0:490:50e4:7224 with SMTP id 5b1f17b1804b1-49050e474d4mr300443425e9.3.1779813410242; Tue, 26 May 2026 09:36:50 -0700 (PDT) X-Received: by 2002:a05:600c:4f0f:b0:490:50e4:7224 with SMTP id 5b1f17b1804b1-49050e474d4mr300442725e9.3.1779813409753; Tue, 26 May 2026 09:36:49 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d49132sm36990758f8f.24.2026.05.26.09.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 09:36:49 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v2 1/2] vhost_user: Offer VIRTIO_NET_F_GUEST_CSUM Message-ID: <20260526183648.270bfcc5@elisabeth> In-Reply-To: References: <20260416162140.3830027-1-lvivier@redhat.com> <20260416162140.3830027-2-lvivier@redhat.com> <20260526154833.0ac3b042@elisabeth> <5bfefc33-d2ae-4cf6-b14a-617069d40e61@redhat.com> <20260526164833.73fbabdd@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 26 May 2026 18:36:48 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZD9N3TShcBDmUrdOVzRHHHezY-R8d8zXL_SZrj_--wg_1779813410 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7FUF4R7XSXEUHGEGDMHIRX6ESHK2Q43Q X-Message-ID-Hash: 7FUF4R7XSXEUHGEGDMHIRX6ESHK2Q43Q X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 May 2026 16:50:30 +0200 Laurent Vivier wrote: > On 5/26/26 16:48, Stefano Brivio wrote: > > On Tue, 26 May 2026 16:00:55 +0200 > > Laurent Vivier wrote: > > > >> On 5/26/26 15:48, Stefano Brivio wrote: > >>> On Tue, 26 May 2026 14:58:16 +0200 > >>> Laurent Vivier wrote: > >>> > >>>> Hi Stefano, > >>>> > >>>> could you apply this one too? > >>> > >>> Wait, sorry, I skipped the whole series as I thought Anshu was > >>> anyway working on a more general approach for 2/2. > >>> > >>> I should just apply 1/2 instead, right? > >> > >> Yes, Anshu's series cover 2/2 but patch 1/2 fixes a problem between iPXE and passt > >> vhost-user implementation. > > > > ...so I tried applying this one but it has quite a few conflicts with > > your own series that I just applied. > > > > Do you happen to have a rebased version at hand? Otherwise I'll go > > ahead and solve the conflicts myself, they're not complicated. > > > > No, I don't have something already rebased. Applying now. Due to commit dec66c02b5e4 ("udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6()"), merged meanwhile, this part in udp_vu_sock_to_tap(): if (!vu_has_feature(vdev, VIRTIO_NET_F_GUEST_CSUM) || *c->pcap) udp_vu_csum(toside, &data, dlen); became, in udp_vu_prepare(): no_csum = vu_has_feature(c->vdev, VIRTIO_NET_F_GUEST_CSUM) && !*c->pcap; [...] udp_update_hdr4(&iph, &uh, payload, toside, dlen, no_csum); [...] udp_update_hdr6(&ip6h, &uh, payload, toside, dlen, no_csum); -- Stefano