From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Sx7kKBr/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id BADFE5A0262 for ; Wed, 27 May 2026 13:22:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779880939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4/yx1AKmQgIqDaldMN+sdSOApokFZP8bNtRaaM0ylrw=; b=Sx7kKBr/7JyUTMfKHZ8vOlg/wcYZC9Wjz9idrui36/Gy0HN07k8YikzNmLciW7hyF+FBmO 2Ov2ZXIrdio3f/BfiJvODXfZTrouHjmWnjDR/CvyyWgbEXD/V3/3TCOyIcrDoiS2jG8lcH A9gSA3Gi2tb9lXZigGXKHCzSynhJPJU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-e8s_gSDaOxSNQ8rT30y2DA-1; Wed, 27 May 2026 07:22:18 -0400 X-MC-Unique: e8s_gSDaOxSNQ8rT30y2DA-1 X-Mimecast-MFC-AGG-ID: e8s_gSDaOxSNQ8rT30y2DA_1779880937 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48eb0da933fso79491655e9.0 for ; Wed, 27 May 2026 04:22:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779880937; x=1780485737; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4/yx1AKmQgIqDaldMN+sdSOApokFZP8bNtRaaM0ylrw=; b=JIzl+AnnD0tKIUGlbSHmJnl4CWyEdjjVefyI4mc8s2PcAVIEn9cBKOmC6Pa6Pcpurq AciIZ2ybmJI8mYxa8fHtsuUF/VQrENOnHZ1xjQob4nTfhUXSGo/TNJh70e9An/VtNr6p CTbwaXXQQfQ3naamBsjlm44TzEtfv9F1p9TSSv3g16Npe2lP3BbFklJV6YRNvOj6LUUR CNzrbS+v7uCoteV6aLug6UGdVDBRGGjksfiISspj5WUvbOuK1Ew70LTURsj3Czxf1LTY uOspLTLOpD0rySO6gqzrNLZ7wb75SHsRy1ABoLdTzp1OUgMbuhge5BvEpEn2fNB230JU xFfQ== X-Gm-Message-State: AOJu0YxsZGjviZpR9FFR3E9t4oZGNN3qGj59zQtu1IqgFPLuXEl76nAB wEF7CDxq2AJSi8mxquJesLU6+o4JVxMUZ82eOqAkwuSxb6IurOTuiMokSd9FZuqgPgpTs7ElS5W A3FIuwVnYh0GXEqzWBF3nIGO4b+3rMUBTlYH5wERq57cIHnC819bkzQ== X-Gm-Gg: Acq92OFcfwCd7QdmoG7/C5OF1h4yyqJWDBEqlkMjI3dGljw/jTaIAJsjzYxKXNETCJz 1WF3vrc95axxCIo0cobWBwjJatLpRwkiHCXRiOuG+XWsPLpr2dy+9r6tyd91nCwdckUz38b1E4q BVQbB8zKf63chHJXnpkSZ+lJpApt6PJU3R+BUkGqRbuzPV3Jh8CEBZWt0tumbAdCmrK+yK0AHuL UhU7FGBIbFvsuJVzhr/NOoOlLixy7x7oD5zTPNuUt8HYfa4m3o5KgGrcr86OVZMA4z3xsVHA88v w19N5aixB8ssYs3CmLpny1FjFDk4BR5hGuENhF8f0UL8Awqg/0uh0ao2ST/NaOzsn+6qYRoV92J qWSBtQ9bfs4PZ44NUSDQfBIAceR6mnfK1 X-Received: by 2002:a05:600c:a213:b0:48e:8741:fd42 with SMTP id 5b1f17b1804b1-490424ada3bmr244874155e9.12.1779880937100; Wed, 27 May 2026 04:22:17 -0700 (PDT) X-Received: by 2002:a05:600c:a213:b0:48e:8741:fd42 with SMTP id 5b1f17b1804b1-490424ada3bmr244873585e9.12.1779880936615; Wed, 27 May 2026 04:22:16 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4907e6a60c4sm23487555e9.1.2026.05.27.04.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 04:22:15 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/2] Fix a Coverity reported socket leak Message-ID: <20260527132213.5a8ff221@elisabeth> In-Reply-To: <20260513071821.3137329-1-david@gibson.dropbear.id.au> References: <20260513071821.3137329-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 27 May 2026 13:22:15 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aCYWx-LLQo8awZNJ-p7DhSnI2Jo84f9qoVtvsPQE3Uw_1779880937 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: THUIXURXHU3PV2K6M734Q4PDET43O3C5 X-Message-ID-Hash: THUIXURXHU3PV2K6M734Q4PDET43O3C5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 13 May 2026 17:18:19 +1000 David Gibson wrote: > I got coverity working for me again, version 2026.3.0. This pointed > out a potentially fairly nasty socket leak in tcp_listen_handler(). > Here's a series that fixes it. > > David Gibson (2): > tcp, tcp_splice: Make helper for setting SO_LINGER socket option > tcp: Don't leak sockets on error paths Applied, sorry for the delay. I was wondering if Jon wanted to eventually take these in a series fixing more warnings and waited a bit (which turned out to be longer than I thought) but 2/2 could fix some real issues and we have a report: https://github.com/containers/podman/issues/28644 that might actually be fixed by that. I'm now asking the reporter if they can try out this fix. -- Stefano