From: Anshu Kumari <anskuma@redhat.com>
To: passt-dev@passt.top, anskuma@redhat.com, sbrivio@redhat.com
Cc: david@gibson.dropbear.id.au, jmaloy@redhat.com, lvivier@redhat.com
Subject: [PATCH v3 2/6] conf: Add --dhcp-boot command-line option
Date: Mon, 1 Jun 2026 13:07:52 +0530 [thread overview]
Message-ID: <20260601073758.1571317-3-anskuma@redhat.com> (raw)
In-Reply-To: <20260601073758.1571317-1-anskuma@redhat.com>
Introduce the --dhcp-boot flag that sets the boot file URL for
network boot specially for ipxe. This patch adds the option
storage and CLI parsing.
Link: https://bugs.passt.top/show_bug.cgi?id=192
Signed-off-by: Anshu Kumari <anskuma@redhat.com>
---
v3:
- case 32 now calls dhcp_add_option(c, 67, optarg).
- Handles duplicate codes: --dhcp-boot and --dhcp-opt 67 coexist
correctly, last value wins.
v2:
- Removed separate dhcp_boot[PATH_MAX] field — --dhcp-boot foo now stores into custom_opts[] as code 67 (same as --dhcp-opt 67,foo)
---
conf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/conf.c b/conf.c
index ce78af1..f7281e2 100644
--- a/conf.c
+++ b/conf.c
@@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int status)
" a single, empty option disables the DNS search list\n"
" -H, --hostname NAME Hostname to configure client with\n"
" --fqdn NAME FQDN to configure client with\n"
+ " --dhcp-boot URL Boot file URL for network boot\n"
" --dhcp-opt CODE,VAL Set DHCP option by code\n");
if (strstr(name, "pasta"))
FPRINTF(f, " default: don't use any search list\n");
@@ -1239,6 +1240,7 @@ void conf(struct ctx *c, int argc, char **argv)
{"migrate-no-linger", no_argument, NULL, 30 },
{"stats", required_argument, NULL, 31 },
{"conf-path", required_argument, NULL, 'c' },
+ {"dhcp-boot", required_argument, NULL, 32 },
{"dhcp-opt", required_argument, NULL, 33 },
{ 0 },
};
@@ -1475,6 +1477,9 @@ void conf(struct ctx *c, int argc, char **argv)
die("Can't display statistics if not running in foreground");
c->stats = strtol(optarg, NULL, 0);
break;
+ case 32:
+ dhcp_add_option(c, 67, optarg);
+ break;
case 33:
comma = strchr(optarg, ',');
if (!comma)
--
2.54.0
next prev parent reply other threads:[~2026-06-01 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 7:37 [PATCH v3 0/6] Add --dhcp-boot and --dhcp-opt options Anshu Kumari
2026-06-01 7:37 ` [PATCH v3 1/6] conf: Add --dhcp-opt command-line option Anshu Kumari
2026-06-02 2:00 ` David Gibson
2026-06-01 7:37 ` Anshu Kumari [this message]
2026-06-02 2:02 ` [PATCH v3 2/6] conf: Add --dhcp-boot " David Gibson
2026-06-01 7:37 ` [PATCH v3 3/6] dhcp: Add option type table and value parser Anshu Kumari
2026-06-02 2:23 ` David Gibson
2026-06-01 7:37 ` [PATCH v3 4/6] dhcp: Refactor fill_one() to operate on a generic buffer Anshu Kumari
2026-06-02 2:25 ` David Gibson
2026-06-01 7:37 ` [PATCH v3 5/6] dhcp: Add option overload Anshu Kumari
2026-06-02 2:50 ` David Gibson
2026-06-01 7:37 ` [PATCH v3 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Anshu Kumari
2026-06-02 2:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601073758.1571317-3-anskuma@redhat.com \
--to=anskuma@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).