From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Wpgch7UO; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id AEE9C5A0265 for ; Fri, 05 Jun 2026 08:28:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780640933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acgmMUfJ9wRe5Sq7OsHos4VhUhhDll+FnKdcNqRPY6A=; b=Wpgch7UOg0iX586NnrBTIHWeXVbj5gSRlGw/SsJUir/OX5czN1BjTrYtpHd+MhomGsGx5D 2TzDHZyan7WkeuNM7M2i5is6wFkL93TDNJ91hhZaBVeCBKleWggb+FS56jrtwcrfMJNvCi kPSAxZAJeYdkqNymYa4WvbYo/FaykT8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-j64sMo0uMhWm_SMP0qshPw-1; Fri, 05 Jun 2026 02:28:51 -0400 X-MC-Unique: j64sMo0uMhWm_SMP0qshPw-1 X-Mimecast-MFC-AGG-ID: j64sMo0uMhWm_SMP0qshPw_1780640930 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45ef5e38a18so715912f8f.1 for ; Thu, 04 Jun 2026 23:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780640930; x=1781245730; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=acgmMUfJ9wRe5Sq7OsHos4VhUhhDll+FnKdcNqRPY6A=; b=iHgze68+7lbAQwExxssdaCuwD0FIh8gv8k12gnF/nodqZtMSiN2VtZTk20FALD8E22 iP9QSBY0cXpqCpzYgx/FOZBMZt7CXaxgYnOwKa5kLOhLguJWQVaenDVOsTAi+bYDPaLS yyISGS0aInePEHFjXVV96QvngEOrhfNmK4ioHacJkOUTPRFx6EnyjK+0HJQa0X7+wYJm 2j6IievvQgm05K3R3kBFkrHbguBodftVOiX10cml5sEw8nlymdevaUtdnIdJJ6VE6we/ DrSfIY6qQYACT8+Z4wZHHkZTiyseYw4M/tKPWH8S5qrJGKsN4k81WolCwhdVVgwdT3vT 8qZg== X-Gm-Message-State: AOJu0Yyg3Ok1JGWVlnnjxqDOa1KyuQbc9PrF/TkCkkj1VRtn1RgCmwhN b9OaBbSrJ6lnyCP4HcgttNCZU8j4rTTxsaRwiot0C+O5bTFFC/Mn5qnY+vRJUhFuyNxvodlffvt o8wtYywQ8lZyBAEF1V+9uypqX9Tpm/3ZAGwVqVxFXdaWBe0t1rm3VOsi/brR9BQ== X-Gm-Gg: Acq92OG6t8dhO6No4LuoWi6QEfdi54DfhnYQBqHhel8C4Fz5T/Doy8DYlkbYMcRTdkF 4sZhnCV/Jx31WGo2fsDYmEkCPSFkl1atjajiAsnb/JKiBHKPrDoGlejenoJrdeJPkKEsOuz8gzp g3h2O3WF7SMi/D2ZTKtyU+xbyhMiFhNpbL895aEVGsRLA5iYBZ5tZ5hMAL44Szz6EbVci6M3s+Y +mKlTMQySZPhuQWc19J3+QF1G9sZjEvNT8qkEMlxKiteq6WKBBRhBQR62SHAtOJN6VgFN5Z4gQU tFiqZxIkSn3BvlYnzmonQwSU0RZ4VrB20XP4OZOe3oEyesOvdM8STUx2hbGBtw0xAS3jHOh2aIQ kizGPmAwGKDB3TZA7H708u6fDTHvnlIzCakJvOY0T6AFmhDUSnJd4g1EZFeh5 X-Received: by 2002:a05:6000:1f0a:b0:460:1684:ba11 with SMTP id ffacd0b85a97d-460302e8b72mr2425790f8f.15.1780640929913; Thu, 04 Jun 2026 23:28:49 -0700 (PDT) X-Received: by 2002:a05:6000:1f0a:b0:460:1684:ba11 with SMTP id ffacd0b85a97d-460302e8b72mr2425751f8f.15.1780640929359; Thu, 04 Jun 2026 23:28:49 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d40sm22678193f8f.26.2026.06.04.23.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 23:28:48 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/8] splice() forwarding cleanups Message-ID: <20260605082847.3f056af1@elisabeth> In-Reply-To: <20260528050213.679685-1-david@gibson.dropbear.id.au> References: <20260528050213.679685-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 05 Jun 2026 08:28:48 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YVJ_scqUn1Wtz5Rvh7QCDNQB1pq30drNBVHZlXuTl6w_1780640930 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 5VFQV3X7OQWHKYGE3FPVTQZGSMXETQ7P X-Message-ID-Hash: 5VFQV3X7OQWHKYGE3FPVTQZGSMXETQ7P X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 28 May 2026 15:02:05 +1000 David Gibson wrote: > As we discussed on an earlier call, while fixing bug 202 I noticed a > number of warts in the surrounding splice() forwarding code. Most are > just things that are longer or harder to follow than they need to be, > but in some cases there may be real (if unlikely to trigger) bugs. > Here's a collection of fixes. > > David Gibson (8): > tcp_splice: Remove never-invoked SO_RCVLOWAT logic > tcp_splice: Simplify EPOLLRDHUP / eof / FIN handling > tcp_splice: Improve EOF exit condition for the loop > tcp_splice: Remove goto from forwarding loop > tcp_splice: Simplify shutdown(2) handling > tcp_splice: Simplify / correct OUT_WAIT flag handling > tcp_splice: Remove questionable "optimisation" of pending bytes > tracking Applied up to here (7/8). > tcp_splice: Exit forwarding earlier when stalled read side > > tcp_splice.c | 100 ++++++++++++++++----------------------------------- > 1 file changed, 31 insertions(+), 69 deletions(-) -- Stefano