public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/4] RFC: Improvements to flow specific logging
Date: Tue,  9 Jun 2026 12:32:22 +1000	[thread overview]
Message-ID: <20260609023226.86058-1-david@gibson.dropbear.id.au> (raw)

While working on podman bug 23739, I found some deficiences in how and
when we report various socket errors related to specific flows.  Here
are some preliminary patches to improve that.

I think patches 1..3 are pretty straightforward and safe.  4/4 I think
is a good idea in principle - promoting the priority of a number of
messages now that we have ratelimiting.  However, plumbing 'now' all
the places we need it resuls in a *lot* of churn, so we might want to
postpone or split it up.

Still, current drafted posted for consideration.

David Gibson (4):
  flow: Regularise flow specific logging helpers
  flow: Include flow details with higher priority log messages
  flow: Safer errno handling in flowside_connect() callers
  flow, treewide: Promote priority of selected flow-linked messages

 flow.c         | 107 +++++++-------
 flow.h         |  72 +++++-----
 icmp.c         |  27 ++--
 icmp.h         |   3 +-
 migrate.c      |  27 ++--
 migrate.h      |   8 +-
 passt.c        |   8 +-
 tcp.c          | 381 ++++++++++++++++++++++++++++---------------------
 tcp.h          |   5 +-
 tcp_buf.c      |  78 +++++-----
 tcp_buf.h      |   8 +-
 tcp_conn.h     |   8 +-
 tcp_internal.h |  27 ++--
 tcp_splice.c   |  59 +++++---
 tcp_splice.h   |   3 +-
 tcp_vu.c       |  42 +++---
 tcp_vu.h       |   6 +-
 udp.c          |  48 ++++---
 udp_flow.c     |  22 +--
 19 files changed, 535 insertions(+), 404 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-06-09  2:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  2:32 David Gibson [this message]
2026-06-09  2:32 ` [PATCH 1/4] flow: Regularise flow specific logging helpers David Gibson
2026-06-09  2:32 ` [PATCH 2/4] flow: Include flow details with higher priority log messages David Gibson
2026-06-09  2:32 ` [PATCH 3/4] flow: Safer errno handling in flowside_connect() callers David Gibson
2026-06-09  2:32 ` [PATCH 4/4] flow, treewide: Promote priority of selected flow-linked messages David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609023226.86058-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).