From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=IrWNKsgE; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 464725A0269 for ; Tue, 09 Jun 2026 04:32:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1780972349; bh=BvIP2w3F9wQ7M2kYWK+gn1RCWjnyX9CCRZ1tEYAYKhY=; h=From:To:Cc:Subject:Date:From; b=IrWNKsgEoIHYBBuNeD6sp3SErAw3vSPoOV/sCEe2azsONEgT4yXuByHjQCljwtpss vtwiRNnrLkNKOEFd/W2NDoIc/u183bKxen4D/coeshQSa44qVlvOdfWQKPD9t86JDq ej1u1u3AX2qe9jgm+KlH/XW5wfnuMOXv+eygCYkSKUSLH0bzpiUXQXBOZbEY4jmU51 3MLvd96kEFuBSUlBoHXcuII4fMeEa0WJQ5lfWioNMmBqos0B4EvjogCahX0/+eVXPl BHSTEy54xfGi9zKOOIGpnqbqbsiHc3DGyuGLUJMl/QcRLDiyPSADAEGpWUqszsqkFf 2ja0KcunQDBAA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gZCcF0bQzz4wTL; Tue, 09 Jun 2026 12:32:29 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 0/4] RFC: Improvements to flow specific logging Date: Tue, 9 Jun 2026 12:32:22 +1000 Message-ID: <20260609023226.86058-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: MEJSKQMPOSHTRCN3E7RJ2HEQ5XHWTNHC X-Message-ID-Hash: MEJSKQMPOSHTRCN3E7RJ2HEQ5XHWTNHC X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While working on podman bug 23739, I found some deficiences in how and when we report various socket errors related to specific flows. Here are some preliminary patches to improve that. I think patches 1..3 are pretty straightforward and safe. 4/4 I think is a good idea in principle - promoting the priority of a number of messages now that we have ratelimiting. However, plumbing 'now' all the places we need it resuls in a *lot* of churn, so we might want to postpone or split it up. Still, current drafted posted for consideration. David Gibson (4): flow: Regularise flow specific logging helpers flow: Include flow details with higher priority log messages flow: Safer errno handling in flowside_connect() callers flow, treewide: Promote priority of selected flow-linked messages flow.c | 107 +++++++------- flow.h | 72 +++++----- icmp.c | 27 ++-- icmp.h | 3 +- migrate.c | 27 ++-- migrate.h | 8 +- passt.c | 8 +- tcp.c | 381 ++++++++++++++++++++++++++++--------------------- tcp.h | 5 +- tcp_buf.c | 78 +++++----- tcp_buf.h | 8 +- tcp_conn.h | 8 +- tcp_internal.h | 27 ++-- tcp_splice.c | 59 +++++--- tcp_splice.h | 3 +- tcp_vu.c | 42 +++--- tcp_vu.h | 6 +- udp.c | 48 ++++--- udp_flow.c | 22 +-- 19 files changed, 535 insertions(+), 404 deletions(-) -- 2.54.0