From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=NxZuuL6n; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B26B45A0269 for ; Tue, 09 Jun 2026 08:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1780986609; bh=PbJ5H1iqC/J6/0gfBzTE4144WDSHo5KEpXNK/Gu91Oc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NxZuuL6niFl0MKPjIu1B6oG9h3Py88+zM8F9TOZBD/GtmSvqBmIylK2N4j0kpNAST 2KM9dF+kbTKdf2JOF27gs1g2MRvUgO2wPKZoj7majhoL+vOslsX7Fvf77OyfNI5nch 5sEY8xmtWO4xsEX453/MLEmkjEOCA/Y0vfGOJ/1Ka6Qj3AXFHicuIUKQ/mD/ZqDru6 B3DTPRJ/VgKZgIgXbZtmk6V3TsikczWH6VstvTiibk2JCRcr5+3yRFTL3v/qqyi4TC slvFXQDvBlEKhKa/oMXePH2H2OtKTv4paL8vq8ETb/Tg/5XqQZLgW2S9HCYYUDuGin iVG5W63ku231g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gZJtT0Jpgz4wSK; Tue, 09 Jun 2026 16:30:09 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 1/4] flow: Correct misleading signature of flowside_sock_l4() Date: Tue, 9 Jun 2026 16:30:02 +1000 Message-ID: <20260609063005.113744-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609063005.113744-1-david@gibson.dropbear.id.au> References: <20260609063005.113744-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 7FILU37LUSYWZXKHKOQZPX5FLPM7H4TO X-Message-ID-Hash: 7FILU37LUSYWZXKHKOQZPX5FLPM7H4TO X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: flowside_sock_l4() takes a @tgt parameter with the side to create a socket for. The name is misleading, however, although ICMP only uses it for the target side of the flow, UDP can use it for either or both sides. TCP doesn't use it at all. Rename it to @side. While we're there remove the stale comment for the @data paremeter which was removed in 05972c7c4daf. Fixes: 05972c7c4daf ("util: Move epoll registration out of sock_l4_sa()") Signed-off-by: David Gibson --- flow.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/flow.c b/flow.c index 565ed2b2..7a5c81c2 100644 --- a/flow.c +++ b/flow.c @@ -207,25 +207,24 @@ static int flowside_sock_splice(void *arg) * @c: Execution context * @type: Socket epoll type * @pif: Interface for this socket - * @tgt: Target flowside - * @data: epoll reference portion for protocol handlers + * @side: Flowside to create a socket for * - * Return: socket fd of protocol @proto bound to our address and port from @tgt + * Return: socket fd of protocol @proto bound to our address and port from @side * (if specified). */ int flowside_sock_l4(const struct ctx *c, enum epoll_type type, uint8_t pif, - const struct flowside *tgt) + const struct flowside *side) { const char *ifname = NULL; union sockaddr_inany sa; assert(pif_is_socket(pif)); - pif_sockaddr(c, &sa, pif, &tgt->oaddr, tgt->oport); + pif_sockaddr(c, &sa, pif, &side->oaddr, side->oport); switch (pif) { case PIF_HOST: - if (inany_is_loopback(&tgt->oaddr)) + if (inany_is_loopback(&side->oaddr)) ifname = NULL; else if (sa.sa_family == AF_INET) ifname = c->ip4.ifname_out; -- 2.54.0