From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 2/4] Makefile: Remove unused DUAL_STACK_SOCKETS define
Date: Tue, 9 Jun 2026 16:30:03 +1000 [thread overview]
Message-ID: <20260609063005.113744-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260609063005.113744-1-david@gibson.dropbear.id.au>
We have a make variable DUAL_STACK_SOCKETS which used to determine whether
we'd use dual stack sockets. When we introduced it we were concerned that
we might have future ports to systems which did not support them.
We've since discovered that the dual stack interface is described in
RFC 3493, and supported by both Windows and BSD. Platforms sometimes
differ in the default setting for the IPV6_V6ONLY socket option, but the
feature itself is widely supported. So, since b8d4fac6a2e7 ("util, pif:
Replace sock_l4() with pif_sock_l4()") we've simply assumed its presence.
The makefile still defines the now unused variable, though. Remove it.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Makefile b/Makefile
index 0a0a60b0..a8c09815 100644
--- a/Makefile
+++ b/Makefile
@@ -11,10 +11,6 @@
VERSION ?= $(shell git describe --tags HEAD 2>/dev/null || echo "unknown\ version")
-# Does the target platform allow IPv4 connections to be handled via
-# the IPv6 socket API? (Linux does)
-DUAL_STACK_SOCKETS := 1
-
TARGET ?= $(shell $(CC) -dumpmachine)
$(if $(TARGET),,$(error Failed to get target architecture))
# Get 'uname -m'-like architecture description for target
@@ -33,7 +29,6 @@ endif
BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG)
BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)
BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\"
-BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS)
BASE_CFLAGS := -std=c11 -pie -fPIE -O2
BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security
--
2.54.0
next prev parent reply other threads:[~2026-06-09 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 6:30 [PATCH 0/4] Assorted minor socket creation cleanups David Gibson
2026-06-09 6:30 ` [PATCH 1/4] flow: Correct misleading signature of flowside_sock_l4() David Gibson
2026-06-09 6:30 ` David Gibson [this message]
2026-06-09 6:30 ` [PATCH 3/4] fwd, pif: Remove duplicated logic between tcp_listen() and udp_listen() David Gibson
2026-06-09 6:30 ` [PATCH 4/4] pif, util: Move listen(2) call from sock_l4_() to pif_listen() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609063005.113744-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).