From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YnXs8LjQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 506BC5A026D for ; Fri, 12 Jun 2026 01:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781219112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LFssvhDMpQw7fm6f4B+iC5+6vp4juauoU2arY0kIwKo=; b=YnXs8LjQ6lpqhFI2Bj6wPgxlXCF93BusTkYkW0QIcdQeU+YHEnE6rJU7OF+8CeM1dKBncC J6Yi9TZOog+QMzfav8M9PWBmG1QZUTBy+lbuDYyUHVwnz/08LsOZbemPIPwP8bGCnbq6Kn 6eQBlxuuMijlahWGYnznUEoX31pdVxc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-xFwm9m5HOaG-6k_eJ9fWoQ-1; Thu, 11 Jun 2026 19:05:08 -0400 X-MC-Unique: xFwm9m5HOaG-6k_eJ9fWoQ-1 X-Mimecast-MFC-AGG-ID: xFwm9m5HOaG-6k_eJ9fWoQ_1781219105 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-45eecec7667so200518f8f.3 for ; Thu, 11 Jun 2026 16:05:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781219105; x=1781823905; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LFssvhDMpQw7fm6f4B+iC5+6vp4juauoU2arY0kIwKo=; b=geNzZF4gG5v2TB2CwU3Nkv7yGmUhOBlXt5RLa6pGETKZSARc66J/fYYjHMssfs5eC0 oOPKg3ybXgzYuZQCa1FrHGGDGajRn1PjUBzczqi3lrEgBPwDUFnji16MEMgdK7UkGjfi EFoXUJWUXBSwasDE7yfmJDHT14zOnrJWW4/Q1FINXNGckvNlmCEs5dtz4dkP3FT9tJue /M/S16KzaceEpINWNEz2FQlyP6+7QGe6Qh19p1SkAuqsJLDQBVKsvLi+zbiw/bG7Rw1+ PazQAOXbpaFYAeZ6jDpthKJSp3Ec7Xf3RbHCENRCOIzy2b/kyfmeQKsD9cKN6hi+8r37 B6lA== X-Gm-Message-State: AOJu0YxvqycRcX3gw9rTyueBCznioM8apHauNoQGXTD3DMTd1emryiis ydgMnS11ZDtWUTRvXtUMXtm+Z53jPgojLSyXUha31JyZ3E1s9W0keglv7h9CoVfpvj+XdJb4OdG iIvXju2GanSJosxTjB7on4S9iAubABMOjOD3wbm39qWezswPKmPlQQQ== X-Gm-Gg: Acq92OH0p8QX2Dv3o/0kWcrypkmL5i1WBGFDVeeXwdbgVdcOOEYyUetDlRAYu8raWY8 Xb7hR3rba/BHISSuI9MKbU57x1h15o4KglZRloi5DyKQ6L5qQL6tRTNTUzjMdACKg53gddCFYlF brMrr+Bi+c71pmBkDFT48CTt3bzKeanElvzZI/rmGav2qbskmV5Pgod+CUq0mDlJBNSOA0FADVq W5GsF8riRcdctuSqVtNZTceBcEKCLuVbJtOXX1XnFuGKSxCLQ14MfZIliWHjMug8M5VnOg/pEUd uaz7LZi4BII25ek5b/AaJYEj6aWLqY9hWScXmgjB7UV+DAOGNsRC0RdZO2nHsBP8t3i+3LFME7b X3owVAzI9tWrcuXFvQGeQTSqS3xCHdz6s X-Received: by 2002:a5d:5f88:0:b0:439:b8b2:fad0 with SMTP id ffacd0b85a97d-4606da69b1fmr533719f8f.5.1781219104503; Thu, 11 Jun 2026 16:05:04 -0700 (PDT) X-Received: by 2002:a5d:5f88:0:b0:439:b8b2:fad0 with SMTP id ffacd0b85a97d-4606da69b1fmr533685f8f.5.1781219103948; Thu, 11 Jun 2026 16:05:03 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2c4240sm43119f8f.27.2026.06.11.16.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 16:05:03 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH v3 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Message-ID: <20260612010502.381e88f8@elisabeth> In-Reply-To: <20260601073758.1571317-7-anskuma@redhat.com> References: <20260601073758.1571317-1-anskuma@redhat.com> <20260601073758.1571317-7-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 12 Jun 2026 01:05:02 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rpaBkjtT6MPwOlEj9RfINAt8VX5Xr8aEgwSs1DJk6Fc_1781219105 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WDSFIXUPLKTGMZXW73AQL4N7PCO7VQ7W X-Message-ID-Hash: WDSFIXUPLKTGMZXW73AQL4N7PCO7VQ7W X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 1 Jun 2026 13:07:56 +0530 Anshu Kumari wrote: > Document the new --dhcp-boot and --dhcp-opt command-line options in > the passt(1) man page, including supported option codes grouped by > value type and usage examples. > > Link: https://bugs.passt.top/show_bug.cgi?id=192 > Signed-off-by: Anshu Kumari > --- > v3: > - Removed options 33, 55, 61, 119 from supported codes list > - Added note: "If the same name option code is given more than once, > the last value wins". > > v2: > - Updated --dhcp-boot description. > - Highlighted cross-referenced options with \fB...\fR. > - Updated IP list format from "space-separated within quotes" to "comma-separated". > - option 121 dropped. > - Added option 55 to string options list. > - Removed --dhcp-boot override reference from --dhcp-opt description. > --- > passt.1 | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/passt.1 b/passt.1 > index 908fd4a..57e2cc1 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -430,6 +430,47 @@ Send \fIname\fR as DHCP option 12 (hostname). > FQDN to configure the client with. > Send \fIname\fR as Client FQDN: DHCP option 81 and DHCPv6 option 39. > > +.TP > +.BR \-\-dhcp-boot " " \fIurl > +Convenience shorthand for \fB\-\-dhcp-opt\fR 67,\fIurl\fR. > +Sets the boot file name (DHCP option 67) for network boot. > +For UEFI HTTP boot, also set the vendor class identifier using > +\fB\-\-dhcp-opt\fR 60,HTTPClient. This is ambiguous. The man page is written in an imperative style in the sense of what the tool is supposed to do, but this becomes a recommendation to the user instead (this sentence says "set" and not "sets" but that's very easy to miss, and ambiguous nevertheless). This would be clearer I think: For UEFI HTTP boot, the vendor class identifier also needs to be set using ... > + > +.TP > +.BR \-\-dhcp-opt " " \fICODE\fR,\fIVALUE\fR > +Set a DHCP option by numeric code. The value format is determined automatically > +from the option code. Multiple IPv4 addresses are comma-separated. > +This option can be specified multiple times. If the same option code is > +given more than once, the last value wins. Options set with > +\fB\-\-dhcp-opt\fR override built-in values. > +Only the following option codes are supported (unsupported codes cause an error): By the way, eventually, I think it would be nice to support those as hex encoding, maybe with a --dhcp-opt-raw parameter taking a length value (also comma-separated, say, CODE,LENGTH,VALUE). I guess it's beyond the scope of this series though. > +.RS > +.TP > +.B IPv4 address options > +1 (Subnet Mask), 16 (Swap Server), 28 (Broadcast Address), 50 (Requested IP), > +54 (Server Identifier) > +.TP > +.B IPv4 address list options (comma-separated) > +3 (Router), 4 (Time Server), 5 (Name Server), 6 (DNS), 7 (Log Server), > +8 (Cookie Server), 9 (LPR Server), 10 (Impress Server), > +11 (Resource Location Server), 41 (NIS Servers), > +42 (NTP Servers), 44 (NetBIOS Name Server) > +.TP > +.B Integer options > +2 (Time Offset, 32-bit), 13 (Boot File Size, 16-bit), 19 (IP Forwarding, 8-bit), > +23 (Default IP TTL, 8-bit), 26 (Interface MTU, 16-bit), > +37 (TCP Default TTL, 8-bit), 38 (TCP Keepalive Interval, 32-bit), > +51 (IP Address Lease Time, 32-bit), > +53 (DHCP Message Type, 8-bit), 57 (Max DHCP Message Size, 16-bit), > +58 (Renewal Time, 32-bit), 59 (Rebinding Time, 32-bit) > +.TP > +.B String options > +12 (Host Name), 15 (Domain Name), 17 (Root Path), 40 (NIS Domain Name), > +60 (Vendor Class Identifier), 66 (TFTP Server Name), > +67 (Bootfile Name), 252 (WPAD URL) > +.RE > + > .TP > .BR \-t ", " \-\-tcp-ports " " \fIspec > Configure TCP port forwarding to guest or namespace. \fIspec\fR can be one of: The rest looks good to me. -- Stefano