From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KImQV+Qn; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 64C7C5A0265 for ; Fri, 12 Jun 2026 01:05:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781219111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+CZ5w1U35Nhxy4rB4gQrG4pJurfpxVzMWQEWL2JgFnE=; b=KImQV+QnYXy+MH8naXOXctoItJdLkP6KuhmEb5kg18rIddfy55gbu5csz3DhWEhCP5vaij rJLxt6J2Oa7V53KkmajSYWXakIOIz4EAddhWwNfyaxnJPkfsrtsb7shRAav/oulzc37xi4 nswM3PIdN8R+xDNqrJZuC20x8EBPM7Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-DFiiK0bEPYyQbu7ONb0gMg-1; Thu, 11 Jun 2026 19:05:10 -0400 X-MC-Unique: DFiiK0bEPYyQbu7ONb0gMg-1 X-Mimecast-MFC-AGG-ID: DFiiK0bEPYyQbu7ONb0gMg_1781219109 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490a767b782so1921535e9.2 for ; Thu, 11 Jun 2026 16:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781219109; x=1781823909; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V2miwWNyOVNAF04qMfFKzETrfF3g7EF1WDoCB6go1bU=; b=cUSUzs+1/IDDnSrd4qZ8qiSHkuya/J9tPhxv/WX7upU5AJ3saWkGgwFyW1Ez5Z1P6j ejjmfJxerd7ETfcTHo4AegpZ7/C10E8mMrxNdLQk8aDQLl8CErGLECHUk1U2xvXodx2a go3VF/Ut0ZtRfoaKz+X43+xaaBGcVz22vy+obTzO2pxParN6iAgj6J2gbhOtfZtbOSxM xXUEoCwvCx+fM4g3O7fFKzsZN0eRSBsGxmVJpAGvRfm2uM7tYzCjlnJyLNAHIhwf30Gb pPFTY0n6RneaiLPZ0XtYwV1p7yHESCselFmL5WjXX3kDtv+e0k7033uQbp4F2+lSlkD9 z2Sg== X-Gm-Message-State: AOJu0YwK+OOotJPKnprnRhzqJruP5rSPdXBWTArOO8KGWpM6BbHYtoph 430lD8rrOQVft//Q18cPA6Ect7ZOtr5VQxuJJA1opitodcW8QpcFuE40n67vovv811qMOgCs+Vo 23cxVtwVh0AF3QRmGvEWZ8Z5q+C41sna/AEhYcoIKhSq/aB9xxzcYXQ== X-Gm-Gg: Acq92OGh/h61t8ypZjhtaFLJqV5yt8twCsydPo3oCF1zgt22XIqPA7QmbsyCGXsJ6Xq 97fCV3Je82p6LOToj/ZLp8TOLfJNbFjK4pYQxz+/hQtwbgAho55dShKac4sWcXoBX3EujlZNuTn Rq0H0bCJGSv817qRRpMc89N7cKLLsIf1F1hz144hOv6lOLwYnwtGg3T0PfUUbj/CmsJq4TdyMWK fh59nbPzlM+LN7uIFQXej8bRWRmJfqDFWPpcfZPbd03RCz2kceBoyyMeVHWzhezkt8eddmNq/t7 ChC6cbkAjGCiJY0gq96rJv95OfFM/P99dmW8OMvzHqcmla8OqUt68WeQ1RwQ3iA16xt0tHZJHPJ TcgZSGlT4unAop7DsDO/a9iJNvc/8Vl5v X-Received: by 2002:a05:600c:4881:b0:490:6237:5200 with SMTP id 5b1f17b1804b1-490ec4cde03mr421525e9.10.1781219108610; Thu, 11 Jun 2026 16:05:08 -0700 (PDT) X-Received: by 2002:a05:600c:4881:b0:490:6237:5200 with SMTP id 5b1f17b1804b1-490ec4cde03mr421335e9.10.1781219108161; Thu, 11 Jun 2026 16:05:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea83d8dasm21613675e9.11.2026.06.11.16.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 16:05:06 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH v3 2/6] conf: Add --dhcp-boot command-line option Message-ID: <20260612010505.617a5d55@elisabeth> In-Reply-To: <20260601073758.1571317-3-anskuma@redhat.com> References: <20260601073758.1571317-1-anskuma@redhat.com> <20260601073758.1571317-3-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 12 Jun 2026 01:05:06 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3cBemeKe9cO7fffuNOgGsQI5sC6bsAtrGR-ZoAH-7H8_1781219109 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3HN4VNWBD3FSAAWP2JQ52HPCSHI3PL5X X-Message-ID-Hash: 3HN4VNWBD3FSAAWP2JQ52HPCSHI3PL5X X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 1 Jun 2026 13:07:52 +0530 Anshu Kumari wrote: > Introduce the --dhcp-boot flag that sets the boot file URL for > network boot specially for ipxe. This patch adds the option ...meaning in a special way for iPXE (but what is special about it? I'm not sure if I'm missing something) or especially for iPXE usage (but then it's "especially")? > storage and CLI parsing. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D192 > Signed-off-by: Anshu Kumari > --- > v3: > - case 32 now calls dhcp_add_option(c, 67, optarg). > - Handles duplicate codes: --dhcp-boot and --dhcp-opt 67 coexist > correctly, last value wins. >=20 > v2: > - Removed separate dhcp_boot[PATH_MAX] field =E2=80=94 --dhcp-boot foo = now stores into custom_opts[] as code 67 (same as --dhcp-opt 67,foo) >=20 > --- > conf.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/conf.c b/conf.c > index ce78af1..f7281e2 100644 > --- a/conf.c > +++ b/conf.c > @@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int stat= us) > =09=09" a single, empty option disables the DNS search list\n" > =09=09" -H, --hostname NAME =09Hostname to configure client with\n" > =09=09" --fqdn NAME=09=09FQDN to configure client with\n" > +=09=09" --dhcp-boot URL=09Boot file URL for network boot\n" > =09=09" --dhcp-opt CODE,VAL=09Set DHCP option by code\n"); > =09if (strstr(name, "pasta")) > =09=09FPRINTF(f, " default: don't use any search list\n"); > @@ -1239,6 +1240,7 @@ void conf(struct ctx *c, int argc, char **argv) > =09=09{"migrate-no-linger", no_argument,=09NULL,=09=0930 }, > =09=09{"stats", required_argument,=09=09NULL,=09=0931 }, > =09=09{"conf-path",=09required_argument,=09NULL,=09=09'c' }, > +=09=09{"dhcp-boot", required_argument,=09NULL,=09=0932 }, > =09=09{"dhcp-opt", required_argument,=09=09NULL,=09=0933 }, > =09=09{ 0 }, > =09}; > @@ -1475,6 +1477,9 @@ void conf(struct ctx *c, int argc, char **argv) > =09=09=09=09die("Can't display statistics if not running in foreground")= ; > =09=09=09c->stats =3D strtol(optarg, NULL, 0); > =09=09=09break; > +=09=09case 32: > +=09=09=09dhcp_add_option(c, 67, optarg); > +=09=09=09break; > =09=09case 33: > =09=09=09comma =3D strchr(optarg, ','); > =09=09=09if (!comma) --=20 Stefano