From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RGWxAXRq; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D544A5A0265 for ; Fri, 12 Jun 2026 01:05:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781219120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FttvjmMiS/gCYWgzDUUtYp8GsON6dK5yICAoRIyEzDo=; b=RGWxAXRq1qcoi2SWqnxz5ITP5o0tafScJW6f19qtVxlFns7ahbCRREN3F6IgsmTrEbnMU2 9cAvIYuQfUOE52v9PCOSeMUUOUTV0IK6gl9IJ0i6VNlc2WnrZb1XnwVEHS3WmfIen72Dd5 RfaqkCLy6otoUhYBqOTlk6zmm1XWCJM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-oEQ-0xiTM12l7Q9_jhnjjQ-1; Thu, 11 Jun 2026 19:05:19 -0400 X-MC-Unique: oEQ-0xiTM12l7Q9_jhnjjQ-1 X-Mimecast-MFC-AGG-ID: oEQ-0xiTM12l7Q9_jhnjjQ_1781219118 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-46016bedbaaso206353f8f.1 for ; Thu, 11 Jun 2026 16:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781219118; x=1781823918; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FttvjmMiS/gCYWgzDUUtYp8GsON6dK5yICAoRIyEzDo=; b=PgSWHaIqC2vkHWT/CxC1joScH/6EOQXfAwzZ7QEXXC3AJfQCKWC6hme6rXnQGtxdrP 9IVCUD0flRqWR7SAz1xop8z56LT1VEXwUL660ibrzXuf11A+D1kx+vCT4/laBEquJgig Qlp9ozDhlIgoTHEsv/xEwK/n7bCEmkb7R7xZc1TVgs0h7Pv4xK2opfXuNq04+VJwq26M gJuFnd2Al68SOZNDPEsuP5G/c54TPI4zY6/VJitoRkUGZO7mUykz/Y8WjbZ8Rfn9vmMr 5Cz9Zl8RKHW4h4ayUoz/nMTLI8OQxpT5VqRAutnB5zgfS/vJF3Q9b+yoGLW6EeBoHcyG 042g== X-Gm-Message-State: AOJu0Yw5FrB1tbGA1eF3NzimsTg3p6IptTyFvQLC4qX6/D10TYCt2kWZ qScNVmraq+nwdH6sP9yf3ZrunH0GJeQ93iOSXsYbjFMW4I2KIE9mx/7rPeBiNdssser45wF/C8K Ijfq3pTbvgWuBAQwd4PCMQhQhNBHF1E/q87nBWTVALqeIjVJUP8HMCj2WeLDw5A== X-Gm-Gg: Acq92OEEWV2hQi/KpbKGopk5/qMtkXHPLLNr6zk2xgKLxFc2iK7oEMQH3T8qv9V5r7Q +CrbnXpL6xBrn/ar1wrv7PnYSvdDVmD/iwD2gncKsYVj86Ar9TL6YsBzvVnnkF8EMEyPkQuhesC dMrlg+lFXDY1mJ7cADWPyycFvkN7A6rQcNJ664cDlYFkE83kmQKB5/OdlYOOObikNlsiEeVaMbH xjBD1SFUqJGDQbXasdcPreIQsGLACVUS6jkGRhV0zR+l7fFX8/LELWWhCR9bM5EvCo4gU+aPpwI t2fiqOfW5DVGwGm8lJk6I1DP2yW9iOgy7qhHMPe9KYbiGEH3ewFxSFDEkiPwhAmwlVirLRIhdRo pV+nTglqyS2Sq75gEjAF+g3gtIBYYR44z X-Received: by 2002:a05:6000:2883:b0:460:1643:caf7 with SMTP id ffacd0b85a97d-4606db97ed7mr492207f8f.27.1781219118406; Thu, 11 Jun 2026 16:05:18 -0700 (PDT) X-Received: by 2002:a05:6000:2883:b0:460:1643:caf7 with SMTP id ffacd0b85a97d-4606db97ed7mr492168f8f.27.1781219117910; Thu, 11 Jun 2026 16:05:17 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2c4240sm45021f8f.27.2026.06.11.16.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 16:05:17 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] Assorted minor socket creation cleanups Message-ID: <20260612010516.4d9cfd0e@elisabeth> In-Reply-To: <20260609063005.113744-1-david@gibson.dropbear.id.au> References: <20260609063005.113744-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 12 Jun 2026 01:05:17 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wf0VMir_2s14JYfOE17B75VX2fcK5fC-ziKNgvrZjx0_1781219118 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QT26Z536SYWWTYPYTNOFU7QG7ZKDZDGX X-Message-ID-Hash: QT26Z536SYWWTYPYTNOFU7QG7ZKDZDGX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Jun 2026 16:30:01 +1000 David Gibson wrote: > As discussed on our recent call, I was looking again at bug 167. I > discovered it's still fairly fiddly to address this, but while > investigating spotted a number of cleanups to make in the vicinity. I > think they make sense even without fixing bug 167 (yet), so here they > are. > > David Gibson (4): > flow: Correct misleading signature of flowside_sock_l4() > Makefile: Remove unused DUAL_STACK_SOCKETS define > fwd, pif: Remove duplicated logic between tcp_listen() and > udp_listen() > pif, util: Move listen(2) call from sock_l4_() to pif_listen() I was about to apply this (there are no apparent conflicts with "[PATCH 0/4] RFC: Improvements to flow specific logging", which I still need to review), but cppcheck now says: --- flow.c:216:31: style: inconclusive: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. [funcArgNamesDifferent] const struct flowside *side) ^ flow.h:176:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. const struct flowside *tgt); ^ flow.c:216:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. const struct flowside *side) ^ pif.c:111:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] ref.fd = sock_l4_dualstack_any(c, ref.type, port, ifname); ^ pif.c:116:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] ref.fd = sock_l4(c, ref.type, &sa, ifname); ^ --- ...is it just my version (2.19.0)? -- Stefano