From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/5] Fix cppcheck-2.21.0 warnings
Date: Mon, 15 Jun 2026 18:18:28 +1000 [thread overview]
Message-ID: <20260615081833.1061725-1-david@gibson.dropbear.id.au> (raw)
Another cppcheck version, another batch of false positives :(. These
appears to be cppcheck regressions, I've filed two bugs on their
tracker.
Still, here are workarounds in the passt code. At least I managed to
make a few genuine if minor improvements to the code along the way.
David Gibson (5):
cppcheck: Remove unused CPPCHECK_6936
cppcheck: Add workaround for cppcheck bug 14847
tcp: Merge common sequence logic from tcp_{buf,vu}_data_from_sock()
tcp: Avoid SEQ_*() comparisons against 0
tcp: MAX_WINDOW should be unsigned
Makefile | 3 +--
tcp.c | 50 +++++++++++++++++++++++++++++++++++---------------
tcp_buf.c | 28 ++++------------------------
tcp_buf.h | 3 ++-
tcp_internal.h | 4 ++--
tcp_vu.c | 27 ++++-----------------------
tcp_vu.h | 3 ++-
util.c | 6 ++++--
8 files changed, 54 insertions(+), 70 deletions(-)
--
2.54.0
next reply other threads:[~2026-06-15 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 8:18 David Gibson [this message]
2026-06-15 8:18 ` [PATCH 1/5] cppcheck: Remove unused CPPCHECK_6936 David Gibson
2026-06-15 8:18 ` [PATCH 2/5] cppcheck: Add workaround for cppcheck bug 14847 David Gibson
2026-06-15 8:18 ` [PATCH 3/5] tcp: Merge common sequence logic from tcp_{buf,vu}_data_from_sock() David Gibson
2026-06-15 8:50 ` Laurent Vivier
2026-06-15 8:18 ` [PATCH 4/5] tcp: Avoid SEQ_*() comparisons against 0 David Gibson
2026-06-15 8:18 ` [PATCH 5/5] tcp: MAX_WINDOW should be unsigned David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615081833.1061725-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).