From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=kZh8wmZZ; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 728695A026D for ; Mon, 15 Jun 2026 10:18:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781511516; bh=l2ix/VyrNTc2ZXC3hTF/vGZn3wmKklfMpQGt4fT1rKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kZh8wmZZIIWz2B5gwm11ICOckzw2SWKtuEa5WC9SYpZRqlsXF3uhM3B4KKHlV5ugM HUlTu2o2f6OgKhcoyCEgQXN7yG/DDzbO4Vvzm+R8z1opB8SnwUQEWHYI6zeIRdinRb m2d5VL3Os7FXXUaW8O21yNnPwNslk3TPzdHN0eLIoiky2dkXxs5w8Sf9xvKNw3KnTG f+3To6PXduevIcoNIyJJHZpG57V5cFYWZ3PUHbMz7UY59BaktOcflyt2+FITSOnoC2 7reH9cG6Lbio7QCxUGU38rUYYideU+xeaqTjaRMjQEWbpbfyZ0Jkw/1Qx8vYpQZQAW aJgZPxen/IBww== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gf30r1TV6z4wTW; Mon, 15 Jun 2026 18:18:36 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 2/5] cppcheck: Add workaround for cppcheck bug 14847 Date: Mon, 15 Jun 2026 18:18:30 +1000 Message-ID: <20260615081833.1061725-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260615081833.1061725-1-david@gibson.dropbear.id.au> References: <20260615081833.1061725-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: L6ZIYOUIWPIWRVZ6TTYN7QWT6SYHFK36 X-Message-ID-Hash: L6ZIYOUIWPIWRVZ6TTYN7QWT6SYHFK36 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It seems the function pointer argument confuses cppcheck 2.21.0 (at least), causing it to think do_clone()'s definition has different argument names than it's declaration, even though that's not the case. I made a minimal reproducer and filed a cppcheck bug for this (see link). In the meanwhile work around it with an explicit suppression. Link: https://trac.cppcheck.net/ticket/14847 Signed-off-by: David Gibson --- util.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/util.c b/util.c index 43977d42..ed874f1c 100644 --- a/util.c +++ b/util.c @@ -713,8 +713,10 @@ int __clone2(int (*fn)(void *), void *stack_base, size_t stack_size, int flags, * * Return: thread ID of child, -1 on failure */ -int do_clone(int (*fn)(void *), char *stack_area, size_t stack_size, int flags, - void *arg) +int do_clone(int (*fn)(void *), +/* false positive, see https://trac.cppcheck.net/ticket/14847 */ +/* cppcheck-suppress [funcArgNamesDifferentUnnamed,unmatchedSuppression] */ + char *stack_area, size_t stack_size, int flags, void *arg) { #ifdef __ia64__ return __clone2(fn, stack_area + stack_size / 2, stack_size / 2, -- 2.54.0