From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=OvcPR/98; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 149705A0265 for ; Tue, 16 Jun 2026 03:09:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781572178; bh=XGynaIz/KN3rcFI0hke/xUEmQEqoVXKGDWyD1+YU510=; h=From:To:Cc:Subject:Date:From; b=OvcPR/98cnb1Rhrn/4VijXHCVhfk29eemosGDqzrm4QaNPvUgnbjQVqMxwJeo7bq7 M4+iQyCSfENDVY/+s/RQAzBCpXdf8qWdk6pXtY8ZZaGRL4wupSL6BupKoM58XLu1Pw rGGJ6lMZNTAaKSo5qsHdVv3MgGHPdRjp5wnvDLs2NLpMfv7krAGaFo0TuS58f5jjf/ zx1j3ljoudJ7pDJbWuknQu1zlqdV2FWf3RYAp0rLg/nieKA/Av9vHTfVmjqyYs4WT9 aT1fRw/3dsSAdmBClVwBCeZdgUbiSjKEGXRX1wu3mpD4mdwR+A//CqmoFaPapQEl/s jSnZagbXTx1BA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gfTRQ4NDBz4xSw; Tue, 16 Jun 2026 11:09:38 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 0/4] Assorted minor socket creation cleanups Date: Tue, 16 Jun 2026 11:09:32 +1000 Message-ID: <20260616010936.1672156-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: FSPC7JZSQVOUMTL6KIUUDJDJ3A7MFQ34 X-Message-ID-Hash: FSPC7JZSQVOUMTL6KIUUDJDJ3A7MFQ34 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: As discussed on our recent call, I was looking again at bug 167. I discovered it's still fairly fiddly to address this, but while investigating spotted a number of cleanups to make in the vicinity. I think they make sense even without fixing bug 167 (yet), so here they are. Tested on top of my recent cppcheck series, but I don't think they conflict. v2: * Fixed some cppcheck warnings I missed initially David Gibson (4): flow: Correct misleading signature of flowside_sock_l4() Makefile: Remove unused DUAL_STACK_SOCKETS define fwd, pif: Remove duplicated logic between tcp_listen() and udp_listen() pif, util: Move listen(2) call from sock_l4_() to pif_listen() Makefile | 5 ----- flow.c | 11 +++++------ flow.h | 2 +- fwd.c | 8 +------- pif.c | 41 +++++++++++++++++++++++++++++++++++------ pif.h | 2 +- tcp.c | 38 -------------------------------------- tcp.h | 2 -- udp.c | 38 -------------------------------------- udp.h | 2 -- util.c | 7 ------- 11 files changed, 43 insertions(+), 113 deletions(-) -- 2.54.0