From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=YaNz3nQ0; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id CA3205A061B for ; Tue, 16 Jun 2026 03:09:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781572178; bh=HxUPo2YF7fMP3hI48cJq13c4lHD0bkRkJsbRE3WAeko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YaNz3nQ0LI2JF5Jf9pGaXS+9pTb4NzNmit11/IdJgMqSlRTTV2y9k2H7o85G9s2c5 u0s4yN2ioYUQ85wYKmfTnt6PeLpxJGhInddw6HIT0PmpHUwo8aNQZTZkC++pKXpAWz n3Ixk9z9J6JphmBh7/3WAm9e3yrwDBzC5wtc52XHcWsBzu16fm43Hoa02+MRmmS4KE LVx83XjIyFfNkVY8u/jJp1guX4eapsPRMXDAUMpnOMYpFXhqlPKO9DUZ+jgR9/9NZs LzpDvck+uFQ3Nia1VQo7GQpyRxavBrlI1BUcJkjbnsHYfAky6PWQGkGMVw0iwPiVLH YNETLFL5GC0aQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gfTRQ4msCz4xXK; Tue, 16 Jun 2026 11:09:38 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 2/4] Makefile: Remove unused DUAL_STACK_SOCKETS define Date: Tue, 16 Jun 2026 11:09:34 +1000 Message-ID: <20260616010936.1672156-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616010936.1672156-1-david@gibson.dropbear.id.au> References: <20260616010936.1672156-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZH7IF4RQREQXU3VK7D4VJXN7XHD3MVTM X-Message-ID-Hash: ZH7IF4RQREQXU3VK7D4VJXN7XHD3MVTM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We have a make variable DUAL_STACK_SOCKETS which used to determine whether we'd use dual stack sockets. When we introduced it we were concerned that we might have future ports to systems which did not support them. We've since discovered that the dual stack interface is described in RFC 3493, and supported by both Windows and BSD. Platforms sometimes differ in the default setting for the IPV6_V6ONLY socket option, but the feature itself is widely supported. So, since b8d4fac6a2e7 ("util, pif: Replace sock_l4() with pif_sock_l4()") we've simply assumed its presence. The makefile still defines the now unused variable, though. Remove it. Signed-off-by: David Gibson --- Makefile | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Makefile b/Makefile index c19383f3..e8170e90 100644 --- a/Makefile +++ b/Makefile @@ -11,10 +11,6 @@ VERSION ?= $(shell git describe --tags HEAD 2>/dev/null || echo "unknown\ version") -# Does the target platform allow IPv4 connections to be handled via -# the IPv6 socket API? (Linux does) -DUAL_STACK_SOCKETS := 1 - TARGET ?= $(shell $(CC) -dumpmachine) $(if $(TARGET),,$(error Failed to get target architecture)) # Get 'uname -m'-like architecture description for target @@ -33,7 +29,6 @@ endif BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG) BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE) BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\" -BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS) BASE_CFLAGS := -std=c11 -pie -fPIE -O2 BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security -- 2.54.0