From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R1PLuQMf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 280A55A0262 for ; Wed, 17 Jun 2026 01:09:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781651339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CqkjPDkRPe1P1gx2ORVQIN3HZY4iKr5CIHmm5SERfn8=; b=R1PLuQMfOYQfcmgnRIPT89VfLfl20IdUOZHYsJ97RsZqy8Heze68UywApieKm6QeFE5QUG iqr4VDIuf2LR+TkhtCnvCtObfH+MNexi6mNwrmYQOXVp828Ou/298ZwkO3T4bjKzy2eIXG aWhX/I+nHbn1nZmB2gZqhrsGRH+kwik= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-TpGA6Zm0N-S5G07-y34GVQ-1; Tue, 16 Jun 2026 19:08:57 -0400 X-MC-Unique: TpGA6Zm0N-S5G07-y34GVQ-1 X-Mimecast-MFC-AGG-ID: TpGA6Zm0N-S5G07-y34GVQ_1781651336 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490ae3bcf4cso25368195e9.3 for ; Tue, 16 Jun 2026 16:08:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781651336; x=1782256136; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CqkjPDkRPe1P1gx2ORVQIN3HZY4iKr5CIHmm5SERfn8=; b=CYAM6NGotnOJDDBCOj6nb7tAiJgt7AcNKnPUpXUHTYjlVY21mvlcBKmfgq6bpZylpS l+VE6HDD10YrX0fgiGappc1iZHQeURr7FfIyql1qTYwnKEOFdheSUDF0AXFTnoNGeSQB IoMJhkUldCyZ2SGA1NCaOZl2S73DlqyWSQ5azyS7hq+zI2FpiZjf9WaxJhNwzzLxE1/w Av0N5CsuOjNnWYpYJLRqUYMCohvVkPvVi6Z++zRcjm8y3bB99BYk+7Iy0qe1H2QjU/zO aley9mgUKzGqwvgEcj3wyYRHhBcS3D4HeJ/jWTrHbTyww4+2hyuFgyQ3jjjuiJikxSOr rabQ== X-Gm-Message-State: AOJu0YzeGhQ4jt5OiANJE3W0AZp5gaZMS58QTI9sTWeGV66Jg2Oti26+ ZXEvG8dS0HMsue0NJ53wMIaxs7V2BGYvLRDxp6nixHEdh3yTGntMCG08kVORte7u0NuoEbPQTYT e8RWQIWeQ5F54wF5hfYPSMwQniLNTBa0MF1GA2h22EGueeQEhsmSf0uIv5wXAZg== X-Gm-Gg: Acq92OHPZDFXN+cF9v7xotTJMKZpEDw6jJFARFj35BV+BGTKc0fouD7+PH8Y5lBjFTY zkBEFAx6VoRUcGw7uEkpCBv1GzIB5MDwVN68oIiSF78QO8vV2TaJObZYhCWUM1JOKRTBNmIEntg u7tVLig7f2mYEaVisWE2Z9s9t4D3Fd4jvYPnte8PQG3R7Lb4g1ETBO8FMfPI5elKTHprl344FIr VafykaTYiyfsmA4Qfa66d6mA2oBNiDiLC37anauetXYonuYFEQvPQYiPohRqXNLh8/y2W9pa9XG DtLXmvkZn4TdG76NJsVR6JOSbyvlOtY8UY3pgTBCoqQjoE4yN3AfdlGwXSSk9hvVF8FiT33q0JZ YyKiBUiKL2LbhkbgFLJ9Iiu7fipEi5sPV X-Received: by 2002:a05:600c:19c6:b0:492:323d:20ae with SMTP id 5b1f17b1804b1-49233352e0amr25654075e9.0.1781651336275; Tue, 16 Jun 2026 16:08:56 -0700 (PDT) X-Received: by 2002:a05:600c:19c6:b0:492:323d:20ae with SMTP id 5b1f17b1804b1-49233352e0amr25653825e9.0.1781651335833; Tue, 16 Jun 2026 16:08:55 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa5120esm118826525e9.8.2026.06.16.16.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:08:55 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] RFC: Improvements to flow specific logging Message-ID: <20260617010854.01e36b3a@elisabeth> In-Reply-To: <20260609023226.86058-1-david@gibson.dropbear.id.au> References: <20260609023226.86058-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 17 Jun 2026 01:08:55 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TygqEUdKBoi49WQgUm-T9aDicSwdI00K3O_iV28qdIM_1781651336 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HG6THCX3Z2NK4AIOXSGKFMZKYZWPXNAN X-Message-ID-Hash: HG6THCX3Z2NK4AIOXSGKFMZKYZWPXNAN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Jun 2026 12:32:22 +1000 David Gibson wrote: > While working on podman bug 23739, I found some deficiences in how and > when we report various socket errors related to specific flows. Here > are some preliminary patches to improve that. > > I think patches 1..3 are pretty straightforward and safe. 4/4 I think > is a good idea in principle - promoting the priority of a number of > messages now that we have ratelimiting. However, plumbing 'now' all > the places we need it resuls in a *lot* of churn, so we might want to > postpone or split it up. Unless I'm missing something, I don't see 4/4 as particularly problematic. It's a set of rather mechanical changes where the compiler would tell us if we got something wrong, I guess? > Still, current drafted posted for consideration. > > David Gibson (4): > flow: Regularise flow specific logging helpers > flow: Include flow details with higher priority log messages > flow: Safer errno handling in flowside_connect() callers > flow, treewide: Promote priority of selected flow-linked messages > > flow.c | 107 +++++++------- > flow.h | 72 +++++----- > icmp.c | 27 ++-- > icmp.h | 3 +- > migrate.c | 27 ++-- > migrate.h | 8 +- > passt.c | 8 +- > tcp.c | 381 ++++++++++++++++++++++++++++--------------------- > tcp.h | 5 +- > tcp_buf.c | 78 +++++----- > tcp_buf.h | 8 +- > tcp_conn.h | 8 +- > tcp_internal.h | 27 ++-- > tcp_splice.c | 59 +++++--- > tcp_splice.h | 3 +- > tcp_vu.c | 42 +++--- > tcp_vu.h | 6 +- > udp.c | 48 ++++--- > udp_flow.c | 22 +-- > 19 files changed, 535 insertions(+), 404 deletions(-) -- Stefano