From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KY/KH9eX; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9E8015A0262 for ; Wed, 17 Jun 2026 01:11:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781651475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjKZeZj+XdUqhmMHHEhKRwCqN9AMX2rQMjkMOnAM4n4=; b=KY/KH9eX6AICgTXxW2N3yarRQoC3GPSen23P0pHqBGyJ+3yKQMZBHcCe209NeGz6Rj6MSc pYKrSLeE6Xz1ImGH0EMTSrLRPmSnXoVjXrYyNQaYXcqA2sTzgBm7WYrOg9VYamks9AiREa AxABmNbDKMZTijkOk5LQ+XxYp3OZt3U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-bV9y5pEMOz6-Qq85MaQppQ-1; Tue, 16 Jun 2026 19:11:14 -0400 X-MC-Unique: bV9y5pEMOz6-Qq85MaQppQ-1 X-Mimecast-MFC-AGG-ID: bV9y5pEMOz6-Qq85MaQppQ_1781651473 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-46250b59ed5so151659f8f.2 for ; Tue, 16 Jun 2026 16:11:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781651473; x=1782256273; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wjKZeZj+XdUqhmMHHEhKRwCqN9AMX2rQMjkMOnAM4n4=; b=KpkFeHku0doIBGxtg2EkCsjhPZm6Ph+oS66K4G4vrWas28fdM1VIUwOG+0guG7lNM0 x7B4L/GlB8eoHzhNK0moKQEj/+soBl/BrR9XY3AhROFa539qozMQMLvTjtaxTs9d+YVQ 8MCNGQ3bwGilZKkMo/d2gDksXfFnfUUii/le4Fe7drxQ1At0IjieEqt0fRDTTCrk0wgB 5Pv8hIP2qP/pZGk90t19S5/5eMFkyDOjmU5EaJ87IjK3RU5D7jo9+t3Uygrl8VW7lt3e 402wZmC+dvVYYr4bOMrwJZnNoYXQi+0rbfsjINpqi8tg10Frnyg6npNrOf5Q8f27fvXn d7gQ== X-Gm-Message-State: AOJu0Yzu8pLKikdadfN5erQ9j3/SRO/pqBTk2/CJ+3IXKtxdORxBm30n 7rMc8yjZqbZis0j7X1qy6JCpEEWhQfZWmku0hBt3zVyQIVF6mNeo+W6uEHrLMU97L0nAc6wAKOY ggsT1hLvJdJyrvrDDtiwTmTzCc5iXO7AG+N8w/dvXpRmT6bUfixuky/5eA120BA== X-Gm-Gg: AfdE7cminYP7NstcZ9YifXCwkXhg4tI2mNUHLzOjKEa+TgQdXJXWr6VZ/2Ejg/JZ3Bf Ey8EdEp9SUaWwaxDbg4FkfJkIuRZvu49MWwLHMrEDRBm+tb/URwlMKfGEEw/KlCLR1Ae9ySvp/o F+JZXd4hUmTkQ3eectyTnWQYEyVKj/VfGKrgB4lBYu1ZrYuqA/y1gyTffMUlEHtx1EUXjyoHeMf FEDe66o96m/V+84bnUhDmH/r61MHUNZxojoyoqAz8r09puj8y6Gz4GW3U5CrohgaqE2L4sfcB0t 3k0JRKGEQxaHLM6Qj/yobaKCDzDKp8Q5R/0WH+TAeEE3lya2XcvdWCN3gGSfs/1WlHdzpF23C0I UG4B2VwGWdfotWNNioHFyI2mYKLdLu57k X-Received: by 2002:adf:e708:0:b0:460:e4d:bd46 with SMTP id ffacd0b85a97d-46237c66a9cmr2006471f8f.21.1781651473040; Tue, 16 Jun 2026 16:11:13 -0700 (PDT) X-Received: by 2002:adf:e708:0:b0:460:e4d:bd46 with SMTP id ffacd0b85a97d-46237c66a9cmr2006437f8f.21.1781651472533; Tue, 16 Jun 2026 16:11:12 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2d933esm47955024f8f.33.2026.06.16.16.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:11:12 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/5] Fix cppcheck-2.21.0 warnings Message-ID: <20260617011110.49d33084@elisabeth> In-Reply-To: <20260615081833.1061725-1-david@gibson.dropbear.id.au> References: <20260615081833.1061725-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 17 Jun 2026 01:11:11 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: naMEyHjX5z2jQiigMuTL2KdN2P5o-2cwyg7Vpz9o2hE_1781651473 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7HE2TBTU7N7LMIP6V74T6JMWYSZ7TK2W X-Message-ID-Hash: 7HE2TBTU7N7LMIP6V74T6JMWYSZ7TK2W X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 15 Jun 2026 18:18:28 +1000 David Gibson wrote: > Another cppcheck version, another batch of false positives :(. These > appears to be cppcheck regressions, I've filed two bugs on their > tracker. > > Still, here are workarounds in the passt code. At least I managed to > make a few genuine if minor improvements to the code along the way. > > David Gibson (5): > cppcheck: Remove unused CPPCHECK_6936 > cppcheck: Add workaround for cppcheck bug 14847 > tcp: Merge common sequence logic from tcp_{buf,vu}_data_from_sock() > tcp: Avoid SEQ_*() comparisons against 0 > tcp: MAX_WINDOW should be unsigned Applied. -- Stefano