From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZbgSAGnG; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 207595A026D for ; Wed, 17 Jun 2026 01:11:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781651480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J9CzM6qJA2vPWsjSbkKZrhPXo0TdCwJuluF/Z/O9gbk=; b=ZbgSAGnG9UFKc7l5j7iwFRCT2R41t71CuTtg2kcPMaRfd36qsSY2YquwEJM5DdNLHvJCYf 1sX0hQYxmcZX2tsDlIMbMl5oW2+2pYixIhIQx04rWUR5v4xIolT5eO1qFazabNA7j8WXs+ c50tSOTDaHCPq/5AX+6LdnUP1aXVwtM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-IDugPd_CNVK3DVF9X3GYiA-1; Tue, 16 Jun 2026 19:11:18 -0400 X-MC-Unique: IDugPd_CNVK3DVF9X3GYiA-1 X-Mimecast-MFC-AGG-ID: IDugPd_CNVK3DVF9X3GYiA_1781651478 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4600c8cb13aso3727695f8f.1 for ; Tue, 16 Jun 2026 16:11:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781651477; x=1782256277; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J9CzM6qJA2vPWsjSbkKZrhPXo0TdCwJuluF/Z/O9gbk=; b=hFVpjJGcC/TD861QyXIWwWNH3CfZ++XEIqAGjH38x0+u7Y1JN6et66G5rmxUfO7LW7 ox1WBKEQhmVx+2BVpo6r8LGa9oY98hcQHI9wuWZ9R+tB7qRqKi/rrj/33ZonLH15g56x tTfdb0P/wnrS+HySn/J2Ms2FsHbU2GoxPca2JP2FD9CP/PyPTLroAWTk82DAeRwG7PBU gobgDfuxLGDa/17y5Cb+5ujxR1JXcDxIbNzi5GTkxfuJFyuC1KXFDPRDozSt4oGMYJgF saRWVJg2ZjdczXyIHu7+mAuyxnw09A98wgGT3CEljV/0r0vyGaWGlAKEXNwiPmo6W8hP RVXA== X-Gm-Message-State: AOJu0YzijwukGGJXjX6/NP6+Wpusx+Sqo+VeTKNQeuavmhArSOsqckn/ U1omx1k91dk4kvd2Z5V/YB7yxhNYq2u5rW5Ni/XMPZWMfDT0s8sFAc/P2UBgcArWP1hTR20+WHb bJPD25XDUnvoYC2/ZjJdI7mAbGcr+Yx521KzZQOYvuu1TjD5BEYn1LQ== X-Gm-Gg: AfdE7cm6m/IhtVhqbiYloh+9erVi+vjBaoO70xnuASif2TbGm0vfanKfcqeWnnN8x1n PEPjTsGzoEGRcEYJqy9IRatzmeK5/kCqI5c5QD8/yi2EPHKTRSFyGDg65kXZbAfGgfu1V9SS4BZ dBe/x8zp4r1XdZjFa/QeANy8yngV0IPHKyV/PT4ZJ7HqS6W5c/jSKfkcpKvffRJUG4owlE7oVTf mW+BWXq2cFEIzt0nL529hrU004D5C4d0V8y2qQ8KyNSDciG8qWhKyoEcBWtXB4UIDelBKCWdINx D1Brfj75Gj8mmvVOlosFlosuU7OmF2DaftH3cdsWXtlpiPCZ1+zYs1WnCMVfzikrYWkI2XWuqUE c25k0RcyofvgtC+fEUwUyiV+o0WZNWY1TiLC6Tel8OoLzxPBHWA== X-Received: by 2002:a5d:6f1e:0:b0:460:18e9:c0da with SMTP id ffacd0b85a97d-4623f8b1a7emr2287964f8f.10.1781651477624; Tue, 16 Jun 2026 16:11:17 -0700 (PDT) X-Received: by 2002:a5d:6f1e:0:b0:460:18e9:c0da with SMTP id ffacd0b85a97d-4623f8b1a7emr2287933f8f.10.1781651477164; Tue, 16 Jun 2026 16:11:17 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f3dcsm45587763f8f.13.2026.06.16.16.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:11:16 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/4] Assorted minor socket creation cleanups Message-ID: <20260617011115.1a58b444@elisabeth> In-Reply-To: <20260616010936.1672156-1-david@gibson.dropbear.id.au> References: <20260616010936.1672156-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 17 Jun 2026 01:11:16 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YfNsM9XxtM8j1cGLnrYPODM0sVyxu_JuvCZtbXVb3To_1781651478 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: YH26I44KJI7WGRCBPV5XMYE4X46KLEOI X-Message-ID-Hash: YH26I44KJI7WGRCBPV5XMYE4X46KLEOI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 16 Jun 2026 11:09:32 +1000 David Gibson wrote: > As discussed on our recent call, I was looking again at bug 167. I > discovered it's still fairly fiddly to address this, but while > investigating spotted a number of cleanups to make in the vicinity. I > think they make sense even without fixing bug 167 (yet), so here they > are. > > Tested on top of my recent cppcheck series, but I don't think they > conflict. > > v2: > * Fixed some cppcheck warnings I missed initially > > David Gibson (4): > flow: Correct misleading signature of flowside_sock_l4() > Makefile: Remove unused DUAL_STACK_SOCKETS define > fwd, pif: Remove duplicated logic between tcp_listen() and > udp_listen() > pif, util: Move listen(2) call from sock_l4_() to pif_listen() Applied. -- Stefano