From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=RZ/OkfRg; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2B5635A026E for ; Wed, 17 Jun 2026 05:11:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781665884; bh=y9rvHYVuKNoptj5YbnXZLnUN4H0ulp6k/9YCqjknSSA=; h=From:To:Cc:Subject:Date:From; b=RZ/OkfRgNlj5GJvvAtvIzKOr2opRCZJoeoW5u1JnpujGa/GtZdQmLViqkfa6lxZT6 e6fIbf/atQHVN4O3pRwYVa68FYT2cIgGArgTLouxh2deCsL2wpssEhEEaV2r1GcBZW XuSq3k+t+KWg5Jwe1UwoWjGZ7NRdMWJifHgxXwXR/cQMX5AdiN0LtmvKiH4qODSLl7 EbalLo6wwxZC1q0WnEGcO6jBCuWgzjecnRI8pwDBRPVC1QxfBXBz1adwDiqJz8nyS/ Z6l68s1pMsPRP4L0ePfQLI1pUlYYgCvVA04Dd9tG/Mp+HCZGkF8LExSJ9c6YRxsor/ 18bn8Joi4pLgw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gg85S6qY1z58nv; Wed, 17 Jun 2026 13:11:24 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 0/6] Improvements to flow specific logging Date: Wed, 17 Jun 2026 13:11:16 +1000 Message-ID: <20260617031122.2086827-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: DI23INATGHHICYWUBXU7R5PL6L7WQ5HV X-Message-ID-Hash: DI23INATGHHICYWUBXU7R5PL6L7WQ5HV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While working on podman bug 23739, I found some deficiences in how and when we report various socket errors related to specific flows. Here are some preliminary patches to improve that. I think patches 1..3 are pretty straightforward and safe. 4/4 I think is a good idea in principle - promoting the priority of a number of messages now that we have ratelimiting. However, plumbing 'now' all the places we need it resuls in a *lot* of churn, so we might want to postpone or split it up. Still, current drafted posted for consideration. v2: * Added patch 2/6 At Stefano's suggestion * Simplified the errno Handling fix at Stefano's suggestion * Added patch 6/6 which I noticed while revising 5/6. * Made a handful of minor corrections based on feedback. David Gibson (6): flow: Regularise flow specific logging helpers flow: Indent flow details messages flow: Include flow details with higher priority log messages flow, udp: Fix errno handling in udp_flow_sock() flow, treewide: Promote priority of selected flow-linked messages udp: Improve messages for errors getting errors flow.c | 103 ++++++------- flow.h | 72 ++++----- icmp.c | 27 ++-- icmp.h | 3 +- migrate.c | 27 ++-- migrate.h | 8 +- passt.c | 8 +- tcp.c | 387 ++++++++++++++++++++++++++++--------------------- tcp.h | 5 +- tcp_buf.c | 67 +++++---- tcp_buf.h | 7 +- tcp_conn.h | 8 +- tcp_internal.h | 27 ++-- tcp_splice.c | 59 +++++--- tcp_splice.h | 3 +- tcp_vu.c | 31 ++-- tcp_vu.h | 5 +- udp.c | 61 +++++--- udp_flow.c | 18 ++- 19 files changed, 528 insertions(+), 398 deletions(-) -- 2.54.0