From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=Zg7zIQ/o; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 896785A0262 for ; Wed, 17 Jun 2026 05:11:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781665885; bh=H8x25i/nOxn8s5RO8yHi1FqzkOWqWrUwV3e2d2nGMe0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zg7zIQ/oNCWrgq8ciZUIm5FWN3MveNt4IHDIODN160VZu8IvoXuv2dp2MzshX7wX1 2zNWMLkWsFISRSGzxgyRlHI91MNORkF4moCKYA5eeXjXE0pcGejxh2KG+9B87NuF3H oqk6Y0Rdujm0OvxxI+LJ+K/Ua3WyXCXPP3QsX1bzrACWb1FAkyk2mNL575XxIvXSpS fig8+tSMBKQ7cPHACV6kYpm387d/XRX/r1JufO1zLtmfuvHuIELOiK/4NEP120FxW3 PCJSLA1stqvhsakF6tJDtaYOSsBkQ644nigBZk8Y92kXScWLeLall1GhDShxxNxoaZ JdHa35Ml74myQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gg85T02bGz58nt; Wed, 17 Jun 2026 13:11:24 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 2/6] flow: Indent flow details messages Date: Wed, 17 Jun 2026 13:11:18 +1000 Message-ID: <20260617031122.2086827-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260617031122.2086827-1-david@gibson.dropbear.id.au> References: <20260617031122.2086827-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: EYN473XGL4TUWK4KCGFIA2MOF2LCBCF2 X-Message-ID-Hash: EYN473XGL4TUWK4KCGFIA2MOF2LCBCF2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: flow_log__() has the option to append an extra log message with address details of the flow, to give more context to errors or warnings. Add an indent to this part of the message, to emphasise that it's additional information related to a nearby message, rather than a message in its own right. Suggested-by: Stefano Brivio Signed-off-by: David Gibson --- flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/flow.c b/flow.c index e71f3de7..2f1530b5 100644 --- a/flow.c +++ b/flow.c @@ -310,7 +310,7 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details, if (state >= FLOW_STATE_TGT) { flow_log__(f, pri, false, false, state, -"%s [%s]:%hu -> [%s]:%hu => %s [%s]:%hu -> [%s]:%hu", +" %s [%s]:%hu -> [%s]:%hu => %s [%s]:%hu -> [%s]:%hu", pif_name(f->pif[INISIDE]), inany_ntop(&ini->eaddr, estr0, sizeof(estr0)), ini->eport, @@ -323,7 +323,7 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details, tgt->eport); } else if (state >= FLOW_STATE_INI) { flow_log__(f, pri, false, false, state, - "%s [%s]:%hu -> [%s]:%hu => ?", + " %s [%s]:%hu -> [%s]:%hu => ?", pif_name(f->pif[INISIDE]), inany_ntop(&ini->eaddr, estr0, sizeof(estr0)), ini->eport, -- 2.54.0