From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KRSVARBB; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 5B64A5A0265 for ; Wed, 17 Jun 2026 14:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781698868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H9gs9Mv0uODpYdV0DIj2pdJE5VC+VYZ1NDvSPMlvLrc=; b=KRSVARBBTJo44sjB7je4M5fl8TwVhdUt/MZvc+2JoqJTS90XQ5xZplgEmLL+tdZ+P/GPDO 16mWzorbbSnUbMDXMsOozcVa3t2dslB7nFwuIVdT0h21VeNYrxmRgb2Hrvv4iQqxTl73iJ aVHjfFd39GbjL4x9L7zAOA8imbAYaIM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-GR0pTt1nN5S3AmPUmT12jQ-1; Wed, 17 Jun 2026 08:21:06 -0400 X-MC-Unique: GR0pTt1nN5S3AmPUmT12jQ-1 X-Mimecast-MFC-AGG-ID: GR0pTt1nN5S3AmPUmT12jQ_1781698866 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E61A91955F2D for ; Wed, 17 Jun 2026 12:21:05 +0000 (UTC) Received: from lenovo-t14s.redhat.corp (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1DE01180049F; Wed, 17 Jun 2026 12:21:04 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH] inany: Fix doc comment to match u32 field, not u64 Date: Wed, 17 Jun 2026 14:21:03 +0200 Message-ID: <20260617122103.97215-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jaH2gs27ArI9SKfegMjq5nS9y4IZUn0YlvYuh8c5mZA_1781698866 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: BVE3TL34TYRBBKN722DIO6MIRKMFKNRA X-Message-ID-Hash: BVE3TL34TYRBBKN722DIO6MIRKMFKNRA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The original siphash incremental patch added a u64[2] member to union inany_addr for hashing. During review, this was changed to u32[4] to preserve 4-byte alignment: a u64 member would have forced 8-byte alignment on the union, mismatching struct in6_addr. The doc comment was not updated, fix @u64 references to @u32. Fixes: fc8f0f8c48ef ("siphash: Use incremental rather than all-at-once siphash functions") Signed-off-by: Laurent Vivier --- inany.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inany.h b/inany.h index 73385b916240..6bf3ecaa0e7d 100644 --- a/inany.h +++ b/inany.h @@ -22,9 +22,9 @@ * @v4mapped.zero: All zero-bits for an IPv4 address * @v4mapped.one: All one-bits for an IPv4 address * @v4mapped.a4: If @a6 is an IPv4 mapped address, the IPv4 address - * @u64: As an array of u64s (solely for hashing) + * @u32: As an array of u32s (solely for hashing) * - * @v4mapped and @u64 shouldn't be accessed except via helpers. + * @v4mapped and @u32 shouldn't be accessed except via helpers. */ union inany_addr { struct in6_addr a6; -- 2.54.0