From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=km1S+7U4; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 101515A026E for ; Fri, 19 Jun 2026 17:26:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781882789; bh=eRYBcIwUZQmckgiu3dFoD4E8Qv5H+uMVjY/De81a0vk=; h=From:To:Cc:Subject:Date:From; b=km1S+7U4s1jrnY3EJt8m8w32bFm9GjWJscBaWhNRG+5uYl0/W5HGptYRSQmmHcZmA ggHO02nKJCQCIsrGnvY8xri+Xu9EX3Us2bKkZ55v3C6+D30X1OH6tpp/WQjFgWO9xG XzEmfPvTTDSm9xRpo7QhDuFoCYwZhgz9t4POt0+sGPoCScY1cMgVAvmf07fMgF6TnN Yl3WBrbL10lK61+q3Fo56SiBikFT/Uj5ck4m51MvQidltaFSNFRJ2cGTAcFJ/68VlC /dsu1B9BAxj6+/fAxMMZ1w/ugD74D1c8r6v135Wnt4zaKcoBOgR8hSd9Xx8mcNqwms vriDgdmy0TuzA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ghhJj4bd0z58lv; Sat, 20 Jun 2026 01:26:29 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v3 0/6] Improvements to flow specific logging Date: Sat, 20 Jun 2026 01:26:20 +1000 Message-ID: <20260619152626.3033033-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: RGGHWR52BNETQ7N4SDEU2SQAOUGHWJRL X-Message-ID-Hash: RGGHWR52BNETQ7N4SDEU2SQAOUGHWJRL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While working on podman bug 23739, I found some deficiences in how and when we report various socket errors related to specific flows. Here are some preliminary patches to improve that. v3: * Added a attribute((printf)) for the base flow log function * And fixed a couple of bad calls that caught * Removed one change from a plain log to a flow-specific log in UDP, where it turned out we didn't necessarily have a well defined flow * Fixing a cppcheck warning in the process * Put an explanatory comment and clang-tidy suppression for the (very limited) recursion in flow_log__() v2: * Added patch 2/6 At Stefano's suggestion * Simplified the errno Handling fix at Stefano's suggestion * Added patch 6/6 which I noticed while revising 5/6. * Made a handful of minor corrections based on feedback. David Gibson (6): flow: Regularise flow specific logging helpers flow: Indent flow details messages flow: Include flow details with higher priority log messages flow, udp: Fix errno handling in udp_flow_sock() flow, treewide: Promote priority of selected flow-linked messages udp: Improve messages for errors getting errors flow.c | 108 +++++++------- flow.h | 79 +++++----- icmp.c | 27 ++-- icmp.h | 3 +- migrate.c | 27 ++-- migrate.h | 8 +- passt.c | 8 +- tcp.c | 387 ++++++++++++++++++++++++++++--------------------- tcp.h | 5 +- tcp_buf.c | 67 +++++---- tcp_buf.h | 7 +- tcp_conn.h | 8 +- tcp_internal.h | 27 ++-- tcp_splice.c | 59 +++++--- tcp_splice.h | 3 +- tcp_vu.c | 31 ++-- tcp_vu.h | 5 +- udp.c | 57 +++++--- udp_flow.c | 18 ++- 19 files changed, 534 insertions(+), 400 deletions(-) -- 2.54.0