From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=VCCBb+Fg; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2C98A5A0262 for ; Fri, 19 Jun 2026 17:26:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781882789; bh=twWnQWG2CFda6LUgxQI7UN0MWdAHxBtJsB5OeCkd4Kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VCCBb+FgQ5F9thsDP/sawSiXqMsCZJYGP4PQcy5NzqabujSq/tEiO2MkHQUJ1Sqp2 Z+GmAKqTMtMkNsZoEsNJ1/q8aOH9UeM0fP1mg1K5E2Oy+JvYwl1uT/PNRP3uWu/kpJ nc/iEoUyiLSFLFDnZQy6KNXgkKrt0ZzCaZ7qkvnv1l3zLU3HdXHvHCIFN9UCzwgGrF DaAJ+M+z+ZF/Xu6LpYKKyLN8kBxe1sm8y+ZFH5zUqS7BT0cqNIlSc9OSOD1FG2LH4B YiLTDKLlfv4vmUFbhTuIsFwC50oJhC4vOOadtmoaPjebSL30nvgOKsA+FUPRkUTiFX +ufEokXYRaT3w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ghhJj4zhpz58sw; Sat, 20 Jun 2026 01:26:29 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v3 2/6] flow: Indent flow details messages Date: Sat, 20 Jun 2026 01:26:22 +1000 Message-ID: <20260619152626.3033033-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260619152626.3033033-1-david@gibson.dropbear.id.au> References: <20260619152626.3033033-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: CTV3HA6Z5ERI6X4CIFHULA3O2JXLTIAN X-Message-ID-Hash: CTV3HA6Z5ERI6X4CIFHULA3O2JXLTIAN X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: flow_log__() has the option to append an extra log message with address details of the flow, to give more context to errors or warnings. Add an indent to this part of the message, to emphasise that it's additional information related to a nearby message, rather than a message in its own right. Suggested-by: Stefano Brivio Signed-off-by: David Gibson --- flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/flow.c b/flow.c index c6741251..8f8435e6 100644 --- a/flow.c +++ b/flow.c @@ -315,7 +315,7 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details, if (state >= FLOW_STATE_TGT) { flow_log__(f, pri, false, false, state, -"%s [%s]:%hu -> [%s]:%hu => %s [%s]:%hu -> [%s]:%hu", +" %s [%s]:%hu -> [%s]:%hu => %s [%s]:%hu -> [%s]:%hu", pif_name(f->pif[INISIDE]), inany_ntop(&ini->eaddr, estr0, sizeof(estr0)), ini->eport, @@ -328,7 +328,7 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details, tgt->eport); } else if (state >= FLOW_STATE_INI) { flow_log__(f, pri, false, false, state, - "%s [%s]:%hu -> [%s]:%hu => ?", + " %s [%s]:%hu -> [%s]:%hu => ?", pif_name(f->pif[INISIDE]), inany_ntop(&ini->eaddr, estr0, sizeof(estr0)), ini->eport, -- 2.54.0