From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GYd4Moka; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 7B8315A0262 for ; Fri, 19 Jun 2026 19:05:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781888744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vnhnCpfQTtm0yKxmwTKT2qRMalLgydD1DKOVIHWwKZw=; b=GYd4MokaSRWftTKFc30XUwgmUL59UXpC5uf67qvntOHwjnMohBqlanYdivbOJ91KRgzCMZ XZlYvwW2P1NkkxOiiNev1Hk/aI9F+lQmHfXyg6cgrKkhszOZJuUQW/npnJx0pC/MIYTb8r YragBLIrlHp+1tHuvl+v24ey2b5t2+8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-foSGCFRCNpuE1Jdsho1BFQ-1; Fri, 19 Jun 2026 13:05:42 -0400 X-MC-Unique: foSGCFRCNpuE1Jdsho1BFQ-1 X-Mimecast-MFC-AGG-ID: foSGCFRCNpuE1Jdsho1BFQ_1781888742 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4623bdcad2fso1461124f8f.0 for ; Fri, 19 Jun 2026 10:05:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781888741; x=1782493541; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vnhnCpfQTtm0yKxmwTKT2qRMalLgydD1DKOVIHWwKZw=; b=X25cK2USQdjiGq+rdrSYbgLS15TFBVoKzgn0PD4EYnMsHW0uzML2mNP5N/Q5Yt6f8P EAEYtJM10TyTI8J2Mhv8hVG6JuTZSYdOLjqHPdtGklrPcXlcbSRksYU/x02V3VU4/W4f XxC1xiOLL861U7Hir7nevkOQz7MwoIMXM5YcvPIGMWykRuT791Q8pNCSrFE51ofzInIT VkipQ+EHH/3HXSQXxBlKAfGfJxBqWblE1gTanmizP22ffnLui5YV5gy31Sy7RR26GQ1b PVeOFIYOHAMyDNCLH8dMvokFYHlXXDzGpCDMyU0KqQLhApHd0+QfamWLpYe9AFcLiwkN m9TA== X-Gm-Message-State: AOJu0Yz8kZmP7AGs5haOaJiZb0OXqBSQapR5i1wdPrzG2Fc0jlx/wm1y gIMNTda+z58Vv2ZK9XJXIsMdT2Z2aqmB209+n9ZaB63dpwFAKHZ2EImGt1MnzR6YDdvut1/pxV9 9EskK/2kTWHqZEdwGik7VSdN6Q4TGl5J4NZ6dKVglvuyxw5cah9sRosVkhsR807NpKBrqn3/B/R AMwQ6eWjgr4S1IU7QsRYYO+9IcGZlJXegeDfyJ X-Gm-Gg: AfdE7cmtz8jFvwFRiFCyKI5mijbtimaYc20fUT3BfWb8SdYu4T1SXC6ih1NeFBkkTVM IEz4OqyyQ/Ib7mfVmL5wiUM7T3kicYQLhhhwYtbWEAdf1O3KWUk3VcrcuF+cTdr/9mBxKmxuWsX EBl5GTWy/2QXhBKxT+SbmOCftqFqovYqsdl358XwIn7hPL4jM0dXZUuc186O3wm+MUXYs0K4/j7 GVk6GoazC3Dkv6EmBTtEkKm2eQ5qN9A0wDo8qUfp+0MFYRReYYdW/gk6LZJzcklH9aGn59dSZWs agcF/MbRzsouFPqXS5wQVHmOC+BHkE9FJ4kj7OjPnne2WxhkidkuOg005JlXfFyrokCoihvgpwq TXW03J9G7s6w9vJaeX45NZO6z/IJZ+SeeRYaQOtk= X-Received: by 2002:a05:600c:154a:b0:491:7325:39c4 with SMTP id 5b1f17b1804b1-4923f594ca9mr77096555e9.34.1781888741570; Fri, 19 Jun 2026 10:05:41 -0700 (PDT) X-Received: by 2002:a05:600c:154a:b0:491:7325:39c4 with SMTP id 5b1f17b1804b1-4923f594ca9mr77095955e9.34.1781888741012; Fri, 19 Jun 2026 10:05:41 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923ff821aasm83404495e9.12.2026.06.19.10.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 10:05:40 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] inany: Fix doc comment to match u32 field, not u64 Message-ID: <20260619190539.14709309@elisabeth> In-Reply-To: <20260617122103.97215-1-lvivier@redhat.com> References: <20260617122103.97215-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 19 Jun 2026 19:05:40 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j5zZjRU0WcEa-cV6hWfoekFOpfxzV2d8tFrRo_m098g_1781888742 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IUFISQQJMUUYIMBBVNCLR53IG4FONJOA X-Message-ID-Hash: IUFISQQJMUUYIMBBVNCLR53IG4FONJOA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 17 Jun 2026 14:21:03 +0200 Laurent Vivier wrote: > The original siphash incremental patch added a u64[2] member to > union inany_addr for hashing. During review, this was changed to u32[4] > to preserve 4-byte alignment: a u64 member would have forced 8-byte > alignment on the union, mismatching struct in6_addr.I don > > The doc comment was not updated, fix @u64 references to @u32. > > Fixes: fc8f0f8c48ef ("siphash: Use incremental rather than all-at-once siphash functions") > Signed-off-by: Laurent Vivier Applied. -- Stefano