From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CPo1M72Z; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C6B7F5A0262 for ; Fri, 19 Jun 2026 21:43:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781898237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wOjJu8U9yHs80oyRvIgBGZia40DI2th/vt8nFpKTiuo=; b=CPo1M72ZerNBHreXx63tauJ5bQLbOHtEodUjD/zHOitbB1bVpeZMcWqw64u2H5QL8lg0Sh XzXJ7Jx1molOuL/VwVaopGfauksv1JW9x/IElhpJlcFOYXgulJSTlu9wubIox1KTzzUTRp 8E0XNDElzoEQRiOAiGFF3zePDfyEMG4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-u0tOvbScPyWlscK0NxkbWg-1; Fri, 19 Jun 2026 15:43:55 -0400 X-MC-Unique: u0tOvbScPyWlscK0NxkbWg-1 X-Mimecast-MFC-AGG-ID: u0tOvbScPyWlscK0NxkbWg_1781898234 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490bfd70b0fso20625205e9.0 for ; Fri, 19 Jun 2026 12:43:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781898234; x=1782503034; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wOjJu8U9yHs80oyRvIgBGZia40DI2th/vt8nFpKTiuo=; b=SE6RnJdwWdIJ2ojF9rWaBnfl4A/wPBtgm7HQ72JXD8GKTrvh1TbGoE9wpsQdylZOMM pmcRHt0w+aIFr4oupzcmg4p8Zjo4q0lGPgDOfrkjXf5MzUdLqBFUwHxAfRrf1cLPi96p 1Po2M6mNrWRgTgeEPVzMCz+kVYgWpzkogrbLLGyVpsDN2bWQzILEPdOc1zRiAhlHMl4x i9/tqowaOBWfaxxptgAhVnswPaHXkrvR7L7BRmV9GafrAe02TJjil9PMdAXoxemrpj5N Qm/CyLDEyXUYnzYIXS/lCOZCTroKdp3mdZ1Vq35lNVt85owvBB6ubN/t70vNOf+kX1yH TL9A== X-Gm-Message-State: AOJu0YynMzCpedLk3LP9stYm+57O00LDRP1oNjZwdEjmTsSBgoxBFqPA 0bzgJJMmWttCnno2rBbM0LBG+FROgnDuW5cv8mTmWJ5XH7zN4oEqN3WKN/wGsvbxyt1YcEF8Zw0 a0fA9vqYamr0PnhdMqPz8GTwImgECU0+I4W1wCvxzV3QKF5W1NN/F+CaCTeeL1w== X-Gm-Gg: AfdE7cmU0JuIpq6XM5+CtfwfFIR1oA6gvZxUlItmzgsKbXItJm/KsOuZ6tzc+fEXlJZ AKbyh6qMh2OmXkcSXL3mDzRccKmOrGOOLlZWi4oWjMH4W4yV5Fw5HVAvPJGvMf+9v3AZZlyL57j /ID1TMUvFbVyPhrzPB+p8ykY5ZsJkSAR9KYjkcKUwNHAytTzIAdzOI3+PqVt0ZuI1B/vJk4NoAc av05LLaIYB9QkWGHjAIPzqvU5A1NIaRkgAuc46jnNW3Xg/11ohMop6QWetxYWc2yzxmJh5teXiQ lyuKGQQjj9/aA9KILNj+Rv+Ef+R3PjJXI0sLzFL90vVh9FBUyTtPvdNoP1OL2JxsdrH/xAmj6oE vjIdFi+XptG0NxWtrBgA+pw== X-Received: by 2002:a05:600c:4714:b0:492:38c8:c426 with SMTP id 5b1f17b1804b1-4924233c346mr61590605e9.13.1781898233926; Fri, 19 Jun 2026 12:43:53 -0700 (PDT) X-Received: by 2002:a05:600c:4714:b0:492:38c8:c426 with SMTP id 5b1f17b1804b1-4924233c346mr61590195e9.13.1781898233436; Fri, 19 Jun 2026 12:43:53 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923ff8a9e3sm93738335e9.14.2026.06.19.12.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 12:43:52 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 0/6] Improvements to flow specific logging Message-ID: <20260619214351.14f60ee9@elisabeth> In-Reply-To: <20260619152626.3033033-1-david@gibson.dropbear.id.au> References: <20260619152626.3033033-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 19 Jun 2026 21:43:52 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vU0U9LdQaXZiBCd-BGb3z5oIHWU-PUHc0tIfZ1Qr-ME_1781898234 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6O5JNR3DISLAH4ZJVO3U7G4LFX2OK4RT X-Message-ID-Hash: 6O5JNR3DISLAH4ZJVO3U7G4LFX2OK4RT X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 20 Jun 2026 01:26:20 +1000 David Gibson wrote: > While working on podman bug 23739, I found some deficiences in how and > when we report various socket errors related to specific flows. Here > are some preliminary patches to improve that. > > v3: > * Added a attribute((printf)) for the base flow log function > * And fixed a couple of bad calls that caught > * Removed one change from a plain log to a flow-specific log in UDP, > where it turned out we didn't necessarily have a well defined flow > * Fixing a cppcheck warning in the process > * Put an explanatory comment and clang-tidy suppression for the (very > limited) recursion in flow_log__() Applied. -- Stefano