From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WQ12brVW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2C8C55A0262 for ; Mon, 22 Jun 2026 09:14:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782112496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACOu6Y6Ay8qBDRFLgCryYpBHfnBVmC6VLXYPpmcCdVw=; b=WQ12brVWTBDHcJzAPzF1L60Nljv6Gfg/FtXS87b78xFH+zOqJkH6NWTfaepX4sS/QfZXTW mEhv84qWgH4AQQ8AB5QiXzsLyt3ggIYLRRAq4T0cmRcuZvPJ9aEngoy4a2QWqTEk5mIedd TT1FJ9GKbN2I5wnxAgvybqNICK7V+aw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-kcg3xv2tOiuOb0tNn2KFYQ-1; Mon, 22 Jun 2026 03:14:55 -0400 X-MC-Unique: kcg3xv2tOiuOb0tNn2KFYQ-1 X-Mimecast-MFC-AGG-ID: kcg3xv2tOiuOb0tNn2KFYQ_1782112494 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-469675e37e8so210232f8f.1 for ; Mon, 22 Jun 2026 00:14:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782112494; x=1782717294; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ACOu6Y6Ay8qBDRFLgCryYpBHfnBVmC6VLXYPpmcCdVw=; b=ZyPLG3YbbLKNYm3RGdfIbBB34AuM0ek5/w/e0Y3L56jcOIZ7qNGYC6VCQXLqvDJTbZ 3obYlNj74PtQsuSe2ZwJMO/QOHFBV9XK1yj0m1VMAaIrI9T9F0nmM7h6MdN4fHnrGMnV K4VBdVhVI0HoD2RbLV5slqnkuWbh/EWkZT1ARaMqYhmAIzwwqRhge/W7m5vZPeIJy4b2 8Nl/d98qdgMBAP+xhvabo1loRpgwPo388Y5svBdUKAa8kbAfznMgkQ3MfhhfsfP3xdbA SzlpcCmkm5G3dR2mRkAeZ7IJ+pUeUTfbV4uq0QJc4Xvd+NSPLhd87poK9EucimbIhLGT MH7g== X-Gm-Message-State: AOJu0YweFDfazJXJp684BcjEW9uJ57/RQH/ORUUycoCEpi4iSXEER+DG HnvCWK+11u9T1aydIOK7CVkoR8vjjaqCmA+GctO4zY047SO+WsU2OD2rvlNMMP9hHqgeis4dZus QrSbC6oQc3p03MHQMwe778jSHGHVbyj8297nvSd/wUdcv9gBMJ/AiUQ== X-Gm-Gg: AfdE7cmsYvO6ZlT3pbry7AcX3cUeRy+z6yUGmiEDojughhoVnF1KjHqAaKHn/XXn0If ko5MFhe6oUDfih/CIlsPeWNWJnAs3LBQzbrHEsIJneh0qB2OjJZlhbxo9hngM6w0k12nmtodNRZ U28dvHKKxy35uHmYEpB/eSl61OZ29rCVvrLsj2VTdM32snww1uZA33hCozFxrdPn+Cqhm+mt/LT BgttNeOta8RuwcUmoPNGkd0uuavTCvayqPDJEswIPbFHBqYkU5//Q1qun3deOIFOohNK2zdyG3M clbaUfMdwxoqQ1nL3R9CRgvuCspHvt8leXZzPS86+Jts4mZrId2Hes7Tn/bYgOIRKOsZ62YE9Hz JSAF6h7J00F+PFFNFwEFB3HaeQHHTXGMxMHOatHw= X-Received: by 2002:a05:6000:2402:b0:469:d892:9cfb with SMTP id ffacd0b85a97d-469d8929e74mr901592f8f.10.1782112492734; Mon, 22 Jun 2026 00:14:52 -0700 (PDT) X-Received: by 2002:a05:6000:2402:b0:469:d892:9cfb with SMTP id ffacd0b85a97d-469d8929e74mr901499f8f.10.1782112491825; Mon, 22 Jun 2026 00:14:51 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57afasm24164811f8f.29.2026.06.22.00.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 00:14:50 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 0/6] Improvements to flow specific logging Message-ID: <20260622091449.0495ddc3@elisabeth> In-Reply-To: References: <20260619152626.3033033-1-david@gibson.dropbear.id.au> <20260619214351.14f60ee9@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 22 Jun 2026 09:14:50 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: q27YctzAqdt3DCI3ALUd6MffeWVtB7VX4I3mYcq9vEk_1782112494 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3KPYWT4QF3BFAWMK4DLKEP45VQHJJNMA X-Message-ID-Hash: 3KPYWT4QF3BFAWMK4DLKEP45VQHJJNMA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 22 Jun 2026 12:37:28 +1000 David Gibson wrote: > On Fri, Jun 19, 2026 at 09:43:52PM +0200, Stefano Brivio wrote: > > On Sat, 20 Jun 2026 01:26:20 +1000 > > David Gibson wrote: > > > > > While working on podman bug 23739, I found some deficiences in how and > > > when we report various socket errors related to specific flows. Here > > > are some preliminary patches to improve that. > > > > > > v3: > > > * Added a attribute((printf)) for the base flow log function > > > * And fixed a couple of bad calls that caught > > > * Removed one change from a plain log to a flow-specific log in UDP, > > > where it turned out we didn't necessarily have a well defined flow > > > * Fixing a cppcheck warning in the process > > > * Put an explanatory comment and clang-tidy suppression for the (very > > > limited) recursion in flow_log__() > > > > Applied. > > That doesn't seem to be the case. Did you forget a push? Oops, yes, sorry, pushed now. -- Stefano