From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TLxi98OD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5C2915A0265 for ; Wed, 01 Jul 2026 02:07:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782864426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4nO+zu//9dBouTZFkrcmlJ8GQg1syjQvQycLZDWswU=; b=TLxi98ODG7Nx3pBVeBNd41k1hm00ufJkUvj7KPKJxN2gJpFH6t8fmJYxx1o9Tx11yZM4br 6iTC7q5smdkKEiOYJbtEwQptPUeQuNWnl6COLboQxIQbSOIQvwCG/v69RiSHJxq+osNXLr Xp/Ea9IFj7N19QwwiLwcEukSWLybFD4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-omX43TpCNieB_ODgzDAaEA-1; Tue, 30 Jun 2026 20:07:04 -0400 X-MC-Unique: omX43TpCNieB_ODgzDAaEA-1 X-Mimecast-MFC-AGG-ID: omX43TpCNieB_ODgzDAaEA_1782864423 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-473f4a48e9aso26748f8f.2 for ; Tue, 30 Jun 2026 17:07:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782864423; x=1783469223; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b4nO+zu//9dBouTZFkrcmlJ8GQg1syjQvQycLZDWswU=; b=FjeJHZLYgMCEC8v5EaLiPkTG69Ae3s44batdjMbsWIHnqux+eWyYj+/3pXRYyUqr7q bJelHf1s41FGVtH54DBq2xKXhs5a+pkBqdBUAUgPYsbTO6An9R5Hx+ApBj+OgnLzybi5 DT/XiBaI4RYiZ7T9GzS/6MyA9ZpkUo8kWakrAurkhEpxb+AhXpiZd5lyp9mITEw2Z/JP poa7aTysAKunlh+F/MU0Zaq2zqcnwuqQ1hMVDHFKXVquiD6y89QoFtNlYOgbfbTfV818 KzPaMs4UA101Zdhmlv0qV9BeblhLAW3x7bNcjNItX1lyVHXxiaP0UCQecqZ3ICmgnCRC jnTQ== X-Gm-Message-State: AOJu0Yxqygo8yyHXH3hoPa+qcdmGAFcNS/xRXfIqDyQD+CZEn89dC7tx MqjnRwiFECp3y1Jou0sdvhLlx/JD9q86YqN8haiW8dIzY/Lp9rf2zhnYVX++oA0ucJ1ZpiARa3x sMmFw0CnILAeYzwR8sppMwMEqRQH6pG3cTbiuLhX3ZTkDuDGmBay7jfAlrIp4EA== X-Gm-Gg: AfdE7ckFmYHwVCp6ohzt7TcktkuX5cSHgyV11Bj4J1ZdkKoetxfufTRqPLRiNYKQRFI 1fJy72gxp1M5slI9t0MDtH38GaBVqDxNElDeCwT6igy7wX1u3kiUlOhF1zjBZScUlOxZX3Aet6z LWRogVh//JfSXzXSxSkwq0U/l5rFI542NV+9TLg8dWwWRn3qeb1+WapAdn8OE5kQ6OC6Hcm1Fjd O42jnszdrKO4U9hRPAT88ZpAusHomI0ik0F4C6LAdSrmEmObkodTWrV2cQtW19MPIJW7nj8cFHp abRLt6ntcw/XmD86y4PHB/SZkroeOPG3S5dBHazf7PGB3RrqeiPqMLaEkchxdFHGrKcSV4CnMDW BHSMmDMsZxaoavM22ohjRkhrbvWO9wbZRe2Jxp9k= X-Received: by 2002:adf:e183:0:b0:475:f0c2:5b04 with SMTP id ffacd0b85a97d-475f0c25b71mr6161149f8f.58.1782864422975; Tue, 30 Jun 2026 17:07:02 -0700 (PDT) X-Received: by 2002:adf:e183:0:b0:475:f0c2:5b04 with SMTP id ffacd0b85a97d-475f0c25b71mr6161113f8f.58.1782864422545; Tue, 30 Jun 2026 17:07:02 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475643cd64bsm12590363f8f.14.2026.06.30.17.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 17:07:01 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 01/12] Makefile: Add missing PESTO_HEADERS variable Message-ID: <20260701020700.392d6ac6@elisabeth> In-Reply-To: <20260626071003.3472194-2-david@gibson.dropbear.id.au> References: <20260626071003.3472194-1-david@gibson.dropbear.id.au> <20260626071003.3472194-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 01 Jul 2026 02:07:01 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 61S2Oeh9o6ImywO2hnCWDTNdpYJByqWKk5lknbdWEUY_1782864423 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FOBTO7I4SHBCBMIB3WICZ3ADSCGNNVVO X-Message-ID-Hash: FOBTO7I4SHBCBMIB3WICZ3ADSCGNNVVO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 26 Jun 2026 17:09:52 +1000 David Gibson wrote: > In several places we use a PESTO_HEADERS variable, with all the headers > that we need to build the pesto binary. However, we never define it. > This looks like an error introduced by a bad rebase of the series > introducing pesto before it was merged. Oops, yes, I just found that in a patch reject file. And I just discovered that a Makefile variable that's not defined happily expands to nothing, I wasn't aware of that. > It turns out the fact we didn't list the headers was the only reason we > weren't getting unusedStructMember cppcheck warnings for pesto as we > already do for passt and passt-repair. So, reinstate that suppression for > pesto as well. > > Fixes: 02236db32625 ("pesto: Introduce stub configuration tool") > Signed-off-by: David Gibson > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index e8170e90..5ed0f702 100644 > --- a/Makefile > +++ b/Makefile > @@ -55,6 +55,7 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ > virtio.h vu_common.h > QRAP_HEADERS = arp.h ip.h passt.h util.h > PASST_REPAIR_HEADERS = linux_dep.h > +PESTO_HEADERS = bitmap.h common.h fwd_rule.h inany.h ip.h log.h pesto.h serialise.h > > C := \#include \nint main(){int a=getrandom(0, 0, 0);} > ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) > @@ -203,7 +204,8 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ > else \ > echo ""; \ > fi) \ > - --suppress=missingIncludeSystem > + --suppress=missingIncludeSystem \ > + --suppress=unusedStructMember > > cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck > > @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck > $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ > > passt.cppcheck: BASE_CPPFLAGS += -UPESTO > -passt.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember > passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h > > -passt-repair.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember > passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) seccomp_repair.h > > pesto.cppcheck: BASE_CPPFLAGS += -DPESTO -- Stefano