From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QTEMFF9K; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 03BB65A0271 for ; Wed, 01 Jul 2026 02:07:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782864431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e1o0plpHauVxCGF8i+sGga+Z6WHPh40LC3iZ5C1WcC8=; b=QTEMFF9K08laiJTepY+WSt0Dw7g56IA85RVZ1BfBplL8nuf00jBFGvhyN/R0DlVNIK5z1H wEOz3agJgwoTTM69iHUqsAIJSs7JSBuiUrsbCEGc5fV7YhzgkkDMatlT88jTmn63/m92av KcGF2CBJ9ws/tB1BR5574tCXPndThp4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-rHumG1kSOtut4Fdr0TTZKA-1; Tue, 30 Jun 2026 20:07:10 -0400 X-MC-Unique: rHumG1kSOtut4Fdr0TTZKA-1 X-Mimecast-MFC-AGG-ID: rHumG1kSOtut4Fdr0TTZKA_1782864429 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-476d52b13d7so49835f8f.0 for ; Tue, 30 Jun 2026 17:07:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782864429; x=1783469229; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e1o0plpHauVxCGF8i+sGga+Z6WHPh40LC3iZ5C1WcC8=; b=G0rTQJTYhyTbGJSkWrdBURHWI004jE4ffu2hPUlb17uuC+MufMQbDPf+iaJKnovH4K FqHl2B6FVy1pFZ2bnwaixxR2VjHLEvuv+Wjn4/OesQnTnvN/+YeNM/63npz1crzzmqj8 an4FvCtLxGld6+HN8hOiZmXofS6XgP9wQuG4F2I94aIqFFX9lFR6mdKOImkfHnF099PF 1nZ+xFRKfbw+NUq2SyWiZfJSbcfWwM6PA6TpNKSm5sBzxJj5LvRa07JcqTow2RCyVtAJ v7ZNV3zz6/MfXnXfS9wQX4B/ZXgI0/BivI+ewIQM3R4E6Yex5nuF17d6PWGJZOryLxtV G4tQ== X-Gm-Message-State: AOJu0YxWUVe8fAeTBQfUIUCdmGko39b1igkSYWXQPv/VQMKzMPqjO35h B5lkX+ht0RkJ2Y2qpJY98MlopsjxwuJejYJJ99CfalN0z4CDo5I9iepP/fzgTdEu3GUOe3itofz ZP0jcJr3pQieUvxwQcN6Z8wbwLKWfTgqBSyz0sKUUXBpmPC4yfV7XEQ== X-Gm-Gg: AfdE7cler3gSKW6de+6LmpN5EQpkOzPB6ltx6CRbLDQJRZSinsSklJWbY7E5bmfdBdS gdlWpBLZaL1b5TTwg8OanUj0WM+Y0+9uLAKgxUyDydWbxJ+NC9H2yjqkCilCJ7fRiwXzc6i7I1q oLqxAnvAE/ChFYb3HOCGVSjIn13lbxuTKlKgfOUk6Vj9GKBkuaNw3XkwrnpaYgfDDVB0UA2JrDt 43g/dTZIXyO6l9HLlheV+20xZxXcncUtksPycY+eT7cnVzu32lL9e125oZUT7QW8OaJ0RUcXi9p Z8KRwvpw24Ofizk7jwnaWK7pd3gvQQ6G6IRYlJAhiJQfmuunxf0kz9SXybzEqD8TXoNT6P+ry/W PKOrAr2vnq0IMpWMJRk5HV9fB8/nef3Wz64Xwwnk= X-Received: by 2002:a05:600c:c101:b0:493:b782:10d9 with SMTP id 5b1f17b1804b1-493b8287fa9mr76798045e9.10.1782864428686; Tue, 30 Jun 2026 17:07:08 -0700 (PDT) X-Received: by 2002:a05:600c:c101:b0:493:b782:10d9 with SMTP id 5b1f17b1804b1-493b8287fa9mr76797745e9.10.1782864428261; Tue, 30 Jun 2026 17:07:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2945sm34483475e9.4.2026.06.30.17.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 17:07:06 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 02/12] conf: Use parameter instead of global in conf_nat() Message-ID: <20260701020705.574f259e@elisabeth> In-Reply-To: <20260626071003.3472194-3-david@gibson.dropbear.id.au> References: <20260626071003.3472194-1-david@gibson.dropbear.id.au> <20260626071003.3472194-3-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 01 Jul 2026 02:07:06 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 42778_LWeO0U9yCV3l3-vFTRf4sgeF-qyNWXOkBPuV0_1782864429 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AAFDB42ARCEC64ZKOE2NWISR5D6KZCT7 X-Message-ID-Hash: AAFDB42ARCEC64ZKOE2NWISR5D6KZCT7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 26 Jun 2026 17:09:53 +1000 David Gibson wrote: > Conf nat takes a parameter @arg for the argument it's parsing. However on Nit: conf_nat(). > error we print instead optarg, the getopt() global. This happens to be the > same thing at the time of the call, but it's not the right way to get to > it. > > Signed-off-by: David Gibson > --- > conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/conf.c b/conf.c > index 4755a9f4..6ab8efec 100644 > --- a/conf.c > +++ b/conf.c > @@ -1049,7 +1049,7 @@ static void conf_nat(const char *arg, struct in_addr *addr4, > !IN4_IS_ADDR_MULTICAST(addr4)) > return; > > - die("Invalid address to remap to host: %s", optarg); > + die("Invalid address to remap to host: %s", arg); > } > > /** -- Stefano