From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=fJLHPKzs; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id B8E925A0274 for ; Wed, 01 Jul 2026 07:32:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782883921; bh=RPaX/HSpdQgHAYesAPDH7ySkIXBgcbqIB4/MlrHrrlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fJLHPKzsaBahRSuusZJS6hbPOjhR8DukijzXySGjIQ5axVa4VSU+5DFidkmW58dQ1 cpoubLQxgsZdPdgGuUsrFw/L7qGYFAoBVFjHMw9petDuMolMSMIJV3uw8OUcCmMVFb jiEN1JnK+B2myQMNq7TcpKBeb/sM97U/esJr3Hh5mQmAHBDqspjj4g2ixCNl5wucId YX9MacBDyXM7QnZ8hFT6iTudWzJ/lj/Cj/dMKG8ExrWGOZBPewLxj3pQjvHAgZj467 74cPIBR57od7EUMxCdlvzy7UIfG0Swz+gKTZQxI8gfMW1AxKaJYu8rsRCdLm6qYBlK TBFYG/2GA6vkQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gqpYF0CZ0z4wSd; Wed, 01 Jul 2026 15:32:01 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 01/13] Makefile: Add missing PESTO_HEADERS variable Date: Wed, 1 Jul 2026 15:31:43 +1000 Message-ID: <20260701053155.1219264-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701053155.1219264-1-david@gibson.dropbear.id.au> References: <20260701053155.1219264-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ARDPDUBBEYHRMATUQR4YYQSWN5AUAIQM X-Message-ID-Hash: ARDPDUBBEYHRMATUQR4YYQSWN5AUAIQM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In several places we use a PESTO_HEADERS variable, with all the headers that we need to build the pesto binary. However, we never define it. This looks like an error introduced by a bad rebase of the series introducing pesto before it was merged. It turns out the fact we didn't list the headers was the only reason we weren't getting unusedStructMember cppcheck warnings for pesto as we already do for passt and passt-repair. So, reinstate that suppression for pesto as well. Fixes: 02236db32625 ("pesto: Introduce stub configuration tool") Signed-off-by: David Gibson --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e8170e90..5ed0f702 100644 --- a/Makefile +++ b/Makefile @@ -55,6 +55,7 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ virtio.h vu_common.h QRAP_HEADERS = arp.h ip.h passt.h util.h PASST_REPAIR_HEADERS = linux_dep.h +PESTO_HEADERS = bitmap.h common.h fwd_rule.h inany.h ip.h log.h pesto.h serialise.h C := \#include \nint main(){int a=getrandom(0, 0, 0);} ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) @@ -203,7 +204,8 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ else \ echo ""; \ fi) \ - --suppress=missingIncludeSystem + --suppress=missingIncludeSystem \ + --suppress=unusedStructMember cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ passt.cppcheck: BASE_CPPFLAGS += -UPESTO -passt.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h -passt-repair.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) seccomp_repair.h pesto.cppcheck: BASE_CPPFLAGS += -DPESTO -- 2.54.0