From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=j+wXnLYa; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 2C0725A0265 for ; Thu, 02 Jul 2026 02:59:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782953982; bh=RPaX/HSpdQgHAYesAPDH7ySkIXBgcbqIB4/MlrHrrlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j+wXnLYanxYnmGD58ajmt6HErlTvIRmUO5xZdTgbiuRFhKJRnJ2lUyE23KsxRJ8+P DgyZmA/bZlIjx6caaOGPMKwIVeWgv1bddfqwDEDCxJZbB/WKMLJ3/BCaB6tzJm8Hdh kOhNpl1Ft/4yMwLhUD/eAZdSsv38SqF68e9yZivKj5xYkZsLn0VomM+KfYy38Mya0F VM6hSaHsZS0SAhfM6ucGusMi4UjUTbOlRV+uHWI4w7wUkINWhKxZgZ5fqN8or9Kqgr o9zqdjh4qgIm7/gXPTgzRftJJVOqORlR5zwI1yOeC7ASUxv0YLLexSQFEzJ4cWTE+z VNNT9dCyNBNCA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4grJSZ0W2jz58lp; Thu, 02 Jul 2026 10:59:42 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v3 01/13] Makefile: Add missing PESTO_HEADERS variable Date: Thu, 2 Jul 2026 10:58:49 +1000 Message-ID: <20260702005901.2010709-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260702005901.2010709-1-david@gibson.dropbear.id.au> References: <20260702005901.2010709-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: HNULDAVGGRE5TCZFZQ7LVLDNHBZMEOIT X-Message-ID-Hash: HNULDAVGGRE5TCZFZQ7LVLDNHBZMEOIT X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In several places we use a PESTO_HEADERS variable, with all the headers that we need to build the pesto binary. However, we never define it. This looks like an error introduced by a bad rebase of the series introducing pesto before it was merged. It turns out the fact we didn't list the headers was the only reason we weren't getting unusedStructMember cppcheck warnings for pesto as we already do for passt and passt-repair. So, reinstate that suppression for pesto as well. Fixes: 02236db32625 ("pesto: Introduce stub configuration tool") Signed-off-by: David Gibson --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e8170e90..5ed0f702 100644 --- a/Makefile +++ b/Makefile @@ -55,6 +55,7 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ virtio.h vu_common.h QRAP_HEADERS = arp.h ip.h passt.h util.h PASST_REPAIR_HEADERS = linux_dep.h +PESTO_HEADERS = bitmap.h common.h fwd_rule.h inany.h ip.h log.h pesto.h serialise.h C := \#include \nint main(){int a=getrandom(0, 0, 0);} ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) @@ -203,7 +204,8 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ else \ echo ""; \ fi) \ - --suppress=missingIncludeSystem + --suppress=missingIncludeSystem \ + --suppress=unusedStructMember cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ passt.cppcheck: BASE_CPPFLAGS += -UPESTO -passt.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h -passt-repair.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) seccomp_repair.h pesto.cppcheck: BASE_CPPFLAGS += -DPESTO -- 2.54.0