From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 00/13] Rework option parsing in preparation for destination remapping
Date: Thu, 02 Jul 2026 01:12:06 +0200 (CEST) [thread overview]
Message-ID: <20260702011206.11080ce4@elisabeth> (raw)
In-Reply-To: <20260701053155.1219264-1-david@gibson.dropbear.id.au>
On Wed, 1 Jul 2026 15:31:42 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> This was... a bit of a nightmare. It took way too long and went down
> a bunch of blind alleys. I'm not sure how much I like the final
> result: it's pleasingly terse in some cases, but in others it feels
> dangerously subtle, requiring a pretty careful understanding of the
> sequencing rules of C's &&, || and , operators.
>
> That said, while I was at many points ready to pack it in and hack my
> around the problems limiting the parsing for destination remapping, I
> couldn't really think of feasible way to do that either. So, here we
> are.
>
> v2:
> * Numerous minor tweaks based on Stefano's feedback.
> * The "minor issues" aren't actually minor - they're hard to solve in
> C, remain.
Minus the comment to 13/13, I would go ahead and apply this, even
though I'm not entirely convinced about that parse_eoi() and also its
friends that return true if they succeed, and false when they don't.
I think that I'll get it wrong and that others might get it wrong.
Same for that comma operator: there are a lot of ways to avoid it. And
if we don't, you might remember how it all works, but I'd be surprised
if I do or others do.
Anyway, I don't have a much better proposal for the moment being so I'd
say let's unblock this and I'll try to come up with some amendment
later.
--
Stefano
prev parent reply other threads:[~2026-07-01 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 5:31 David Gibson
2026-07-01 5:31 ` [PATCH v2 01/13] Makefile: Add missing PESTO_HEADERS variable David Gibson
2026-07-01 5:31 ` [PATCH v2 02/13] conf: Use parameter instead of global in conf_nat() David Gibson
2026-07-01 5:31 ` [PATCH v2 03/13] parse: Start splitting out parsing helpers David Gibson
2026-07-01 5:31 ` [PATCH v2 04/13] conf: Remove duplicate parsing of -F option David Gibson
2026-07-01 5:31 ` [PATCH v2 05/13] conf: Clean up conf_ip4_prefix() David Gibson
2026-07-01 5:31 ` [PATCH v2 06/13] parse: Add helper to parse unsigned integer values David Gibson
2026-07-01 5:31 ` [PATCH v2 07/13] parse: Move parse_port_range() to new parsing framework David Gibson
2026-07-01 5:31 ` [PATCH v2 08/13] parse: Add helpers for parsing IP addresses David Gibson
2026-07-01 5:31 ` [PATCH v2 09/13] conf: Move address configuration into helper function David Gibson
2026-07-01 5:31 ` [PATCH v2 10/13] conf: Remove unnecessary mode checks from conf_addr() David Gibson
2026-07-01 5:31 ` [PATCH v2 11/13] conf: Use new parsing tools to handle -a option David Gibson
2026-07-01 5:31 ` [PATCH v2 12/13] fwd_rule: Allow "all" port specs to be combined with other options David Gibson
2026-07-01 5:31 ` [PATCH v2 13/13] fwd_rule: Rewrite forward rule parsing using parse.c helpers David Gibson
2026-07-01 23:12 ` Stefano Brivio
2026-07-02 0:59 ` David Gibson
2026-07-01 23:12 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702011206.11080ce4@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).