From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=JQHafkeU; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 61BD95A0262 for ; Thu, 02 Jul 2026 08:31:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782973907; bh=Kj/9TpghRNOzVq0skHq9a1V3XzCUEuFSDmXci4Cp64M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQHafkeUyDyhrLuXelBMD7pklP41Ju4FIx+CdPE0q8p9+6GLO5B/rJrmriviM0a6j LnQ0hdYBZi6nd4Q4t2VkQ+xHuv4JAJxpIYpHDC5JfoRzI7hupwMrz1O9dQQ0OBtytj qE67KrPi8FXeDBEsTI95oM+LRmfdK0q/Vhy9kO25YzeIdsxNZwSPS1QLd7zyC6nM9w RCBQLXvN6Jza4flJsbjJzQYEzMgUE+sFr69i0u8K7Pq8Ga6T9MYe4lj0h00pHRwHeB o0AaNzt5mdUppvL2GCdmkZtyybq9ZAz78OrOoIcIhmePGlfrknAmX7zjSDjyDaZd97 WZQWa2IHN5QKg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4grRql0VMNz58ms; Thu, 02 Jul 2026 16:31:47 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v4 01/13] Makefile: Add missing PESTO_HEADERS variable Date: Thu, 2 Jul 2026 16:31:31 +1000 Message-ID: <20260702063143.676932-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702063143.676932-1-david@gibson.dropbear.id.au> References: <20260702063143.676932-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: NQD2LD3FVS4ESI5I5MJ7XXFSTHAVB75L X-Message-ID-Hash: NQD2LD3FVS4ESI5I5MJ7XXFSTHAVB75L X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In several places we use a PESTO_HEADERS variable, with all the headers that we need to build the pesto binary. However, we never define it. This looks like an error introduced by a bad rebase of the series introducing pesto before it was merged. It turns out the fact we didn't list the headers was the only reason we weren't getting unusedStructMember cppcheck warnings for pesto as we already do for passt and passt-repair. So, reinstate that suppression for pesto as well. Fixes: 02236db32625 ("pesto: Introduce stub configuration tool") Signed-off-by: David Gibson --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e8170e90..5ed0f702 100644 --- a/Makefile +++ b/Makefile @@ -55,6 +55,7 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ virtio.h vu_common.h QRAP_HEADERS = arp.h ip.h passt.h util.h PASST_REPAIR_HEADERS = linux_dep.h +PESTO_HEADERS = bitmap.h common.h fwd_rule.h inany.h ip.h log.h pesto.h serialise.h C := \#include \nint main(){int a=getrandom(0, 0, 0);} ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) @@ -203,7 +204,8 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ else \ echo ""; \ fi) \ - --suppress=missingIncludeSystem + --suppress=missingIncludeSystem \ + --suppress=unusedStructMember cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ passt.cppcheck: BASE_CPPFLAGS += -UPESTO -passt.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h -passt-repair.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) seccomp_repair.h pesto.cppcheck: BASE_CPPFLAGS += -DPESTO -- 2.55.0