From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SxMtUnWL; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 61ABC5A026E for ; Sat, 04 Jul 2026 17:27:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783178838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUb1VYHs9aC+giUQdTvDiwVKa6F+UPARSQ5ymya/xbg=; b=SxMtUnWLDnmQUP5qLaCCWhv95esxmwzO6b0Dg98lRqxguEx3hnatsZa0120oMlRFsMbeDT THgvvskrOMoEDtkAE3a18D6ZLJvlzNMDn5sgBdr25F15aF7orisszathBT2RjoEyiYBECR kDzPw1eMj+kHwl134d8QKQ377Qe1rOI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-qEhx0ZG3Paau-iYriHcYFA-1; Sat, 04 Jul 2026 11:27:17 -0400 X-MC-Unique: qEhx0ZG3Paau-iYriHcYFA-1 X-Mimecast-MFC-AGG-ID: qEhx0ZG3Paau-iYriHcYFA_1783178836 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-492488f8583so16775105e9.2 for ; Sat, 04 Jul 2026 08:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783178836; x=1783783636; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MUb1VYHs9aC+giUQdTvDiwVKa6F+UPARSQ5ymya/xbg=; b=kYFs95Zlk3KQJGiRGRuRLdvLJVVtAYjCokTBLKxBkun1MZsmL1i+Ks4OLAvA55HgD0 ws6Q+lbPPl39Wdfz+TBYamJTJtKqYVKmkfoIzILJvQHzF1OnfU/EsIG5S9gpe9qYOa8Y 3UYi4/UPP2qhAblqCZUw+tTZgD/Qq+mq5rldjnLUHrLoajaGASTUCRS4gTNzUoLD4Gw0 yegaYcla9YLBrigVDIubL5S6sEqWBBfW9Eny/Am6MFDHSrLHvEzwCcxUNaRypHrCnZCF ECBlRtgHQeqnC3ONI0ZV8Jctw1EzYi9Vik2qOaOLGElE/Kf6JmT7DZy4zjyGwwHvg2p7 9w1g== X-Forwarded-Encrypted: i=1; AFNElJ+Rn37gMKUYv2RIWX0d0lywsiMAku3aLVaEndSAMZ7/SDOdxfqQYHMt90VPxICFccxM1dvyDA7cS10=@passt.top X-Gm-Message-State: AOJu0YzQBV2uaB0L2be+0JkqizcTgk9U0QGkAU59YaMoE4fdkExn85Qn 4oV+O+OQS2p1GAOot8rmq93Gq5T/BqsfavrGbvc8OBW5OxUVXvhcydkRakSj8G5h4B7tDyYQLNB 965dVcQZdgTn+NXtXJURanrbQYor3OonDUo+0PUWbEqZBTbXcO+x4xg== X-Gm-Gg: AfdE7cnkIDUa2h6yO2YLD7bgAXLQXOZGLOdpEapGzlSlAcvPy45zoGkCf+1jPXc5bBY tBJV6SiXwpicLG9kgH6Biabd8THv13PwID5WjRxwsoJ5wmvvwyqzZV5WTy5Kh+pP6mzB3/vBkde 1YVwrx/OnNscXswgixv5HWGVyCbK5CN35bqp3u3i4u7Ei6471t+eBNVuza7YgfhkxHeXT36GHUC +wen7KiNzV/vAAEl1fYtK3dKk/p9S9tp68MFDF4erMTIr6aLW98oPLCH/o0nmD3X34odaRKSDky ctKYISs3+KOLpH6xVlpqU1FMntBZ7vE8ESGWPt/dImViYCCAYfW021hbOsDKW7CfiWECLxgKlk4 mi2dqhP2rTySKjxtppMcpEod5BJhAx7IfrX0MS1Y= X-Received: by 2002:a05:600c:3f0a:b0:492:4a50:41fe with SMTP id 5b1f17b1804b1-493d11f05a3mr40851185e9.22.1783178835665; Sat, 04 Jul 2026 08:27:15 -0700 (PDT) X-Received: by 2002:a05:600c:3f0a:b0:492:4a50:41fe with SMTP id 5b1f17b1804b1-493d11f05a3mr40850895e9.22.1783178835201; Sat, 04 Jul 2026 08:27:15 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce1947bsm135173695e9.14.2026.07.04.08.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 08:27:14 -0700 (PDT) From: Stefano Brivio To: Jan Palus Subject: Re: [PATCH 0/3] Fix broken build with -DNDEBUG Message-ID: <20260704172713.58d136b4@elisabeth> In-Reply-To: <20260516174643.6c0c5e24@elisabeth> References: <20260515041312.317644-1-david@gibson.dropbear.id.au> <20260516174643.6c0c5e24@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sat, 04 Jul 2026 17:27:13 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u00X195eXSHk3pjKQ3uXhrsKa_neDV01SfCHUW6LhJE_1783178836 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: TQJF24THHIMNTTLJ2LBU3P763JPOMBLZ X-Message-ID-Hash: TQJF24THHIMNTTLJ2LBU3P763JPOMBLZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 16 May 2026 17:46:43 +0200 Stefano Brivio wrote: > On Fri, 15 May 2026 14:13:09 +1000 > David Gibson wrote: > > > Fix the trivial but nasty with -DNDEBUG builds recently reported by > > Jan Palus. While we're there, add a couple of extra build tests. > > These wouldn't actually catch this problem, but they're better than > > nothing and do catch the #include problem I also spotted. > > > > David Gibson (3): > > test: Extend exeter build tests to cover more recent binaries > > Fix build with -DNDEBUG > > test: Add test for builds with -DNDEBUG > > Applied, with 2/3 amended as suggested by Jan. > > Jan, I'll let you know once I tag a new release so that you can drop > your no-assert.patch. Sorry Jan, I just realised I later forgot to do this as I tagged 2026_05_26.038c51e, but I see you figured it out anyway and already dropped the downstream patch. :) -- Stefano