From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GEZ1T/1x; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1B10E5A0265 for ; Thu, 16 Jul 2026 05:58:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784174319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SODp325+G37gMeBroSVcKwk61sKGtyZbH4/F/1uXP9o=; b=GEZ1T/1xf8zVvzMEKOb4zhoVvL2kuPy7h11klIXd+weBTUvqZFRAX4uYrgZmD8roCpPfPE qq8OvEnOkw/MwV4XYGHC0eNWtuK/EXFrxNN4clD05OxBcjsqSpWZsMgrFW4/+NfyfQ4vZH Qz0g6xztkU9Y/DORrn2JOmWRxBJMyww= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-b2GhFeCyPRehPOaR8-XQdQ-1; Wed, 15 Jul 2026 23:58:38 -0400 X-MC-Unique: b2GhFeCyPRehPOaR8-XQdQ-1 X-Mimecast-MFC-AGG-ID: b2GhFeCyPRehPOaR8-XQdQ_1784174317 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493bdaf8549so58100125e9.2 for ; Wed, 15 Jul 2026 20:58:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784174317; x=1784779117; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=SODp325+G37gMeBroSVcKwk61sKGtyZbH4/F/1uXP9o=; b=mhSZcejsAaKqo7kp0I/kUWgVnq3nK+nOp/sSJJmIaaqELknzYedGywNcbz6Pi/2rEe d7/7nVkEWvOMIzcAGHbe8ivGvbtBkW6IqK+n4jD12/kVBHKPqHx3stnQeb7semXBuRiC M+G7pENGJrZFNYwa5wWNzfLv8lvCEvq7a8QEV1srviCmMK0O7Mxxt5zQM7asRJ0+Obpe 4A/+PoH8V+0/h+X6qau4qYf51l0H+crVe3TP+crQvsJ94y9wG5ShpkPlaU9qHFQgI1AX PsT+JqLqj9zzMRIiYxIAParYYGNAC5km5KZ1kKjLPCUds5eE54C3YmqcQaCVdokn/BbO 6uXw== X-Forwarded-Encrypted: i=1; AHgh+Rqtw0SlSw0fGTam432Cz59IuTLBuLzXk0TbxJM84hVhUZNWiN8dawhm58j9tuvjUhz72FYvT0tVuIc=@passt.top X-Gm-Message-State: AOJu0Yw1xV6OGW5A6558JYywEDHV/yFJSs03oY8e78IM3iCFxdP1ZpVy jCpYoiEXtDjBVr154l3rsSDjfRY7OoWtdXETQ0wfR+U2mDzWGUrR2+hduU5UJiInYMqdI1jBGZ2 nx7rjoKtIwwFPqrundWETui2q6omq3GjpoV8Kd2UMIVTF95rLDwz8SQ== X-Gm-Gg: AfdE7cl0DmkTIeU5wZH7H5MKFB/q9obApXIMRWpnUGl+11qG0a2gCu6aljkziLE3+qb TaZxwUc3AVuaScewPz7GOC9qblCZJbZIg+Pd3ILi4VWpNgp24Kve6TDI3Hd2IRSOzTUtzMBaWhl Ke4BiZgBenEkQQ4GTPRvAtuYO3cZ031iSjPkCsm9RYDg2B0YXqT11CHqQvqAKxTi8g3gKZDNHG0 hhL1ia7nmEQfM/Z2rlnRo7L80ESZ6xzhwzOcEC9KMF8stn4GJ/zGsyCONX7/uQEpU7g8av6gwmK oMCnIBxCkfhk/C2yfNiwd4flpqaPk0Ewr0NkW/P3FqPwtKmo/89rOeAv/RvPDIRUrvKXmsB2b+Z KYvPT7mmJdVM= X-Received: by 2002:a05:600c:6386:b0:493:e79e:da63 with SMTP id 5b1f17b1804b1-4953c2908b2mr55620845e9.34.1784174317314; Wed, 15 Jul 2026 20:58:37 -0700 (PDT) X-Received: by 2002:a05:600c:6386:b0:493:e79e:da63 with SMTP id 5b1f17b1804b1-4953c2908b2mr55620705e9.34.1784174316853; Wed, 15 Jul 2026 20:58:36 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49541eb85dcsm27638925e9.12.2026.07.15.20.58.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 20:58:36 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v2 0/6] Fix issues and false positives from static analysis Message-ID: <20260716055833.4abe008a@elisabeth> In-Reply-To: <20260709215656.1351549-1-jmaloy@redhat.com> References: <20260709215656.1351549-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 16 Jul 2026 05:58:35 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EI5-JZsKhWsKkS8yeQ6gVMEQQXrP82QLMQISo2yBGbg_1784174317 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3T3H3MXGN7EWQYPO4DIDVDATUX4PMVVT X-Message-ID-Hash: 3T3H3MXGN7EWQYPO4DIDVDATUX4PMVVT X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 9 Jul 2026 17:56:50 -0400 Jon Maloy wrote: > This series fixes minor issues found by static analysis tools in the > main passt code and in documentation examples. > > The core code changes add missing fd initialisations and guard unsigned > arithmetic against potential underflow. > > We also fix buffer handling, type mismatches, and resource leaks in > the documentation example code. > > v2: - udp_vu, tap: Use if-guards instead of assert(), to handle the > error paths properly and let the static checker follow the logic > - doc/migration: Use snprintf() instead of strncpy() for clarity > and guaranteed null-termination (David Gibson) > - Drop va_list initialisation patch (Stefano Brivio, David Gibson) Applied up to 2/6. For the rest, I would rather wait for the discussion around 3/6 to come to an end, also because I guess patches 4/6 to 6/6 aren't that much of a priority. I haven't seen any other report of static checkers running on documentation examples and actually it doesn't make a lot of sense to me to do so. -- Stefano