From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hMuB4IuV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id A3D825A0269 for ; Thu, 16 Jul 2026 16:31:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784212301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aUaE1lKU1EKpCXlyzwLqcvJ3X6G/zNDn0Baoebc8Qwk=; b=hMuB4IuVRSFSxIKFkKZ6Wf3yuzv6P255BcgULJmeMiF1A747S8VmWljO/YatQw8i379+kX Wd0mRxOAU08WJv1HuJcsocLY0RUalURgWmP9fawyH4GWpldfpp9lQ13mr0agEdM3SH7lKf b8ZXqRa8cY8nmju0cFxDObnEa7SuFlE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-sHwe8JvvOc6l-g3-K1AyXQ-1; Thu, 16 Jul 2026 10:31:39 -0400 X-MC-Unique: sHwe8JvvOc6l-g3-K1AyXQ-1 X-Mimecast-MFC-AGG-ID: sHwe8JvvOc6l-g3-K1AyXQ_1784212299 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-473f4a48e9aso4589090f8f.2 for ; Thu, 16 Jul 2026 07:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784212298; x=1784817098; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=aUaE1lKU1EKpCXlyzwLqcvJ3X6G/zNDn0Baoebc8Qwk=; b=J8BSEgZoPb4Z94gB7FWzA5ZA6pblEr3uxBDZ6w5OqOpnRmAlxNnFTv9qJyKgtfdDAv 6paAgKIHxtHklcm2TJhILjfcluglB/seEM3JA1cv0tKi1Mldu/hVv3YKVm1/ShO+CTo/ jo1fBZLkjBYxXIEBiXald3FkN2AOhUT0Y4py2L+YN95NoGRdbO/J/m1JBTkGS4P148NC MdJ/cuRMP0nLHegNMHpnhRC3AXFaSCpBSfgkz8A5570C+RS16Go8mK22cKVKblshbeAa SbOzt8c3foAl20BjS5n0mSxPkZOQUfUYjWQUWZCYN/Ombue3XES92LO7FxDsNGrY/EGO 4gow== X-Gm-Message-State: AOJu0YzLsoJMVzGPdXbQ4unQSveY6t9rkrp6fkmJN9hl1evQmZ2keu+t ZVYRONglCOrQyBj2NxBKZnKhGsB1fP2GOWVRBsgvnw+nnlW1fUf0dJJC+s0EIQ2FsVZLjNwQUxC L2Ck57WnNt4b7TWHlaM79ttMgW88xM+nrB13w3OQNJyLt0oxWBTP8BQ== X-Gm-Gg: AfdE7clxasdHCJtjCooVh+RtTrvCx+utHQCKy4tkB+q7asetTRE5zlm9GHPgODUXz4G hR5xki4l4UYn3KqhkOifWy0FrGcD1Nm/7IHKOooDfx3lDIy2X0XTFrIiI1b/a/Am71f0WUQyOXw RKtT4IBYvX7C8c9xU2Sj+GAxxb2U4bl0s/81vnEXZloZTPsM6ZqyhkhQ3Klg+dt/UaIYt+OlE7e DHBhTUK/7+ZMSnM3QUfGyziAHV59iBVNN8UOvncYfdEVEIyv/nphWd5y4aeILgRzeJRkhOMuTyH 2EMyg3POUD/BeJMk1Vrsio19wR1sFZDRD/b58ieRBHqSZymdlZyf5wnwFQvrWW/3jFMDW09pjvv vOeZAl6yMzgX2iCH5RX3AVbg784RG X-Received: by 2002:a5d:5f07:0:b0:47f:25b1:e7b0 with SMTP id ffacd0b85a97d-47f488beb28mr13604543f8f.44.1784212298419; Thu, 16 Jul 2026 07:31:38 -0700 (PDT) X-Received: by 2002:a5d:5f07:0:b0:47f:25b1:e7b0 with SMTP id ffacd0b85a97d-47f488beb28mr13604429f8f.44.1784212297565; Thu, 16 Jul 2026 07:31:37 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464a973fsm26731296f8f.17.2026.07.16.07.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 07:31:37 -0700 (PDT) From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH v2 4/4] ndp: Use high quality entropy in NDP timer even if not needed Message-ID: <20260716163133.229afe23@elisabeth> In-Reply-To: <20260716072222.1819811-5-sbrivio@redhat.com> References: <20260716072222.1819811-1-sbrivio@redhat.com> <20260716072222.1819811-5-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 16 Jul 2026 16:31:36 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QxJHNGOpf0GbCFAYevqdIZU7R0tlEP0TWhZuHomOUGM_1784212299 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QU4I23QFPFBAIR3HAC62LM4D4D3GMRSM X-Message-ID-Hash: QU4I23QFPFBAIR3HAC62LM4D4D3GMRSM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Jul 2026 09:22:22 +0200 Stefano Brivio wrote: > ...instead of calling random(), to make static checkers happy. > > I don't think that an attacker could actually gain anything by making > router advertisement intervals predictable, but a doubt remains, and > this is cheap enough that we might just want to do this to get rid of > the noise from static checkers informing us that random() shouldn't be > used. > > Signed-off-by: Stefano Brivio > --- > v2: Turn random_part to uint32_t and cast to time_t before using it, to > avoid using negative values Oops, I guess I ran tests at 3/4 of this series but not on this patch, I'm not quite sure, but now I ran them again and realised that I've been here, done that, around the time of: https://archives.passt.top/passt-dev/20241113091805.6f6e2f6a@elisabeth/ just to find out that this would be the single usage of getrandom(2) at runtime, and we don't include it in the list of system calls we can use. Maybe Laurent tried this as well. Anyway, I guess it's not worth making things actually less secure just to satisfy Coverity Scan here, so I'll drop this patch. -- Stefano