From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FHWHNiuQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 7F7FC5A0265 for ; Fri, 17 Jul 2026 19:18:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784308709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8RNBP5vwO2sX1igqObxt5eY2zZZi2xmHPwTBwpcnmA=; b=FHWHNiuQegmYqceBfPF8NXcaZS0cLDbEflaTU1EsHeQe63ll9delXXjbPPEhH8Mder61B6 8g1p70iIzG9yiKNSu35jzy52CRMntlPNl73F2cJf9XMQOJ/3+ZviXcP+vKF2BL9KjpgqXF JstUVI3Ibsm19F3fPsCzP7L+xqkVJ0I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-24R55BQkP-6QtZd1_jq-sw-1; Fri, 17 Jul 2026 13:18:27 -0400 X-MC-Unique: 24R55BQkP-6QtZd1_jq-sw-1 X-Mimecast-MFC-AGG-ID: 24R55BQkP-6QtZd1_jq-sw_1784308707 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-493e94719e7so53882375e9.0 for ; Fri, 17 Jul 2026 10:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784308706; x=1784913506; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=M8RNBP5vwO2sX1igqObxt5eY2zZZi2xmHPwTBwpcnmA=; b=g8sLAjKo85mxxATXsptrB4gdtUh4tFD6IZoKwai3q1u87K+frisymYA/TGcz2zpFJb PXti6Sbd2JSaBu0HlWTdPPl5qla6N16B4pSw3/znZyQBG9dcCq6GrmSbCf5ApDkAUHbI c8JDcW07JNnUJmP/sZBZ09OKarEfc6zjb5MNBnfRdH4Hx3SOLg2VxR+ePmduE2NeldIt m1XNkBFEO3AKTfqo46HG2vAE5ap/t+xBasPsMWNXcCmYxcAzjWozWbO1tTYJfAUFQO6/ mGi5OVcqIH+bKDEOsSZo9F+BzZMX/+phw71jhqo7K4BiiTeVhY4a2RHSoMB49pHTvT85 SD2Q== X-Gm-Message-State: AOJu0YzZhDA5+DLuLB+gbSD7kqGSmbyPNTBF72ltOMw2uS8rOVs4MrHI 55B3Ww/zknVSZSDvv6amzstkds43UUNu00YfN35bkAHwEt3k3cOHAc5Q2wLCa49c7dG9AHgWwhs 5uwwBmrqt5K+QdwjfP0cgUFUqzbWiMr1iWXWp0zIfG0zGDgsyCdv8+i73mv87sA== X-Gm-Gg: AfdE7cnne07fBC31gJxQpkTL9darQiLvaFuWLkwNr+1JXYrtkNVfFNSA3AYpOF2TN5+ yUPlrq5jdqg+5oGicVhGovlv/xryW/qOnAif/atkPYfzbIeHVfosVZ9IsK23BNRAxvqWjE1/Q15 UMf6UN33m32y1dX1f148pVgu58QSn2i/6yuaEmAnrdJ5Y82Clb3R9o9/Pu08qdG77Dhqhqy4h+E VaLXtOMlaAHY1NEXFRdPEyLUPtOPbQ39ClF0A6imAZdEsQ/Szz26J3FIu3p4YpTqzHSvdUleLVp 6Y/XASAKG6loi6I6pn4gEQWcGpMIyx6lsCEmeECW/THOBWaUd+9OMyncOOu5UE0N8wRujQ4nMcm Bshv6WelUCZGbLEQwe7hG6XNhLd2x X-Received: by 2002:a05:600c:46d4:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-4954a3d64c9mr49950065e9.7.1784308706535; Fri, 17 Jul 2026 10:18:26 -0700 (PDT) X-Received: by 2002:a05:600c:46d4:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-4954a3d64c9mr49949625e9.7.1784308705971; Fri, 17 Jul 2026 10:18:25 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549c9c940sm64523085e9.13.2026.07.17.10.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 10:18:25 -0700 (PDT) From: Stefano Brivio To: Hayato Kiwata Subject: Re: [PATCH] tap: Fix EAGAIN/EWOULDBLOCK check in tap_pasta_input() Message-ID: <20260717191823.1e693a78@elisabeth> In-Reply-To: <20260716172121.80216-1-dev@haytok.jp> References: <20260716172121.80216-1-dev@haytok.jp> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 17 Jul 2026 19:18:24 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LxoXHku-7txU4T-IUy_l6QDZvEbUvX1roKHwPIjLrws_1784308707 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 4HCOMVKYRBTVNFWCWA5WLX45BRVFSVSO X-Message-ID-Hash: 4HCOMVKYRBTVNFWCWA5WLX45BRVFSVSO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Jul 2026 02:21:21 +0900 Hayato Kiwata wrote: > On Linux, EAGAIN and EWOULDBLOCK have the same value. Commit > d2a1dc744b10 ("tap: Restructure in tap_pasta_input()") added a check for > EWOULDBLOCK on purpose: > > > - Check for EWOULDBLOCK as well as EAGAIN for the benefit of any future > > ports where those might not have the same value > > However, the condition uses && instead of ||, so it can never be true on a > platform where EAGAIN and EWOULDBLOCK are different. > > Use || instead so that the check works as intended on such platforms. > > Fixes: d2a1dc744b10 ("tap: Restructure in tap_pasta_input()") > > Signed-off-by: Hayato Kiwata Applied. Thanks for fixing this, and welcome to the git log! -- Stefano