From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] pif: Add message to static_assert for C11 compliance, fix build with gcc 8
Date: Sat, 18 Jul 2026 09:41:34 +0200 [thread overview]
Message-ID: <20260718074134.1330908-1-sbrivio@redhat.com> (raw)
Seen with gcc 8.5:
---
In file included from passt.h:18,
from qrap.c:36:
pif.h: In function 'pif_type':
pif.h:48:44: error: expected ',' before ')' token
static_assert(sizeof("?") <= PIF_NAME_SIZE);
^
make: *** [Makefile:105: qrap] Error 1
---
As noted in ba84a3b17af8 ("treewide: Add messages to static_assert()
calls"), static_assert() calls need a message to comply with C11. The
form without message is supported starting from C23 only.
Fixes: cbcd4284111f ("pif: Limit pif names to 128 bytes")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
pif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pif.h b/pif.h
index 3a1e2e5..dedcaa5 100644
--- a/pif.h
+++ b/pif.h
@@ -45,7 +45,7 @@ static inline const char *pif_type(enum pif_type pt)
return pif_type_str[pt];
else
return "?";
- static_assert(sizeof("?") <= PIF_NAME_SIZE);
+ static_assert(sizeof("?") <= PIF_NAME_SIZE, "PIF_NAME_SIZE too small");
}
static inline const char *pif_name(uint8_t pif)
--
2.43.0
reply other threads:[~2026-07-18 7:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260718074134.1330908-1-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).