From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V40fNkTQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 77E5E5A0262 for ; Sun, 19 Jul 2026 17:08:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784473707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rq1yJ4RBeavht0hTRs2YSysZmD8UNlQWS01Gd5mDsb8=; b=V40fNkTQE9X3rjLvWAoVyuMI2thGr5FTFCTl17YHaR+2RRxf4DTU66Liv1/zaTn7UIHkw+ VwtCccwwS4xfyMuAnMPePwbNrBAPVf8Es50/ENZGjq6Isw0XU5b+lUoQFlAQbHQHEtONCo 91B7EymmREDMukfB01NQ+cZPf0lOmcA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-X1CQ8dZjPiOJd4Yqzr9Hdg-1; Sun, 19 Jul 2026 11:08:25 -0400 X-MC-Unique: X1CQ8dZjPiOJd4Yqzr9Hdg-1 X-Mimecast-MFC-AGG-ID: X1CQ8dZjPiOJd4Yqzr9Hdg_1784473704 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f7700ffdeso51209f8f.2 for ; Sun, 19 Jul 2026 08:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784473704; x=1785078504; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Rq1yJ4RBeavht0hTRs2YSysZmD8UNlQWS01Gd5mDsb8=; b=TdfHzSYExRtl7+kjORtCKGDlaQ01NW7TQY05jm405DardwOcpZQyNVuhJu4UCByTuW +3R7hFNu5m5LCD4ww6mbgm83YhP44Bp3W2bfdG45ioK4/QqsFS8ESGA9oP3sK2sTolUX lTHo1gAss1kUU+cf4uOJyCekhbEMkPRahTTH6X9ryBwK/tVLhhy2GYdJ/P1S2T7Em8Vj kRo5hnewioALzSd31CCZunChSLef46tMmSq+qz48RPAdT1cx+Ff3evEjeNUA7oVSgkx7 yZQtd3bfDFOql2/aGl8lju14syvJAmwSPyN9RfBuMLDd/p7VUnKUZIk2C41p3Q34FTVB r6lA== X-Gm-Message-State: AOJu0YweWv1MPVfzr1jHWQKIk4RfCQ9CFjhcBCotryyFtugJaID7sEBp AFDXd2ufuh8cktv+5OgPlNg3htYBmPxu1yXa/ewrhUpvy0ocTUzCtujZ1KzJyZpWJhNLuGlU/xn deKiqfhBx3diZdyNnD0hmhrulU/1LHM8rzIkH6jQ+QXAX/pPzwYP2Yw== X-Gm-Gg: AfdE7cnPG62PKW8dyozwgTBCBGadrsc/L0ztzV/BIn3PHACxolu0oDc/djty+JWvxLW vyYEQR/7ERQ/qlI31afYFR8CdemDzq2QmSFX6kfgavRfwqOPh+n5A6h3EWJXvKCEzXkj83B0nH6 gHcypMqthn/ewUfdjATI5qyT9ZyvvWRq9xO2xvTyhA+eJWjPDNlxFZJKUAUDLed3EkSMJAOasc3 a/aiRZPX82FOlayd/CJMgNcP7NJ12VhCzzK82X/I8wQDd2OrCbMhscJ8ucCRQmSUfr6dAjuWypU hVaUzPIeUDpff51G/RfQxanz6gVnTIjaAfHPWhZgNItYdqEcP63JtQUVp8CIBUqI9g5TRvwYPG4 ZsUypnMmD116OLXo14tmJhM5mJy3L X-Received: by 2002:a5d:5f95:0:b0:47a:1f6b:ddb8 with SMTP id ffacd0b85a97d-47f62328c70mr11588285f8f.39.1784473704191; Sun, 19 Jul 2026 08:08:24 -0700 (PDT) X-Received: by 2002:a5d:5f95:0:b0:47a:1f6b:ddb8 with SMTP id ffacd0b85a97d-47f62328c70mr11588249f8f.39.1784473703692; Sun, 19 Jul 2026 08:08:23 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63eea8afsm22546348f8f.33.2026.07.19.08.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 08:08:22 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/6] Fix bug 215 and some related issues with fd handling Message-ID: <20260719170819.6c9d307d@elisabeth> In-Reply-To: <20260717054634.1293553-1-david@gibson.dropbear.id.au> References: <20260717054634.1293553-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sun, 19 Jul 2026 17:08:22 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DqdRLiaEdofKTGGtMoscxhB_9_VUvnpuzcRtRxPsjvw_1784473704 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PRRFKHO7UCZIBYGWOPE7U4MWYUD6M445 X-Message-ID-Hash: PRRFKHO7UCZIBYGWOPE7U4MWYUD6M445 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Jul 2026 15:46:28 +1000 David Gibson wrote: > Stefano, you called it correctly. While working on bug 215, as usual, > I found a bunch of adjacent things to clean up. > > I did start by attempting the appoach you suggested for bug 215 - > remembering which of the low fds were standard streams and avoiding > closing them in __daemon(). It is indeed shorter, but only by 1-2 > lines. Looking at possible interactions with other things, I became > more and more convinced that leaving anything other than the standard > streams in fds 0-2 was an accident waiting to happen. Much of the > rest of the series is, for example, dealing with the possibility of > --fd [012]. > > v2: > * No longer fold fd closing into isolate_initial() > * Some minor polish > * Various improved comments and commit messages Applied. -- Stefano