From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MVE/9gad; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id DB4D35A0269 for ; Tue, 21 Jul 2026 18:07:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784650072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LLQYpuoL4WhqBxKo3pmcoJqClgplcDWyPjkn8itQz6g=; b=MVE/9gadKZWuMjs8yPIA9p8uTucxkhNX1UKqPDulO/HCo8Iw/sd4d/auM6cwwsjM3Hk4S7 9JRymOntui0zM6hpvoe8Xa/3OHi/1AfgdsGONUlF+xHPgrHYXB7qxDxWB3Mcp832/7Yb+O KC/+UZqqqUuvOQXPpw2PDvA588iRgnQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-DNeY7o76OqKnNum3sFHxOQ-1; Tue, 21 Jul 2026 12:07:51 -0400 X-MC-Unique: DNeY7o76OqKnNum3sFHxOQ-1 X-Mimecast-MFC-AGG-ID: DNeY7o76OqKnNum3sFHxOQ_1784650070 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49545755b03so43417385e9.0 for ; Tue, 21 Jul 2026 09:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784650070; x=1785254870; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LLQYpuoL4WhqBxKo3pmcoJqClgplcDWyPjkn8itQz6g=; b=kzLLE9A5LemW1aufV3+YnQDwc5Bz/dwNbrebDfAQf9jHo33TobRgpzlrJnkrSwKjmk +CuCznFdy9QOA/CV6atysoKKJibx4cbnhIvhR5200a6EKooynOh1T+omBJHq9fQ3l7dx WySm/WagIdPtWbOAlp3h6OzdkIdZTao/qviwqmg4Wi/Qc9nJg9GWcKS32Ixq8Qa+ctOu fQ3X4lhZIYjg4fGitLuh/DFsEyB6w87jo+dAyehBINwrxtNpinIDWx7xiI46ko1lKNW7 mH0390hh+qsVSdKl0BjHT/UeyAwzIpxucycQebYoayzgzWPAid+NKuQLOp34ZzW1WlpN jQcQ== X-Gm-Message-State: AOJu0YwFSbDR9n3Y1z/F0/JPjl/cWBZOilyeKs4g0MoXKvzVYWt8zks6 pmYizL7H6nu+nWArh+JABCAGhu/GY2ZTgP5F25xNCYo3RYgKOkUgjVQt4Yjt4fiDXc2NI/QXaN4 NE41O8KIR9NpZ7g2M64Pz/2g3tpWOruDuTvMQBiLO4/I3HQC3Soy0FS+bXikko2cii/xm1fuN1Z jMiphrmxBJ2Oprfj7ybraGr7r8jdoTYI3ngEsR X-Gm-Gg: AfdE7ckn/+y95bDFaE88VxHrOzTq9N7O3ermO4EQfEKe8EIGSiIlomjwkoh2sZFx70c WqYPY8YSqKTzFKPrwHSm6mTD3ixGXVVxeeZcIDuhR6CC3yaCfSUIZNLrPtPmGcjmWJj6n3YAJ3j HQPvPmGnf1ftKYWuXW4pt1U2fjKCWVNqcWU4K4FmVsTSXOJ2NngODUycpEmzknwDiI4+dybFhz8 RxPyDxeT47wdKZIauiVJjeuJ3QWJop0N/NtB/eYgEd4avjj/1mmOAv08WTY1KIzz0vGXt58HN+W OhaovWs0VckMPCv7WdDwJ3996So6asaGOz3rOtaVCV15N/nPPRJ8orhgUu0RPjcJBqgdEmYcWL+ qHtL+b9jIcpI= X-Received: by 2002:a05:600c:1d15:b0:493:f6e6:ce2a with SMTP id 5b1f17b1804b1-4954a3e720cmr225184715e9.2.1784650069801; Tue, 21 Jul 2026 09:07:49 -0700 (PDT) X-Received: by 2002:a05:600c:1d15:b0:493:f6e6:ce2a with SMTP id 5b1f17b1804b1-4954a3e720cmr225184035e9.2.1784650069197; Tue, 21 Jul 2026 09:07:49 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-495653c8760sm72341515e9.14.2026.07.21.09.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 09:07:48 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] udp, icmp: Remove unused timer_run fields from protocol contexts Message-ID: <20260721180747.4e7655ff@elisabeth> In-Reply-To: <85d9af6d-e875-4e2b-b003-0724a3ed09da@redhat.com> References: <20260619103006.1669522-1-lvivier@redhat.com> <85d9af6d-e875-4e2b-b003-0724a3ed09da@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 21 Jul 2026 18:07:48 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZWGDJcZQAmWkbVjvw_UBQ4R8Z25L0cDZc4ymbR19_F4_1784650070 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3L76L66VSZIR6ITPNXXP7W5VZIU3A2QL X-Message-ID-Hash: 3L76L66VSZIR6ITPNXXP7W5VZIU3A2QL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Jul 2026 09:25:50 +0200 Laurent Vivier wrote: > Ping? > > On 6/19/26 12:30, Laurent Vivier wrote: > > Since 260075bde769 ("tcp, udp, fwd: Run all port scanning from a > > single timer"), CALL_PROTO_HANDLER() is only used for TCP. UDP and > > ICMP timers now run from flow_defer_handler(), making the timer_run > > fields in struct udp_ctx and struct icmp_ctx dead stores. > > > > Remove the unused fields, drop struct icmp_ctx entirely (it has no > > remaining members), and stop initialising them in timer_init(). > > > > Signed-off-by: Laurent Vivier Applied, sorry for the delay. -- Stefano