public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: Ammar Yasser <aerosound161@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Paul Holzinger <pholzing@redhat.com>,
	Jan Rodak <jrodak@redhat.com>
Subject: [PATCH v2] passt.1: Clearer and more detailed description of --map-guest-addr
Date: Mon, 27 Jul 2026 14:09:46 +1000	[thread overview]
Message-ID: <20260727040946.105277-1-david@gibson.dropbear.id.au> (raw)

It's been pointed out in bug 132 and elsewhere that the man page's
description of the --map-guest-addr isn't very clear.  It's technically
correct, but hard to follow.

In my defense as its author, this is largely because the problem the option
is addressing is itself quite subtle and hard to explain.  In particular
while it's usually about host <-> guest communication, it may not be if
-a is also used, and the semantics need to accomodate that.

Anyway, here's an attempt to make clearer what it does - and why it more or
less has to work that way.

Reviews on clarity most welcome - I've had my head in the forwarding and
address translation for the better part of a year, so it's natural that
I've somewhat lost sight of what is and isn't obvious to someone coming
fresh.

Cc: Paul Holzinger <pholzing@redhat.com>
Cc: Jan Rodak <jrodak@redhat.com>
Link: https://bugs.passt.top/show_bug.cgi?id=132
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 passt.1 | 39 +++++++++++++++++++++++++++------------
 1 file changed, 27 insertions(+), 12 deletions(-)

diff --git a/passt.1 b/passt.1
index 995590a6..f326f82c 100644
--- a/passt.1
+++ b/passt.1
@@ -405,18 +405,33 @@ sandboxing process fails.
 
 .TP
 .BR \-\-map-guest-addr " " \fIaddr
-Translate \fIaddr\fR in the guest to be equal to the guest's assigned
-address on the host.  That is, packets from the guest to \fIaddr\fR
-will be redirected to the address assigned to the guest with \fB-a\fR,
-or by default the host's global address.  This allows the guest to
-access services available on the host's global address, even though its
-own address shadows that of the host.
-
-If \fIaddr\fR is 'none', no address is mapped.  Only one IPv4 and one
-IPv6 address can be translated, and if the option is specified
-multiple times, the last one for each address type takes effect.
-
-By default, mapping happens as described for the \-\-map-host-loopback option.
+Redirect outbound traffic to \fIaddr\fR to whatever node on the host
+network has the same address as the guest.  Rewrite inbound traffic
+from that node so it appears to the guest to have come from \fIaddr\fR
+instead.
+
+By default, the guest or namespace is given one of the host's public
+addresses.  While this avoids NAT in most cases, it means the guest
+cannot communicate with the host using that address.
+\fB--map-guest-addr\fR allows the guest to communicate with the host
+via \fIaddr\fR instead.
+
+Note, however, that if \fB-a ADDR\fR is used, where \fBADDR\fR is not
+one of the host's addresses, then \fB--map-guest-addr\fR will redirect
+traffic to \fIaddr\fR to the host visible node with address
+\fBADDR\fR, instead of the host itself.
+
+Only one IPv4 and one IPv6 address can be translated, and if the
+option is specified multiple times, the last one for each address
+family takes effect.  \fB--map-guest-addr none\fR means no such
+translation is performed for IPv4 or IPv6; this will usually make it
+impossible for the guest to communicate with the host (at least using
+direct IP).
+
+By default \fB--map-guest-addr GATEWAY\fR is implied, where
+\fBGATEWAY\fR is the guest's default gateway address, unless
+\fB--no-map-gw\fR is also specified, in which case \fB--map-guest-addr
+none\fR is implied.
 
 .TP
 .BR \-4 ", " \-\-ipv4-only
-- 
2.55.0


             reply	other threads:[~2026-07-27  4:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  4:09 David Gibson [this message]
2026-07-27 14:48 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727040946.105277-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=aerosound161@gmail.com \
    --cc=jrodak@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).