From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LISdQwv4; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C39865A0265 for ; Thu, 06 Aug 2026 23:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786053264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlnbS/Zb2KgDp0QK4k4c2cCnWVeS76wcp/QNe+66FDY=; b=LISdQwv4o2kovWToAqbUhDxPpZBDxHFCUnjpqVeFxCA3gVpWN+cQbGo6TdbCzs43DmDWDF /BLUiOpMMS7s2ea0LC8fGMWetMCFWcjQhkVHok5taLgYHO5oJ9GjMZaSxwQo7CCqfbr/Qn MCPrZooyAs95NgPkTwVQ+VWlGNTxLmw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-Vplx5BLoOaCgUx-3ib9AxA-1; Thu, 06 Aug 2026 17:54:23 -0400 X-MC-Unique: Vplx5BLoOaCgUx-3ib9AxA-1 X-Mimecast-MFC-AGG-ID: Vplx5BLoOaCgUx-3ib9AxA_1786053262 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493a7fa8481so9296955e9.1 for ; Thu, 06 Aug 2026 14:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786053262; x=1786658062; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=rlnbS/Zb2KgDp0QK4k4c2cCnWVeS76wcp/QNe+66FDY=; b=XzmDQR9d/rasqZ49WxJD4Eqr9IBhxRXAdbBfrhDnPIAXA7TZAJFiAF4gkHkWUQwTm4 VtnRuCNEkICCqcWqTw2OyaVTigToJeczveR5u+AMEQ3nU7/6DD70O1OogC1STaUv5WEY 6Fe2+QJvKoZfChjT9vj0yFSWRintjWD0PQfEb/iRDF4fZyGBkPm0cpNh6IbAyTj+6mO4 oHQg36Dz4XmzxB0e0062H3FBFMwWuC1VaCiG1l5WLF86+TpbjcoMpaY+QJxFA6lc7SUz WuhB+9i948z5GeVJ4Nes8wIosR1Gb6r3qMZt6nfB8zqysB14RLdbIwiPtG3sjwZ2NutG aeSA== X-Gm-Message-State: AOJu0Yzv4n37BbZZZH58+cO30OzGft25MV3VnWVvIHsFeWPjLfYxce5J Fz5BzaE/ZHdcv+usO5kJkbbedWtlMGIFVtLutGuR1qNYSGFyqPos6jbmzlLtKXbFgNy0C3Ykn5b 4xSKU80rO0vA+ZFJNjBdODMb62XsT4Ny+lJnQHYr4rPVV0VCT6LvP9g== X-Gm-Gg: AR+sD10g3rrC4lZZwf+KxUJ4TSemL+7kGpbgBpbkhKxOLRk1C7dDkmtTepB0ZsXW7oR 6CaEV2++CGxxK/h7PDEYNK9EPIRcHcX9tNzkAiFo3+mOzVnFDXM0K47ckrIlnGa8XtOH04Dz2Sz JUxyNBJSbWMrQi/4Ljl/rKHyIBOmDtMq6AhsY4nIOESnMo09N5jYwezF6Sgx3O/9bWjBkcOxvAL aCTeuhl1JWMcoH3f3mUl29sAkd8LxrLMfoumONObAHej/PE2k/8dhpImYc9k9bRN4LMDkqyPXdq ooJlSkV79IYp6xoa8+DrXricoLd/3QsVGM0E8vVm7An4Vo/RQ/2OZmSnYlzzcsqcm5YrrEhxxYW 9LMIsuGb8pTagKv6rhftkwRq0XUdU X-Received: by 2002:a05:6000:4014:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47ff86e0e45mr10603969f8f.14.1786053261941; Thu, 06 Aug 2026 14:54:21 -0700 (PDT) X-Received: by 2002:a05:6000:4014:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47ff86e0e45mr10603939f8f.14.1786053261460; Thu, 06 Aug 2026 14:54:21 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b183b2sm10217140f8f.24.2026.08.06.14.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 14:54:20 -0700 (PDT) From: Stefano Brivio To: Huang Jing Subject: Re: Patch for the close_range() musl build failure Message-ID: <20260806235419.722b0a71@elisabeth> In-Reply-To: <878q6jjvww.wl-rne.kou@icloud.com> References: <878q6jjvww.wl-rne.kou@icloud.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 06 Aug 2026 23:54:20 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mrPaF-4M9iFMwlteDyC5Ho7jQ2rPVl-8HWkzu86atvE_1786053262 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IFEQWKHV4LGU65LYTA7ENPRC4SOMNXZS X-Message-ID-Hash: IFEQWKHV4LGU65LYTA7ENPRC4SOMNXZS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Huang Jing, Thanks for investigating and fixing this! A few notes, inline, below. They are all formal and trivial so I can fix up all of them on merge if you agree (but you can also choose to re-send as v2 with those fixed, let me know, in case). I'm pointing those out especially for the future, should you happen to contribute again to this project or projects following a similar workflow. On Thu, 06 Aug 2026 20:06:07 +0800 Huang Jing wrote: > >From 25831e518c9227a31b75f2c1eb2e620fd4c5d049 Mon Sep 17 00:00:00 2001 We follow essentially the same contribution process as the Linux kernel, see also CONTRIBUTING.md and: https://www.kernel.org/doc/html/next/process/submitting-patches.html ...so we don't send them patches as attachments, they're simply in the email body, just like git send-email sends them. > From: RadioNoiseE > Date: Thu, 6 Aug 2026 19:58:45 +0800 > Subject: [PATCH] isolation: Include linux_dep.h for close_range() > > Now that close_open_files() has been moved, linux_dep.h can be safely Stated like this, it looks like a more detailed description of the patch, compared to the title. It's something you're adding to it instead. To avoid confusion about what the patch does (most importantly, what's in the title), I'd suggest to phrase it like: ...and now that close_open_files() ... > removed from util.c. > Here we need a couple of tags to provide some context (which might be important when looking at this later), that is: Link: https://github.com/gentoo/gentoo/pull/46644 Fixes: 0a510066e916 ("isolation: Move close_open_files() to isolate_fds()") and, while at it, it's a good practice to Cc: the author of the change that's being fixed up (I just did). > Signed-off-by: Jing Huang > > --- > Makefile | 4 ++-- > isolation.c | 1 + > util.c | 1 - > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 77474d6..b315242 100644 > --- a/Makefile > +++ b/Makefile > @@ -48,8 +48,8 @@ MANPAGES = passt.1 pasta.1 pesto.1 passt-repair.1 > > PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ > epoll_ctl.h flow.h fwd.h fwd_rule.h flow_table.h icmp.h icmp_flow.h \ > - inany.h iov.h ip.h isolation.h lineread.h log.h migrate.h ndp.h \ > - netlink.h packet.h parse.h passt.h pasta.h pcap.h pif.h repair.h \ > + inany.h iov.h ip.h isolation.h lineread.h linux_dep.h log.h migrate.h \ > + ndp.h netlink.h packet.h parse.h passt.h pasta.h pcap.h pif.h repair.h \ > serialise.h siphash.h tap.h tcp.h tcp_buf.h tcp_conn.h tcp_internal.h \ > tcp_splice.h tcp_vu.h udp.h udp_flow.h udp_internal.h udp_vu.h util.h \ > vhost_user.h virtio.h vu_common.h > diff --git a/isolation.c b/isolation.c > index 94cbe7f..a30b329 100644 > --- a/isolation.c > +++ b/isolation.c > @@ -89,6 +89,7 @@ > #include > > #include "util.h" > +#include "linux_dep.h" > #include "seccomp.h" > #include "passt.h" > #include "log.h" > diff --git a/util.c b/util.c > index bd4c6ca..28c32e4 100644 > --- a/util.c > +++ b/util.c > @@ -27,7 +27,6 @@ > #include > #include > > -#include "linux_dep.h" > #include "util.h" > #include "iov.h" > #include "passt.h" The patch itself looks good to me. -- Stefano