From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Ammar Yasser <aerosound161@gmail.com>,
Anshu Kumari <anskuma@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] udp_flow: Remove obsolete comment
Date: Tue, 18 Aug 2026 14:35:13 +1000 [thread overview]
Message-ID: <20260818043513.951488-1-david@gibson.dropbear.id.au> (raw)
This comment was true - although the upshot was not particularly clear -
when it was introduced. However, for other reaosns we now *do* always
populate ini->oaddr from flow_initiate_sa(). So rather than explaning
why we can't, we can actually validate ini->oaddr.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
udp_flow.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/udp_flow.c b/udp_flow.c
index f59649f6..a29f3562 100644
--- a/udp_flow.c
+++ b/udp_flow.c
@@ -247,11 +247,8 @@ flow_sidx_t udp_flow_from_sock(const struct ctx *c, uint8_t pif,
ini = flow_initiate_sa(flow, pif, s_in, dst, port);
if (!inany_is_unicast(&ini->eaddr) ||
+ inany_is_unspecified(&ini->oaddr) ||
ini->eport == 0 || ini->oport == 0) {
- /* In principle ini->oddr also must be specified, but when we've
- * been initiated from a socket bound to 0.0.0.0 or ::, we don't
- * know our address, so we have to leave it unpopulated.
- */
flow_err_ratelimit(flow, now,
"Invalid endpoint on UDP recvfrom()");
flow_alloc_cancel(flow);
--
2.55.0
reply other threads:[~2026-08-18 4:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818043513.951488-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aerosound161@gmail.com \
--cc=anskuma@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).