public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Hayato Kiwata <dev@haytok.jp>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] netlink: Don't warn about multiple interfaces when there's only one
Date: Tue, 01 Sep 2026 20:15:34 +0200 (CEST)	[thread overview]
Message-ID: <20260901201533.2c69b123@elisabeth> (raw)
In-Reply-To: <20260822084856.3981-1-dev@haytok.jp>

On Sat, 22 Aug 2026 17:48:56 +0900
Hayato Kiwata <dev@haytok.jp> wrote:

> Suppose there is a single network interface on the host, with two
> addresses of different prefixes assigned to it.
> 
> In this situation, running pasta to create an isolated netns prints
> "Multiple interfaces with %s routes, picked first", even though there
> is in fact only one candidate interface.
> 
> Reproducer:
> 
>   sudo ip link add dummy42 type dummy
>   sudo ip link set dev dummy42 up
>   sudo ip addr add fdaa:aaaa:aaaa::1/64 dev dummy42
>   sudo ip addr add fdbb:bbbb:bbbb::1/64 dev dummy42
> 
>   pasta --config-net -- true
> 
> This message is meant to indicate that there are multiple candidate
> interfaces, but in fact there is only one, which can mislead users.
> 
> Therefore, avoid printing this message when there are multiple non-default
> routes that all belong to the same interface.
> 
> Fixes: 450a6131beab ("netlink: With no default route, pick the first interface with a route")
> Signed-off-by: Hayato Kiwata <dev@haytok.jp>

Applied, thanks, and sorry for the delay!

-- 
Stefano


      reply	other threads:[~2026-09-01 18:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22  6:49 Hayato Kiwata
2026-09-01 18:15 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901201533.2c69b123@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=dev@haytok.jp \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).