From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] vhost_user: Reset vq enable flag in vu_cleanup()
Date: Thu, 3 Sep 2026 13:16:00 +0200 [thread overview]
Message-ID: <20260903111600.3837753-1-lvivier@redhat.com> (raw)
vu_cleanup() resets most virtqueue state (started, notification,
file descriptors) but does not reset the enable flag. After a
QEMU disconnect and reconnect, the stale enable flag causes
vu_set_vring_enable_exec() to hit its early return check
(vq->enable == enable).
Reset vq->enable to false in vu_cleanup() alongside the other
virtqueue state.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
vhost_user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vhost_user.c b/vhost_user.c
index a1259c2624c0..272295f29db4 100644
--- a/vhost_user.c
+++ b/vhost_user.c
@@ -1081,6 +1081,7 @@ void vu_cleanup(struct vu_dev *vdev)
struct vu_virtq *vq = &vdev->vq[i];
vq->started = false;
+ vq->enable = false;
vq->notification = true;
if (vq->call_fd != -1) {
--
2.55.0
reply other threads:[~2026-09-03 11:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903111600.3837753-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).