From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RVOC+Mkh; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 4EB4D5A0272 for ; Tue, 08 Sep 2026 17:01:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788879715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tAZyjDA+F/k2hrH8DznBiQzwetYOEpkz0x2Vo6Q30cs=; b=RVOC+MkhZnfdG8FY3qJ62biaS+j2QN4/KhrNH5FTy+SPA1TXWV4otLKUdoVMucwn8PjMJJ zcud393QW3IkVRE8aGPlWMKAfqVjaJVcPwRwGUc4Ftus3JzlroJ8ZTl8Drx17tnuAkzQnK YWl7yT1SR8b8q7IQPAFJpI7u7rq5EnM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-z1ytrqHsOGufDFEsqJCPAA-1; Tue, 08 Sep 2026 11:01:53 -0400 X-MC-Unique: z1ytrqHsOGufDFEsqJCPAA-1 X-Mimecast-MFC-AGG-ID: z1ytrqHsOGufDFEsqJCPAA_1788879712 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49b0e6638e3so36247755e9.2 for ; Tue, 08 Sep 2026 08:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879712; x=1789484512; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tAZyjDA+F/k2hrH8DznBiQzwetYOEpkz0x2Vo6Q30cs=; b=d9sHSj7WnOKWjqWl66/Z/oylEh33oA1gf9jyFAtNzIhI0kZz5ZsYVbGgYxLHBk0RzM K5D82qcqiRZVIrdDc5rfQg9s0FfP4wVzrCTgM7qc4441KA+0Gu5GR91HBveZaFbOv8Wb EriwmbYjfj0NV/TOYWEpR1agIgAUaAB7jWhOSRdNgI8tqm3YljWcSuxfvcBaJ7pKETQR Jt7oNFMne+VxTdfMtVpNDOJLUaJAv4wD5s1LFbEVZL2adw5NEgNaBMnUhjgXtKNWCeBd qOT3sKtC1rAB4/MvAfAEk8IUxJ9QEqGQT+GNSidvxuTXxKiQ5Z+QBSX6zbXoRly35Zoh pCTQ== X-Gm-Message-State: AFuF++njxVDDtI8mCSiYd0uIm1K335zzDq8ZSx3/rw2pgS4xqCfalKs3 a1NJkZP2gkmRkDte+y0tMDCpGPMz2NnRaiK0Hu/NYVT6BGQCljhj/5wwZ0N/r5wg3n7M0yssEnb aiGW/czEpmk1SlFm0go8aDuT0zy0J7DgQPGk2CY9W1/S2sH4d7lvGGw== X-Gm-Gg: AYBFou1/V0iyd0m4Lf7NHHzDeHn9/nKI9GegrGsoI8YY7jUDpvqj1Q9sSDAiFWwS5dC xO8Bth5uTKUfmi6Q+P9DodMYQyd2RW6oKF70FQl0zJbLNCmDuU4NO+67pcRkoP6gebgEWRnSJdk Z+nJ5XRHB71DDjLq//mxgGg5BPFawB5BNnkiQgkOKyIZSNFfcujylZuupvpQIXH1gVlbtlxOuwP xEmug3QzxtgyqOS7vBuUyCr2BJX1vGNE/jtkvzd5Dz2UN8pF2jy+kq/s818UpRVbeIDkbQYcUvw O9e0xI+/wZ2YfLEODKR7nE5zEQUP7z54kAwtkSQ3ESdwXzObhri5RRU81SyR6CcjeNy98Ob5SzT lalXTbVMInkw= X-Received: by 2002:a05:600c:474c:b0:49c:f4e1:4c2d with SMTP id 5b1f17b1804b1-49cf828cd70mr274651335e9.16.1788879712324; Tue, 08 Sep 2026 08:01:52 -0700 (PDT) X-Received: by 2002:a05:600c:474c:b0:49c:f4e1:4c2d with SMTP id 5b1f17b1804b1-49cf828cd70mr274650685e9.16.1788879711758; Tue, 08 Sep 2026 08:01:51 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d0656e7bbsm294176285e9.10.2026.09.08.08.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 08:01:49 -0700 (PDT) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] udp_flow: Remove obsolete comment Message-ID: <20260908170148.75dd1dd8@elisabeth> In-Reply-To: <20260818043513.951488-1-david@gibson.dropbear.id.au> References: <20260818043513.951488-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 08 Sep 2026 17:01:49 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JEJ1ViME-Z6yKLIJ2V4ljuAgzIzS367azvlhAWy0JWg_1788879712 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: M4XR76A2RFL4FDWALMISIIH7WPZYDNPN X-Message-ID-Hash: M4XR76A2RFL4FDWALMISIIH7WPZYDNPN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Ammar Yasser , Anshu Kumari X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 18 Aug 2026 14:35:13 +1000 David Gibson wrote: > This comment was true - although the upshot was not particularly clear - > when it was introduced. However, for other reaosns we now *do* always > populate ini->oaddr from flow_initiate_sa(). So rather than explaning > why we can't, we can actually validate ini->oaddr. > > Signed-off-by: David Gibson > --- > udp_flow.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied. -- Stefano