From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K1tWOLPm; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id BD2485A0265 for ; Tue, 08 Sep 2026 17:02:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788879727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWNO4u77YyCRNu9RrkKaOcIaemy4HzqeJW5Ociz7Xpo=; b=K1tWOLPmHpKxWHpl2omKMb63hmdxE2OI1bwgdmQOEIG4x90TZX1JL4F+/bKslPl3ZuHYWk 1TWu3hZbodwX/DWr9mCxT4aYqZ0clf6Zez9ysW/zQ178wqeIsJJQkeJn5SEHyTww7H2X0L r25Rsp0Qw5RvfW3Vrylq7E0oklHP6bo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-vbEz0frmNbaXYLpVxM-24g-1; Tue, 08 Sep 2026 11:02:06 -0400 X-MC-Unique: vbEz0frmNbaXYLpVxM-24g-1 X-Mimecast-MFC-AGG-ID: vbEz0frmNbaXYLpVxM-24g_1788879725 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49d156c917cso12391695e9.1 for ; Tue, 08 Sep 2026 08:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879725; x=1789484525; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gWNO4u77YyCRNu9RrkKaOcIaemy4HzqeJW5Ociz7Xpo=; b=MPFTtC1iBifxk5/GbtQMxqya2BTGOUx6wSqGKOLRjONYpj/vvXBp+/dTTL73wtZEVr ybpECFcHnPDVC3BC4rysz4lzLo+H5ND9vw+WEGDqvRhk+UbMFDtreACAXyIo8N06P9yK lEBoWL0JoI87SyONuCHZhUrLEBWyXpYinz4DnT5VM22Ei+Lb9RWeNJe4+7muZbEC7y4y BYTh1o45tzcJxOyZqYLlRHyRHcjVAc4z0YfYeY624y2Ed2nlNev83Mm6PiqmT+KKCZ9J bUHWgMH40LhzCeF3FN1e1ZPUL4HmQEjJJPWSUB7cb8cmEZvdlt91Bsz4O3eBTmx579on a1HQ== X-Gm-Message-State: AFuF++lyUturwcZPkezZWe1LX2VS5bLsVYTevdOWKAGobU55PwZmH0Gq nV8HcEJ+TfpwUg3jyY+YeHGfaZ4wyJr9mJ9KMcgbwhUHARmL6x1QBXO6OMVos83QHVQIHOoDbD1 8Sew3YgwOq5yYZtzb7GNuEtdAfoAQr9n/TQjFUf/jsQkqp6q6TvDxQQ== X-Gm-Gg: AYBFou0GbQQVuO4Fstu9Hfz5jwrVOHna9YNtJ7jTtsFeQcalPuRKuWv3gQvlD8oK6pn 3l9gwFqLFcwM7/UwNBDozaUa7+hmfqfv0kUlGW4uzDSTqv2ubCul7dNAffKyaxjvCYRRqK+G8bF Xb8raGil7c9cw/tNszGkKPF7fqaIR9nQRm+hwbWI1vynfP+V3qaZmVYpmFymgTdDXeiQhHyQHeU XlPSltuxIcJQzmqpwEv8As0uPGNWt5cYu+MoWSYSUv4QWmwobfhANwgJ6g6LRzwhPVgfSoWjuth EkkORApQkA+EsVByjt0SElo00Z1zA0CrNsjPHKBdZiDqG8qI0xe5TxJxnhrrKhtqnId284HnwXS TKv1+R2efWqw= X-Received: by 2002:a05:600c:3513:b0:49c:ee3b:723d with SMTP id 5b1f17b1804b1-49d1e07e622mr19724075e9.0.1788879724454; Tue, 08 Sep 2026 08:02:04 -0700 (PDT) X-Received: by 2002:a05:600c:3513:b0:49c:ee3b:723d with SMTP id 5b1f17b1804b1-49d1e07e622mr19723455e9.0.1788879723934; Tue, 08 Sep 2026 08:02:03 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee60bae6sm574185165e9.9.2026.09.08.08.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 08:02:03 -0700 (PDT) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] vhost_user: Reset vq enable flag in vu_cleanup() Message-ID: <20260908170201.33165fb6@elisabeth> In-Reply-To: <20260903111600.3837753-1-lvivier@redhat.com> References: <20260903111600.3837753-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 08 Sep 2026 17:02:02 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C0FiTeyFzv1eCSIpK3sOLJZ9RyJE5F8gqlAZaD5vTkQ_1788879725 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7SWPCO2KFZB66GYD5ODDSYQ3DJFBUJAN X-Message-ID-Hash: 7SWPCO2KFZB66GYD5ODDSYQ3DJFBUJAN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 3 Sep 2026 13:16:00 +0200 Laurent Vivier wrote: > vu_cleanup() resets most virtqueue state (started, notification, > file descriptors) but does not reset the enable flag. After a > QEMU disconnect and reconnect, the stale enable flag causes > vu_set_vring_enable_exec() to hit its early return check > (vq->enable == enable). > > Reset vq->enable to false in vu_cleanup() alongside the other > virtqueue state. > > Signed-off-by: Laurent Vivier > Reviewed-by: David Gibson Applied. -- Stefano