From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UDVpElE2; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id DC6565A0265 for ; Mon, 21 Sep 2026 21:57:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790020663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sEB8+MXFtQUwbkDkRARqh5s6zDyCYKxebatAT8nq598=; b=UDVpElE2EcfQPDWvzUGwtm+PmamOrldB6henfXvDMZckRqiC+Tyk/tPC00fcS2zy89miyi q9a8f2FzNFJU5f/ZuXkDlzFjiW1tRvdQLwIao7zscy90OEemM+nlRlqVpzSAfYG4l84dRB luCk0R7YEdUS3PoR/5MywNHmtfiPWOc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-xw9U2GKvOAOE-kjPV9T0Jw-1; Mon, 21 Sep 2026 15:57:42 -0400 X-MC-Unique: xw9U2GKvOAOE-kjPV9T0Jw-1 X-Mimecast-MFC-AGG-ID: xw9U2GKvOAOE-kjPV9T0Jw_1790020661 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49cf5bd2f12so45421355e9.1 for ; Mon, 21 Sep 2026 12:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790020661; x=1790625461; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=sEB8+MXFtQUwbkDkRARqh5s6zDyCYKxebatAT8nq598=; b=E2hvtlw8Gg/aAa2RHjmlE6VEcrg+JNWKUur1dk+wuRyu22Fb8jZX5gJtFpXy9zjEAM AiH9nJBZtYnOvW4X+Z0LV5fzG2AmQtaanDO9iVsO6ECT3CGBLCl/aQSMkKHj1mVt3Qnm vVAYLOlFui98uFueVHb0A7JocDWRPNe78KZVH4t3Amkn7QvoT/DUiRNhC6DaXisc907x P0SzNj3BTuGI2c/FGKMzgtGbgPpsIfDEsU89b/XXEtgcw7aehO/hd5Oh4WFni8jFHfZT TZgswhxm/PXKkVAwjfrTXTtX1XhQnkREPfjvJjbMvlSNA3EWBRA2QWAPEcwmRQ8MaF/1 yLFw== X-Forwarded-Encrypted: i=1; AKwUvBwHshQLhk1JA8g7B7gxcyCQDkpGrLaeDsknHh9Fr0b5g4f7wz0GQeSlWCIkrdYELl3zSHW6SfGfIYg=@passt.top X-Gm-Message-State: AFuF++kQY9V/6eg2Ao/6QJa4Ln3Gn5sosyTyjgoxbOJhP9aemxfvplGW zL4DdZE7R7b7cMaFZBQznSaWz7mJripKfD1aEtZjVG8Y2MrOFn5snjN1TpjfaDcQc7X9vhGZdOo YJrxrAGhZVmMMKP8CvH1cCni1Y29uuy6qz+a+OmFioPMTdup1hkZPTyIElype1Q== X-Gm-Gg: AYBFou3eL6wROptpHwNRAqA6hlyX/jo2+BSv0gWaVFMN1B3EO1tmNzIHzzBNRFikuxA fG1cml9SckUnm20IW3edUjtFLzwS8dBKesyytudqhPo/ys86/hcO42yx6tATB9AGpVBXXSbwGIR l1RNwYETCaD/F+kC82teeoXG3+erc/PxMzCTDy3NoPasfppqN+jR1nkh6EHZcnswwfYFfugvym2 R8gsazb32ATFYXWgD687ChfgOXZcd9r3ePYIFC0rgxeJq0Kk9vTr9JrfpOslaZltI0IMdhCYzDU lxvUraGAISVoUpBEjb++Sx/ZcoSuEJhM89OauBlui+tii1d3VUu9Gz51uehHnhFGZYhKjFBJA+O yEe1UMGkZYg== X-Received: by 2002:a05:600c:a085:b0:49d:25b0:cc60 with SMTP id 5b1f17b1804b1-49fc5747f7bmr178865675e9.29.1790020660936; Mon, 21 Sep 2026 12:57:40 -0700 (PDT) X-Received: by 2002:a05:600c:a085:b0:49d:25b0:cc60 with SMTP id 5b1f17b1804b1-49fc5747f7bmr178865375e9.29.1790020660515; Mon, 21 Sep 2026 12:57:40 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fd8ccd185sm16305195e9.8.2026.09.21.12.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 12:57:39 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v10] pasta: Refactor pasta_ns_conf() to reduce nesting Message-ID: <20260921215738.70905447@elisabeth> In-Reply-To: <20260918174946.2366810-1-jmaloy@redhat.com> References: <20260918174946.2366810-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 21 Sep 2026 21:57:39 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HQmP7nwl-lQN-ma5s6nxV3tYWNJKTRUsU8umkE-fNQY_1790020661 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VATAM4YHUUB4EXGAT4KNQTST6NKRUNX4 X-Message-ID-Hash: VATAM4YHUUB4EXGAT4KNQTST6NKRUNX4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 18 Sep 2026 13:49:46 -0400 Jon Maloy wrote: > Extract address and route configuration into two new helper functions > pasta_conf_addrs() and pasta_conf_routes(), and replace the outer > if (c->pasta_conf_ns) block with an early return. This reduces > indentation and eliminates the goto labels. > > No functional change. > > Signed-off-by: Jon Maloy > Reviewed-by: David Gibson Uh-oh, wait a moment. The clang-tidy test reminded me that I already reviewed this two months ago: https://archives.passt.top/passt-dev/20260715091124.410d2ed6@elisabeth/ This v10 seems to be the same (minus rebase) as the v10 I already commented on. -- Stefano