From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ajVkpMaO; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2B6EE5A0265 for ; Tue, 06 Oct 2026 21:04:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791313489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYUzACrVdECBSeZQAcriGiunitDTzEQee6CxS0wsaKs=; b=ajVkpMaOLVGoWdRYRY3nZCCjpDrEUi/lR0N2gfbPbw/8tplxuabUK+u6PEuhzQJCiXBkIy LKNrQKiDK56ceoCPUjPUdWUFtLGRtE/CIMa07w8yzbs81p0fy5BOhfmiQD1RAthRYHws++ J6nuWUaJU8L3OLF5PasEsfK3VOmao6k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-8rboQEl3NSWZOcISamZPJw-1; Tue, 06 Oct 2026 15:04:48 -0400 X-MC-Unique: 8rboQEl3NSWZOcISamZPJw-1 X-Mimecast-MFC-AGG-ID: 8rboQEl3NSWZOcISamZPJw_1791313487 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48c69bdeaacso922912f8f.0 for ; Tue, 06 Oct 2026 12:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791313487; x=1791918287; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XYUzACrVdECBSeZQAcriGiunitDTzEQee6CxS0wsaKs=; b=nEymJzb5+zEBWXnsKKDBCg8z6Yaew3mf2S3f+MSSSCAr2zILSi8Mcx4Ppbs0pARWQu qHyqvukiansdpU7WubaxPcaBTyjWD+WRGX65gAmTu34gy8dEmzCIk/WVPF9ABMQiHi8W bOP5fUKRb4wmL/LjwcW4OaXQBEHZXvAgOpljVByQ8YBhAW7Ob8oha4uz4Vzg1Gz7qakg x9Y5WT/fLXhVM3IVRjOqpKRGFflMKkLgXHjUVqyN6VyYnggh4QTiKhZMEQUtsrChB/6+ HWqS4JyLgdZuWClCl78zyZVeB5k8DMSsDhmIaQd6chUmE8GnWRMSszCJq8H+Q/oqdQRa QwoQ== X-Forwarded-Encrypted: i=1; AKwUvBwvmWx7jlxZaeQqN/C2r8plzYW8g91ldI1iyvYPVKoUZJIG18GLVqcPGEYdBOE5KxRS+oN397aYe/c=@passt.top X-Gm-Message-State: AFq9FYJ6Fc0WZpNbUnyJ1OCec8lOrH+5N8QXT0+3JYhCGNZidR7WbpCi FfWTRjH029haJNsLAl2R+qsFRIW4Vs+07VyTkySX5Wi4u7VxeI7ufkU5w8A5eK1PX0KxUH/Xpg8 qLas2hfDS2uYxOkTvzwwaKvjEDcrJvlNJc3cAdn195MhNTzqLVjXQB1FDCseQ3A== X-Gm-Gg: AYBFou3BScO+qjzvonTR+WOw3Er0LTwpjC9OCFp1n7Z8sOMGdxNB7W/zRbjM/j0+HxW MB0myUdnrkEgbX1DhRLINufxnBHFU/oH7CiejFuOB0EqYog0QQa4z4dCVZimIirbkmnIWG480P7 XjrU5fyK/vi49aJlWT3GbLhvHFH5xcYgrZbN6L/hHL/w9ugRIrqsGKzie32ZPHSuMyiOzQ8VFPM Mnr8p1uuAwLiUnDCD8REQ/bx1nbhoJPY63RR5QfEnlm4W+9SvemhhOk2liThh5hgm1oSNYQ+Yy+ e75OXZ3EAF1Iks3lrQIWng8AjbZOpYEwZTL5kjAZGOoN/9FrTUJr79B3Ut+pmpQ2lclN5BAHx8u G0liVtB9/7A== X-Received: by 2002:a05:6000:2610:b0:488:5c28:94d0 with SMTP id ffacd0b85a97d-48c72790027mr612529f8f.19.1791313487226; Tue, 06 Oct 2026 12:04:47 -0700 (PDT) X-Received: by 2002:a05:6000:2610:b0:488:5c28:94d0 with SMTP id ffacd0b85a97d-48c72790027mr612491f8f.19.1791313486641; Tue, 06 Oct 2026 12:04:46 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48c71d1ffd2sm1101129f8f.34.2026.10.06.12.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 12:04:45 -0700 (PDT) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v11] pasta: Refactor pasta_ns_conf() to reduce nesting Message-ID: <20261006210444.68364364@elisabeth> In-Reply-To: <20261002193444.1696431-1-jmaloy@redhat.com> References: <20261002193444.1696431-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 06 Oct 2026 21:04:45 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yOJY8z_-vZbu67aBX_kUeVKjlAcQ4LyQ0WSqibSUGyg_1791313487 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OSLVZUTA32O6254Z5JJGVGABPSSX3DHM X-Message-ID-Hash: OSLVZUTA32O6254Z5JJGVGABPSSX3DHM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 2 Oct 2026 15:34:44 -0400 Jon Maloy wrote: > Extract address and route configuration into two new helper functions > pasta_conf_addrs() and pasta_conf_routes(), and replace the outer > if (c->pasta_conf_ns) block with an early return. This reduces > indentation and eliminates the goto labels. > > No functional change. > > Signed-off-by: Jon Maloy > Reviewed-by: David Gibson Applied finally, sorry for the delay. -- Stefano