From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E1RETDof; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 20EB55A0272 for ; Thu, 08 Oct 2026 00:06:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791410775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nOGGVT4EFD244XKe//+GM2e43RM47Vep8Bd/r6FQSMw=; b=E1RETDof/kCoPuXkmd8dnHjTuln9XBQsrGhqYavk8XaYZFdaleAnfazC7n2hEI0jQ9WGwl HDPgpmBTe254b+MTEfwkjIsnS4V9TXCsZ5cQYnQ/rf+gYDTWEaTfiJbm5+cpaZaBZshPk0 yvp6MAwvqPKC5NhPGXN7o16ZcOKX/KQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-1lqNCXRcOQe6To9k1-P6HA-1; Wed, 07 Oct 2026 18:06:14 -0400 X-MC-Unique: 1lqNCXRcOQe6To9k1-P6HA-1 X-Mimecast-MFC-AGG-ID: 1lqNCXRcOQe6To9k1-P6HA_1791410773 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a0284121c6so34184475e9.3 for ; Wed, 07 Oct 2026 15:06:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791410773; x=1792015573; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=nOGGVT4EFD244XKe//+GM2e43RM47Vep8Bd/r6FQSMw=; b=sI85MvaoQcEKgrx8CdGwAtqiaPkiuRYHg2UE1zDpZfIhgfc2Gw+NGgIIf0ULFIeUtG ISZvaPD+tN/+zRMJ0rBQnHzaIDNgpPaRENZYr6JtOFv2ABClB90vyguUenLCTLP8Fn7+ 42Aj6SJqhmE9ylC8nDbETbM7jQ2CAkO0uD+gvXZblkooh6+RNYkYuQPJG/V/Xp9Pv7Lz 3CiNSBDd5FJ/a59v6WAA1o2HtNwl0Hyp4+IsS69d6mJHvqAkMZE9PKGXWIiWdFn3FlxV RKBbUviiWgkJTJWgQDLX8ZrLr7UcBH6uwko/7Glm3eBiTT8DI8BCqFgardSO1UMnQms5 7Pfw== X-Gm-Message-State: AFuF++njIJKQv/UIwKYs40/gWRHYFHpo3c2xW4v0NgVyzqcy5dlNpx3L 5VHEolMY19b6OpIEhSmURhl8WnXlvyjRTmNumo+aoZ7Lq3+bpsDImf6AlWdsFe0PbgSYyHWjxma PTCkvBptQCAfZo+6wpy8MFQ1mlayH1Qj8uChou/t5QjPM6CsRHwEp9tynAOTBerci7s3GZYOrzq TA6ddN4PvOGYG3W8KoGURNb52nPAXa0sb05D/s X-Gm-Gg: AYBFou2L74/R4TbOklu1ItnchD5uIYyzxY83lWOniS4uHefFqidfMFrBcjU/c8f18Jr RvOcWJHu8rwrE8V+ptpyHvDMX67JC8BKV9x8UIn0ZnWDMqoU8xHBz+PSWC2t8On28zv9nSwjx5x Iogd5CLm2/yQabu8hEHjwctzGNkdgvw6T8j/Z4hLlMuyqli4ZeA92+W9QuB7fAJSmD1QlOc7TLz Fq9cfiXKHeA/O5eXzlpxgUbvjlf1O8eBZdyZSOpnHoqUU2ebM3PfQfW127sAhRUowWElKnQXsny b1XbXhiNtV8G3oU2H43/5OxcvXKmsappbwyjJipaTzRzPrawLViQuiW4ocQnQXwaVkbdWSvXFSl tuqgPvsISIT+T+WnH3yCr+x+IvsI= X-Received: by 2002:a05:600c:800c:b0:4a0:263b:1f77 with SMTP id 5b1f17b1804b1-4a18043dd89mr73271235e9.8.1791410773390; Wed, 07 Oct 2026 15:06:13 -0700 (PDT) X-Received: by 2002:a05:600c:800c:b0:4a0:263b:1f77 with SMTP id 5b1f17b1804b1-4a18043dd89mr73270625e9.8.1791410772775; Wed, 07 Oct 2026 15:06:12 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a181aeaea2sm71879155e9.5.2026.10.07.15.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 15:06:12 -0700 (PDT) From: Stefano Brivio To: Anshu Kumari Subject: Re: [PATCH v7 2/7] dhcp: Add option configuration tracking with enum opt_conf Message-ID: <20261008000610.14af81c4@elisabeth> In-Reply-To: <20261001131602.653553-3-anskuma@redhat.com> References: <20261001131602.653553-1-anskuma@redhat.com> <20261001131602.653553-3-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Thu, 08 Oct 2026 00:06:11 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tGJePTVkFkh0QhJPqUteYe1rLCmYBcntlYfgKzDlNwQ_1791410773 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: Q3KA7QFHUMRJ7JNSJ2DTYIIRHGJV2Y6L X-Message-ID-Hash: Q3KA7QFHUMRJ7JNSJ2DTYIIRHGJV2Y6L X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 1 Oct 2026 18:45:55 +0530 Anshu Kumari wrote: > @@ -243,6 +256,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len) > int i; > > opts[119].slen = 0; > + opts[119].conf = OPT_DEFAULT; I think that at this point, instead of doing this... > > for (i = 0; i < 255; i++) > max_len -= opts[i].slen; > @@ -291,7 +305,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len) > } > > if (!opts[119].slen) > - opts[119].slen = -1; > + opts[119].conf = OPT_UNSET; ...it would make more sense to simply set opts[119].conf here, that is: if (opts[119].slen) opts[119].conf = OPT_DEFAULT; -- Stefano